Commit Graph

92 Commits

Author SHA1 Message Date
volth
2b7681da85 Update xf_keyboard.c
With Japanese physical keyboard and English layout, pressing the extra keys can cause FreeRDP crash.
2015-09-23 18:40:34 +00:00
Bernhard Miklautz
421b74e85e client/locale: properly check popen return value
popen returns NULL if an error occurs and not < 0.
2015-06-22 19:23:58 +02:00
Bernhard Miklautz
d9d1759abc Fix compiler warnings:
gcc 4.7.2

client/X11/xf_keyboard.c: In function ‘xf_keyboard_action_script_init’:
client/X11/xf_keyboard.c:48:6: warning: unused variable ‘exitCode’
[-Wunused-variable]

gcc 4.9

client/X11/xf_client.c: In function ‘xf_client_thread’:
client/X11/xf_client.c:1537:3: warning: ‘inputThread’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
2015-06-22 19:09:59 +02:00
Bernhard Miklautz
bf73f4e4f1 Fix unchecked strdups
* add missing checks
* adapt function return values where necessary
* add initial test for settings
2015-06-22 19:09:59 +02:00
David FORT
29d372480a Take in account nfedera's review 2015-05-20 19:19:50 +02:00
Hardening
f8120919af Add checks for some XXX_New and XXX_Add functions
Based on PR #2616
2015-05-18 11:28:00 +02:00
Bernhard Miklautz
2c072d33d3 Fix GDI return values and other fixes
* top level GDI functions return 0 on error and != 0 otherwise but the
  low level functions (16bpp.c, 8bpp.c 32bpp.c) which are called did it
	exactly the other way around. Those were adapted.
* change gdi_InvalidateRegion to BOOL and check calls where appropriate
* integrate comments from pull request
2015-04-21 14:18:07 +02:00
Bernhard Miklautz
515502ffa5 change return types of callbacks to BOOL
* change all client/server callbacks to BOOL
* update all clients accordingly
* add multiple return value checks
* small fixes
2015-04-21 14:18:07 +02:00
Norbert Federa
6354a7561c xfreerdp: rename xf_context's width height vars
Since several contributers in the past repeatedly made the error
to treat xfc->width and xfc->height as equal with the x11 window
width and heigth I've renamed these variables to sessionWidth and
sessionHeight.
2015-04-16 17:31:22 +02:00
Seray Rosh
ffa7f0363f release keys when xfreerdp is unfocused to prevent stuck keys 2015-02-27 16:02:40 +01:00
Norbert Federa
344362a8a3 clients: fix "focus in event" issues
The input->FocusInEvent callback implementations (normal and fast-path) have
always sent the mouse position even if the pointer was outside of the freerdp
client area. In addition xfreerdp used the wrong pointer coordinates which
were relative to the root window instead of its own.
On focus-in the pointer position must only be sent if the pointer is
currently within the program's client area. However, the clients had no way
to pass that information to input->FocusInEvent which required an API change.

- removed mouse pointer x, y parameters from input interface's FocusInEvent
- clients are responsible to call input->MouseEvent on focus-in if necessary
- fixed xfreerdp and wfreerdp accordingly
2015-01-16 18:40:57 +01:00
Norbert Federa
25f66d2e6d xfreerdp: added smart sizing, mt gesture fixes
- removed setting ScalingFactor
- added settings SmartSizingWidth and SmartSizingHeight
- changed option /smart-sizing to optionally support <width>x<height>
- consolidated transformation of input event coordinates
- rdp8 gfx ignored scaling and panning offsets: fixed
- never resize window on panning/pinching
- simplified keyboard multitouch gesture debugging emulation
- disabled keyboard multitouch gesture emulation debug code via define
2014-12-01 11:56:44 +01:00
Norbert Federa
3fa3384eb4 xfreerdp: several fixes for panned/pinched drawing
- use bilinear filter instead of nearest filter
- fixed invalid transformation matrix
- support non-proportional scaling
- fix calculation of transformed coordinates (rounding errors)
2014-12-01 11:17:16 +01:00
Armin Novak
e20da04d15 Fixed uninitialized argument value. 2014-11-16 15:37:13 +01:00
Marc-André Moreau
1225c6b5ce xfreerdp: separate app windows from desktop windows 2014-11-11 22:27:33 -05:00
Bernhard Miklautz
36c2523d68 xfreerdp: add support to set keyboard indicators
* add generic function to check for X extensions
* detect x keyboard support
* add callbacks and client code to set/clear keyboard indicators
2014-10-06 10:37:37 +02:00
Armin Novak
7913a57bc5 Using wlog for logging in clients now. 2014-09-15 08:55:00 +02:00
Ron Yaari
1b819067b0 X11: fix toggle-fullscreen option functionality 2014-08-18 10:41:40 +03:00
Idan Freiberg
27f5eaba88 Revert "X11: fix toggle-fullscreen option functionality"
This reverts commit 0c84c81401.
2014-08-18 10:39:47 +03:00
Ron Yaari
0c84c81401 X11: fix toggle-fullscreen option functionality 2014-08-18 10:19:47 +03:00
Marc-André Moreau
067da290dd Merge pull request #2027 from akallabeth/winpr-log
Replace stdout and logging defines with WLog, add logcat support
2014-08-11 10:38:28 -04:00
Armin Novak
0780c0993e Replaced fprintf(stderr with DEBUG_WARN 2014-08-07 22:21:07 +02:00
Daryl Poe
3794720455 correct Pause key sequence
(cherry picked from commit 46a00b5c9e)
2014-07-25 11:31:50 +02:00
Marc-André Moreau
e42465372a xfreerdp: initial remote assistance controls (ctrl+alt+c to request/release control) 2014-06-30 17:17:06 -04:00
Marc-André Moreau
84cef49678 xfreerdp: treat Super key differently 2014-03-25 12:27:06 -04:00
Marc-André Moreau
234a3fa453 xfreerdp: add action script options for X11 events 2014-03-22 17:12:50 -04:00
Marc-André Moreau
770defc706 xfreerdp: add registration of key combinations 2014-03-22 14:40:52 -04:00
Marc-André Moreau
208085a894 xfreerdp: add ability to script key combinations 2014-03-14 00:11:44 -04:00
Marc-André Moreau
186172fa78 xfreerdp: cleanup keyboard code 2014-03-13 21:10:22 -04:00
Marc-André Moreau
1fc2d780f7 libfreerdp-core: fix memory leaks reported by valgrind 2013-10-31 23:35:24 -04:00
C-o-r-E
e7b0d18b9b xfreerdp: comment cleanup 2013-07-23 14:47:40 -04:00
C-o-r-E
1e085197a9 some additional cleanup 2013-06-27 17:16:55 -04:00
C-o-r-E
6f3cc12b2c fixed deadlock in pubsub, remove scale from xf_context 2013-06-27 14:24:46 -04:00
C-o-r-E
27cb96e577 work in progress 2013-06-27 03:59:49 -04:00
C-o-r-E
11b0a9f185 xfreerdp-client: attempted fixing build 2013-06-26 19:16:28 -04:00
C-o-r-E
340c3a4246 merged completely (painful) from awakecoding's tree 2013-06-25 20:41:32 -04:00
Marc-André Moreau
bb78fb16f8 xfreerdp: refactor to make use of single xfContext* and remove xfInfo* 2013-06-12 18:57:25 -04:00
C-o-r-E
1640652ee0 core: added OnPan, xfreerdp: modified special keys 2013-06-10 19:52:16 -04:00
C-o-r-E
27c1a73836 xfreerdp-client: temporarily allow +xy panning 2013-06-05 13:59:34 -04:00
C-o-r-E
cdc294003d freerdp-client: formatting 2013-05-30 09:27:20 -04:00
C-o-r-E
17fd2dcbfa Merge remote-tracking branch 'upstream/master' 2013-05-27 19:50:19 -04:00
C-o-r-E
ab2cd6fd1c xfreerdp-client: more fixes with XRender 2013-05-16 16:20:25 -04:00
C-o-r-E
0db2e9cbf4 xfreerdp-client: fixes to xrender operations 2013-05-16 15:15:19 -04:00
C-o-r-E
ac465719b1 xfreerdp-client: adjust max zoom to 120% 2013-05-15 14:53:46 -04:00
C-o-r-E
3d931a048e xfreerdp-client: fix some updating screen size 2013-05-15 13:58:21 -04:00
Nigel Reeves
7adab0f79c Prevent segfault when start a RAIL remote Application 2013-05-15 09:42:21 +01:00
C-o-r-E
e37e678021 xfreerdp-client: refactored window resize 2013-05-14 16:18:57 -04:00
C-o-r-E
cea1534771 xfreerdp-client: fixed handling of hints 2013-05-14 14:29:43 -04:00
C-o-r-E
84fbc1159c xfreerdp-client: fixed pan constraints 2013-05-14 12:43:42 -04:00
C-o-r-E
152af5bfc9 xfreerdp-client: fixed pan lag 2013-05-14 12:01:18 -04:00