Marc-André Moreau
6b1fefea40
freerdp: fix remote assistance mode, add multi-address connection
2015-05-06 16:32:45 -04:00
Norbert Federa
ef1fd12b15
Fix unchecked CreateEvent calls and misc fixes
...
1)
Added missing checks for CreateEvent which also required the
following related changes:
- changed freerdp_context_new API to BOOL
- changed freerdp_peer_context_new API to BOOL
- changed pRdpClientNew callback to BOOL
- changed pContextNew callback to BOOL
- changed psPeerAccepted callback to BOOL
- changed psPeerContextNew callback to BOOL
2)
Fixed lots of missing alloc and error checks in the
changed code's neighbourhood.
3)
Check freerdp_client_codecs_prepare result to avoid segfaults
caused by using non-initialized codecs.
4)
Fixed deadlocks in x11 caused by missing xf_unlock_x11() calls
in some error handlers
5)
Some fixes in thread pool:
- DEFAULT_POOL assignment did not match TP_POOL definition
- don't free the pool pointer if it points to the static DEFAULT_POOL
- added error handling and cleanup in InitializeThreadpool
2015-04-29 18:18:39 +02:00
Jonathan Kaplan
8dee5dab27
Fix issue when numWindowIds is 0
2015-04-28 00:21:38 -07:00
Norbert Federa
af79c30913
Merge pull request #2554 from akallabeth/event_fix
...
Fix for transport event reset
2015-04-22 11:04:37 +02:00
Hardening
6cd7713e12
Merge pull request #2544 from bmiklautz/boolenization
...
change return types of callbacks to BOOL
2015-04-22 11:01:27 +02:00
Bernhard Miklautz
159306fc7a
Increase API version to 1.2.2
2015-04-22 10:23:25 +02:00
Bryan Everly
8c75127a67
Necessary changes to get latest branch working on OpenBSD 5.6
2015-04-21 14:42:06 -04:00
Bernhard Miklautz
b029e78ae7
Merge pull request #2537 from MartinHaimberger/mh-autodetect-fix
...
autodetect: debug fixed and level adjusted
2015-04-21 16:52:32 +02:00
Armin Novak
65a4c6e1fc
Changed listener callback arguments and return.
2015-04-21 15:57:25 +02:00
Armin Novak
90fa0e3fc6
Fixed handle copy and index.
2015-04-21 15:10:17 +02:00
Bernhard Miklautz
2c072d33d3
Fix GDI return values and other fixes
...
* top level GDI functions return 0 on error and != 0 otherwise but the
low level functions (16bpp.c, 8bpp.c 32bpp.c) which are called did it
exactly the other way around. Those were adapted.
* change gdi_InvalidateRegion to BOOL and check calls where appropriate
* integrate comments from pull request
2015-04-21 14:18:07 +02:00
Bernhard Miklautz
515502ffa5
change return types of callbacks to BOOL
...
* change all client/server callbacks to BOOL
* update all clients accordingly
* add multiple return value checks
* small fixes
2015-04-21 14:18:07 +02:00
Armin Novak
d98e485ac0
Fixed some type mismatches.
2015-04-21 12:35:55 +02:00
Armin Novak
d3336340ba
Add *get_event_handles handle count, return check.
2015-04-21 12:24:50 +02:00
Armin Novak
6e213bc61b
Modified GetEventHandles of listener
...
Now using nCount as in and out argument.
When called, set nCount to the number of available handles.
This value is checked and an error returned, if not enough
handles are available.
2015-04-21 12:09:44 +02:00
Bernhard Miklautz
12e256bb8e
Merge pull request #2538 from MartinHaimberger/mh-add-transport-get-bytes
...
transport: added function to get bytes written
2015-04-20 18:34:13 +02:00
Armin Novak
f634e52289
Using auto reset event now.
2015-04-20 15:04:44 +02:00
Armin Novak
5525d9f88b
Fixed uninitialized return value.
2015-04-15 10:38:04 +02:00
Marc-André Moreau
4e1194c53b
Merge pull request #2532 from dbungert/4bytestub
...
GW RPC-HTTP - 2 fixes
2015-04-14 09:23:47 -04:00
Martin Haimberger
5504f4261d
autodetect: debug fixed and level adjusted
...
Fixed two debug statements and moved
to TRACE debug level
2015-04-14 03:54:33 -07:00
Martin Haimberger
9c0d275548
transport: added function to get bytes written
...
added function to get written bytes on transport.
This is needed to get a more accurate bandwidth
management.
2015-04-14 03:49:01 -07:00
Norbert Federa
951a40b639
Merge pull request #2517 from bmiklautz/alloc
...
winpr allocation checks
2015-04-14 11:57:33 +02:00
Armin Novak
ea0e255058
Fixed broken pad setting.
2015-04-13 09:28:29 +02:00
Daniel Bungert
0a1273e508
GW RPC-HTTP - Don't drop 4 byte stub from the pipe
...
* Though not frequent, it's possible to get TsProxySetupReceivePipe
data of stublength 4 that is actual data. This happens when
header->common.call_id == rpc->PipeCallId &&
!(header->common.pfc_flags & PFC_LAST_FRAG).
This should address GW disconnects that manifest as SSL read errors.
2015-04-10 15:09:54 -06:00
Daniel Bungert
3910baf49d
GW RPC-HTTP login fix
...
* f469e069dc
introduced a logic flip
that broke RPC-HTTP Gateway. Fix that.
2015-04-10 14:50:17 -06:00
Bernhard Miklautz
423b15108d
Merge pull request #2522 from realjiangms/fix_WriteLock_leak
...
transport_write sometimes returns directly without cleanup.
2015-04-08 15:39:10 +02:00
zihao.jiang
a057526f1e
transport_write sometimes returns directly without cleanup. Fix code path to always do cleanup job.
2015-04-08 21:20:07 +08:00
Bernhard Miklautz
850de59b55
winpr: add checks for *alloc
...
Add missing checks if memory allocation was successful. Also adapt
caller(s) when possible.
2015-04-08 11:34:37 +02:00
Bernhard Miklautz
879ed36a3c
Merge pull request #2513 from hardening/license_and_security_retValues
...
License and security ret values
2015-04-08 11:33:57 +02:00
David FORT
c03bf75896
Take in account @nfedera's comments
2015-04-07 21:06:53 +02:00
David FORT
c0b191a1c6
Fix a too big Stream_EnsureRemainingCapacity()
2015-04-07 15:19:59 +02:00
David FORT
d84c760f7d
Fix a typo in server-side code
2015-04-01 22:26:38 +02:00
David FORT
a4a58aa373
Fix the error case in mcs_send_connect_response()
2015-04-01 17:55:01 +02:00
David FORT
23e11e5a3d
Fix code style
2015-04-01 16:58:25 +02:00
David FORT
5302bad2b7
Drop the limit on key size
2015-04-01 15:11:57 +02:00
David FORT
edb915943f
Treat return values in license.c
...
This patch changes functions that should not return void and also treat the
callers of these functions.
2015-04-01 11:38:53 +02:00
David FORT
0cf17ef98c
Complement gitignore files with new generated files
2015-04-01 11:13:05 +02:00
David FORT
0eb399a717
Treat return values for security.c
...
This patch make functions in security.c return values when they should instead of
beeing void. And it also fix the callers of these functions.
2015-04-01 11:11:37 +02:00
David FORT
cf8c7631bd
Kill more exit() occurences
...
In general we should not have any exit() call in libfreerdp.
2015-03-31 23:56:40 +02:00
Marc-André Moreau
121ea23595
Merge pull request #2487 from mfleisz/nla_fix
...
Fix server side NLA
2015-03-31 10:55:04 -04:00
Armin Novak
6b0667c959
Fixed use after free and realloc checks.
2015-03-31 15:18:45 +02:00
Hardening
bdb975afe8
Merge pull request #2510 from akallabeth/build_date
...
Added version and build info functions
2015-03-30 19:14:59 +02:00
Bernhard Miklautz
79de8168f9
Integrate feedback from pull request
...
* orders.c: remove ; at eol
* rdpdr_main.c: simplify error case
* rdpsnd_pulse.c: fix incorrect check
* rdpsnd_main.c: adapt return value according to documentation
* update.c: fix incorrect return values
2015-03-30 18:29:32 +02:00
Armin Novak
8e521e7aee
Fixed return value in test.
2015-03-30 18:18:14 +02:00
Armin Novak
eedf45583a
Using sprintf_s now.
2015-03-30 18:17:07 +02:00
Armin Novak
0adab13719
Now returning const char*
2015-03-30 18:09:02 +02:00
Armin Novak
cf941304b3
Fixed windows _snprintf.
2015-03-30 18:05:46 +02:00
Armin Novak
827b4f76ca
Added test for freerdp version functions.
2015-03-30 17:57:16 +02:00
Armin Novak
8f228163a8
Added version and build info functions
...
Added functions to get
* Version String
* Build Time String
* Git Revision String
and appropriate tests.
2015-03-30 17:51:29 +02:00
Bernhard Miklautz
74c8400789
coding style fixes
...
Add missing space after if
2015-03-30 17:15:45 +02:00