Commit Graph

13093 Commits

Author SHA1 Message Date
Armin Novak
696390f027 Fixed missing return value check. 2019-04-05 09:13:24 +02:00
Armin Novak
1da57d0b7e Fixed sign-compare warnings 2019-04-05 09:13:24 +02:00
Armin Novak
9610faddaa Fixed sign-compare warnings 2019-04-05 09:13:24 +02:00
Armin Novak
73a6e7052b Fixed free checks to eliminate bad free warnings. 2019-04-05 09:13:24 +02:00
Armin Novak
a1e15b671e Fixed sign-compare warnings 2019-04-05 09:13:24 +02:00
Armin Novak
b205ccbd5a Fixed NSC SSE argument checks. 2019-04-05 09:13:24 +02:00
David Fort
37358e81d0
Merge pull request #5285 from akallabeth/urbdrc_preparations
Channel, log debug and semaphore related fixes
2019-04-04 18:21:47 +02:00
David Fort
a63f717871
Merge pull request #5309 from smaeul/patch/ntlm
Fix NTLM AvPair lists
2019-04-04 18:19:56 +02:00
David Fort
39f7486211
Merge pull request #5318 from akallabeth/filetime_fix
Fix #5317: Change file attributes before modifying file time.
2019-04-04 18:06:22 +02:00
David Fort
cfbf22348e
Merge pull request #5251 from akallabeth/wayland_cursor_handling_fix
Moved wayland cursor handling to seat.
2019-04-04 18:05:28 +02:00
David Fort
058ae0db57
Merge pull request #5273 from akallabeth/mac_compile_warning_fix
Fixed mac compilation warnings.
2019-04-04 18:03:50 +02:00
David Fort
901bc25397
Merge pull request #5319 from akallabeth/clip_file_fix
Fixed \0 terimination of clipboard file list
2019-04-04 18:02:41 +02:00
Armin Novak
745c6b933a Fixed \0 terimination of clipboard file list 2019-04-03 10:17:51 +02:00
Armin Novak
485061e4d0 Fix #5317: Change file attributes before modifying file time. 2019-03-29 15:45:52 +01:00
David Fort
52bce4745f
Merge pull request #5249 from akallabeth/mac_timer_crash_fix
Mac timer crash fix
2019-03-28 19:05:48 +01:00
David Fort
c5156443e7
Merge pull request #5281 from akallabeth/assistance_ssl_init_fix
Fixed #5276: Enable SSL before parsing assistance file.
2019-03-28 19:04:25 +01:00
David Fort
b34183152c
Merge pull request #5295 from akallabeth/stream_macro_fix
Fixed Stream_* macros, bracing arguments.
2019-03-28 19:02:19 +01:00
David Fort
74f0bdf99e
Merge pull request #5313 from m4ntis/fix-end-paint-log-level
Fix update_end_paint wrong log level
2019-03-20 21:28:37 +01:00
kubistika
d3dd0860a5 update.c: Fix update_end_paint wrong log level 2019-03-20 22:01:08 +02:00
Bernhard Miklautz
2842b85d9b
Merge pull request #5307 from akallabeth/flatpak_dep_fix
Updated flatpak udev build script
2019-03-19 12:38:00 +01:00
David Fort
c04cd49bac
Merge pull request #5311 from m4ntis/bugfix/gfx-w2s2-decode
Fix Wire to Surface 2 pixel format decode on client
2019-03-19 09:38:40 +01:00
Mati Shabtay
5d808226af client/rdpgfx_main.c: Fix wire to surface 2 pixel format decode 2019-03-18 16:07:18 +02:00
cerg2010cerg2010
7abc86ffae Close file handle correctly. (#5310) 2019-03-18 14:57:00 +01:00
Samuel Holland
6931f54fad Fix NTLM AvPair lists
There were two main issues here: First, the `ntlm_av_pair_add` and
`ntlm_av_pair_add_copy` were not adding a new `MsvAvEOL` to the end of
the list to replace the one they overwrote. This caused the second call
to one of those functions to fail (since it couldn't find the
terminator), which was the source of the test failure. It also caused
`ntlm_av_pair_list_length` and `ntlm_print_av_pair_list` to read out of
bounds until they happened to find the right word.

Second, several bounds checks were wrong or missing. For example,
`ntlm_av_pair_add` does not ensure that the value fits inside the list.
And `ntlm_av_pair_get_len` and `ntlm_av_pair_get_value_pointer` can
return error codes or NULL, but those error returns were ignored, and
the values used anyway (such as in `ntlm_av_pair_add_copy`).

This fixes the list handling code to have the invariant that all
functions returning `NTLM_AV_PAIR*` only return non-`NULL` if the entire
returned `AvPair` is within bounds. This removes the need for the length
parameter in functions that only operate on a single `AvPair`. This
check is performed by the new `ntlm_av_pair_check` helper, which is
added in some new places and used to simplify the code in others.

Other issues fixed along the way include:
 - `ntlm_av_pair_list_length` did not cast to `PBYTE`, so it was
   returning the number of `NTLM_AV_PAIR`-sized chunks (which was
   possibly not even an integer) instead of the number of bytes
 - I removed an impossible check for `offset <= 0` in
   `ntlm_av_pair_get_next_pointer`
 - The assertion that `Value != NULL` and the call to `CopyMemory` are
   only necessary if `AvLen` is nonzero
 - `ntlm_av_pair_get_next_pointer` (renamed to `ntlm_av_pair_next`)
   could be declared `static`

With this commit, TestNTLM now passes on powerpc64.

```
$ ./Testing/TestSspi TestNTLM
NTLM_NEGOTIATE (length = 40):
NTLM_CHALLENGE (length = 168):
NTLM_AUTHENTICATE (length = 352):
$ echo $?
0
```

Fixes #5250
2019-03-17 20:40:13 -05:00
Armin Novak
3cd435b16e Fixed flatpak pcsd build 2019-03-15 08:52:07 +01:00
Armin Novak
5220c341b7 Updated flatpak udev build script 2019-03-15 08:47:20 +01:00
Mati Shabtay
88b7859c87 server/rdpgfx_main.c: Fixed caps advertise PDU recv (#5304) 2019-03-15 08:37:35 +01:00
Martin Fleisz
6e2cfef5a3
Merge pull request #5297 from akallabeth/nla_server_functions
Exposing NLA functions to impersonate and revert context.
2019-03-08 10:44:09 +01:00
Armin Novak
67be5258ad Exposing NLA functions to impersonate and revert context. 2019-03-08 10:10:43 +01:00
Armin Novak
e5fbff357e Fixed Stream_* macros, bracing arguments. 2019-03-07 09:29:32 +01:00
David Fort
435872b417
Merge pull request #5294 from akallabeth/gfx_temporary_disable_new
Temporarily disable GFX version >= 10.3
2019-03-04 09:28:15 +01:00
Ilya Shipitsin
7f97574501 client/Windows/wf_event.c: add missing "break" (#5293)
found by cppcheck

[client/Windows/wf_event.c:464] -> [client/Windows/wf_event.c:468]: (warning) Variable 'xNewPos' is reassigned a value before the old one has been used. 'break;' missing?
2019-03-04 09:17:10 +01:00
Armin Novak
11cefecb7b Temporarily disable GFX version >= 10.3 2019-03-04 09:07:27 +01:00
Martin Fleisz
da66485b3d
Merge pull request #5252 from akallabeth/big_endian_fix
Fixed endianess issue with GETPIXEL16 and GETPIXEL32
2019-03-01 10:06:56 +01:00
Martin Fleisz
ce386c8555
Merge pull request #5289 from akallabeth/gfx_crash_fix
Disabled RDPGFX_CAPVERSION_106 for good.
2019-02-28 13:58:10 +01:00
Armin Novak
9be2324be8 Disabled RDPGFX_CAPVERSION_106 for good. 2019-02-28 13:43:11 +01:00
MartinHaimberger
46b1e88a70
Merge pull request #5027 from akallabeth/wlog_off_fix
Fix #5024: Update inherited log level for all child loggers when setting a new one.
2019-02-28 10:55:12 +01:00
Armin Novak
e9c4173c9b Fixed winpr_HexLogDump line length calculation. 2019-02-28 09:54:05 +01:00
Martin Fleisz
42dafc34ea
Merge pull request #5288 from akallabeth/rdp_spec_updates
Rdp spec updates
2019-02-28 09:35:15 +01:00
Armin Novak
bff5ded654 Better bounds checks for winpr_HexLogDump 2019-02-28 08:50:44 +01:00
Armin Novak
69e9571d9e Fixed EGFX capability parsing, respect length fields.
Disable RDPGFX_CAPVERSION_106 as we currently do not support scaled
outputs.
2019-02-27 17:15:43 +01:00
Armin Novak
e8c8e7b6d0 Updated EGFX support to 10.6 2019-02-27 16:36:15 +01:00
Armin Novak
69f4c4b4af Fixed version magic mismatch with [MS-RDPBCGR] 2019-02-27 16:30:55 +01:00
Armin Novak
4e31cf929e Fixed ReleaseSemaphore, respect lReleaseCount
Signal the semapore lReleaseCount times.
2019-02-26 15:33:51 +01:00
Armin Novak
982ee67a4c Initialize ppKeys to NULL in HashTable_GetKeys
Ensure ppKeys=NULL in case of a function failure or empty table.
2019-02-26 15:32:22 +01:00
Armin Novak
32aa11251b Added a logger dump function operating on a preallocated logger. 2019-02-26 15:31:47 +01:00
Armin Novak
0bba166020 Force close channel, use defines instead of magic numbers
* When senging a close request for a dynamic channel close the channel
  immediately. A response from the server is not guaranteed.
* Use the *_PDU defines instead of magic numbers when creating
  dynamic channel messages.
2019-02-26 15:29:30 +01:00
DraganNSDK
f002c7429b potential fix for ENTER (modifiers) stuck after CTRL-ALT-ENTER (toggle fullscreen), clearing the buffer in xk_keyboard_update_modifier_keys. (#5280)
* xk_keyboard_update_modifier_keys fixed to clear the buffer.

* removed the xf_keyboard_clear(xfc) fix comments
2019-02-25 12:44:51 +01:00
Armin Novak
49936a7ba6 Fixed #5276: Enable SSL before parsing assistance file.
The assistance file requires primitives from the ssl wrapper.
Enable these before parsing the file.
Additionally split the FIPS mode enablement from the one time
initializer to avoid ignoring that flag.
2019-02-25 10:37:30 +01:00
Jiajun Wang
fd27451768 Fixed TS_INFO_PACKET (#5275)
Those fields exclude the length of the mandatory null terminator:
* cbDomain
* cbUserName
* cbPassword
* cbAlternateShell
* cbWorkingDir
2019-02-22 17:31:42 +01:00