Commit Graph

672 Commits

Author SHA1 Message Date
Bernhard Miklautz
a8ab91616c Fix host fingerprint lenght in know_hosts file
The fingerprint that was written to the known_hosts file was
one byte to short. For hosts, already in know_hosts, a warning to
update the hosts key in the know_hosts is printed.
For new hosts the key is added with the right length.

Based on 495aba9
fixes #1007
2013-02-27 01:00:22 +01:00
Bernhard Miklautz
25260bd717 Merge pull request #1012 from hardening/stableFixes
backported changes on ber.c around 0x80 length
added a path to a RDP key file or the server crashes
2013-02-26 23:09:17 +01:00
hardening
6bd5070b1f Backported 026e9996d3 2013-02-26 22:31:16 +01:00
Bernhard Miklautz
99492506d8 Changed some functions from inline to static inline
This fixes inline build issues with clang.
http://clang.llvm.org/compatibility.html#inline
(cherry picked from commit 1d32894775)
2013-02-20 02:04:16 +01:00
hardening
11c46d804d Fixed more function declarations that aren't prototypes 2013-02-14 21:49:58 +01:00
Nigel Reeves
43ef3785c6 Fix to ensure channels are rejoined on a server redirect operation 2013-01-24 11:40:24 +00:00
Mike Carifio
19c6f93e2d xfreerdp: Adds switch --from-stdin.
This switch will prompt username, password, domain and connection
host if not specified at the command line.

Signed-off-by: Rex Tsai <chihchun@kalug.linux.org.tw>
(cherry picked from commit a31f0c62e6)

Conflicts:
	client/X11/xfreerdp.1.xml
	client/X11/xfreerdp.c
	include/freerdp/settings.h
	libfreerdp-core/settings.c
	libfreerdp-utils/args.c
2012-10-27 15:28:47 +02:00
Ying-Chun Liu (PaulLiu)
69dd64c5b7 Init extensions in pre_connect stage.
Due to the client is parsing the args in pre_connect,
we should start loading the extensions after client parsing the args.

Signed-off-by: Ying-Chun Liu (PaulLiu) <paul.liu@canonical.com>
(cherry picked from commit 48ad5feb0a)

Conflicts:
	libfreerdp-core/rdp.c
2012-10-27 14:59:18 +02:00
Pieterjan Camerlynck
7dded76f0e libfreerdp-core: do not send SynchronizeEvent during connection finalization 2012-10-26 22:13:27 -02:00
Mads Kiilerich
024b93933e core: reset crypto key counters when the keys are initialized
This fixes --sec rdp --salted-checksum in combination with farm redirect.

The counters are implicitly set to 0 in rdp_new, but they also has to be reset
after redirects. Resetting the counters when the keys are reset seems like the
cleanest solution.
2012-03-25 07:26:26 -05:00
Jay Sorg
dd0d0f0bdb libfreerdp-core: fix for cursor hot spot out of range 2012-03-25 07:26:26 -05:00
Mads Kiilerich
6752fb4983 core: terminate redirect cookies correctly 2012-03-25 07:26:26 -05:00
Mads Kiilerich
b5133db680 core/redirect: be aware that transport used in transport_check_fds might become invalid 2012-03-25 07:26:26 -05:00
Vic Lee
2950ccf670 core: register audio device only if plugins are registered. 2012-03-25 07:26:25 -05:00
Pawel Jakub Dawidek
a46154e231 Accept both TLSv1 and SSLv3 as a server.
This fixes SSL connections from Microsoft RDC for Mac OS X to FreeRDP server.
2012-03-25 07:00:08 -05:00
Pawel Jakub Dawidek
78a4aa83c4 For salted checksums we need separate counters, as the
encrypt_use_count and decrypt_use_count counters are reset during key
regeneration and we need counters that are never reset.
2012-03-25 06:59:56 -05:00
Mads Kiilerich
93f0dad21b libfreerdp-core: don't add sec_bytes in fastpath_send_input_pdu
fastpath_input_pdu_init already reserved space for fastpath_get_sec_bytes()
which thus already was included in stream_get_length() in
fastpath_send_input_pdu(). Adding sec_bytes again just added extra invalid (but
correctly hashed/encrypted) bytes to the PDU.
2012-03-25 06:58:35 -05:00
Mads Kiilerich
c46cdaf3fb libfreerdp-core: fastpath_send_input_pdu can handle fastpath PDUs up to 32k 2012-03-25 06:58:35 -05:00
Anthony Tong
32aaa99541 libfreerdp-core: disable fp input if FIPS is negotiated 2012-03-25 06:57:16 -05:00
Pawel Jakub Dawidek
c8d961a55c Write fingerprint to proper descriptor. 2012-03-25 06:53:00 -05:00
Pawel Jakub Dawidek
9f744fc8d2 Advertise persistent bitmap cache only if it is enabled. 2012-03-25 06:46:00 -05:00
Marc-André Moreau
96dccad6fa libfreerdp-core: don't call freerdp_context_free() from freerdp_free() 2012-03-25 06:44:03 -05:00
Jay Sorg
45e5f5e713 libfreerdp-core: fix memory leaks and double free 2012-03-25 06:43:18 -05:00
Marc-André Moreau
caae69e980 libfreerdp-core: change source descriptor from MSTSC to FREERDP 2012-02-08 14:45:24 -05:00
Pawel Jakub Dawidek
e73a525ad5 Move the comment into correct place. 2012-02-08 12:47:22 +01:00
Pawel Jakub Dawidek
e9f89af8a5 The fastpath header can be two or three bytes long. Check also the latter case. 2012-02-08 12:03:39 +01:00
Marc-André Moreau
58e08a7726 Merge pull request #407 from hcgpalm/master
Fix info_packet misalignment
2012-02-07 20:27:16 -08:00
Marc-André Moreau
0975c0f07e libfreerdp-core: improve error checking in certificate validation 2012-02-07 22:16:57 -05:00
Otavio Salvador
986890b8b9 Merge pull request #404 from pjd/server_slow_path_input
Implement server-side support for slow-path Input Event PDU.
2012-02-07 05:01:53 -08:00
Pawel Jakub Dawidek
eb8c5c5f81 Implement server-side support for slow-path Input Event PDU. 2012-02-07 13:53:00 +01:00
Pawel Jakub Dawidek
1fa1331a54 Modify the UnicodeKeyboardEvent callback to also include flags argument.
According to the specification first two bytes contain keyboardFlags.
Those keyboardFlags are a bit different than in the regular (non-unicode)
Keyboard Event. There is no KBD_FLAGS_EXTENDED here and also when
key is pressed there is neither KBD_FLAGS_DOWN nor KBD_FLAGS_RELEASE flag
set. When key is released the KBD_FLAGS_RELEASE flag is set.
2012-02-07 12:22:01 +01:00
Pawel Jakub Dawidek
2ee9cc5e18 Simplify code by using per_read_length() instead of reimplementing it. 2012-02-07 11:16:47 +01:00
Pawel Jakub Dawidek
b75b5eb8a1 After DEACTIVATE ALL PDU server can send MCS Disconnect Provider Ultimatum PDU to disconnect.
Handle such condition and exit from xfreerdp gracefully (almost, exit status is still != 0).
2012-02-06 23:10:45 +01:00
Pawel Jakub Dawidek
d6592a17a9 Windows XP can send short (and non-standard) DEACTIVATE_ALL PDUs. Handle them properly. 2012-02-06 22:39:43 +01:00
Pawel Jakub Dawidek
4a950cedd7 Better packet length checking. 2012-02-06 22:39:33 +01:00
Christer Palm
ded92bc9cd Fix password field length 2012-02-06 01:27:21 +01:00
Marc-André Moreau
47de99062d libfreerdp-core: added --certificate-name option for explicitly specifying a certificate name 2012-02-04 15:16:41 -05:00
Marc-André Moreau
ffec1c2062 libfreerdp-core: improve and clarify certificate checking 2012-02-04 15:04:03 -05:00
Marc-André Moreau
4695faae38 libfreerdp-core: added check for certificate name against hostname 2012-02-04 02:21:39 -05:00
Pawel Jakub Dawidek
1619b43781 Fix problem where we check errno even for status == 0. This way when connection was properly terminated, but errno had EAGAIN value from before, we looped idenfiniately. 2012-02-03 14:44:45 +01:00
Pawel Jakub Dawidek
feb20edda7 Plug memory leak in case of an empty file and terminate string with '\0'. 2012-02-03 09:00:39 +01:00
Marc-André Moreau
9c81ff8022 libfreerdp-core: change certificate store directory name to match OpenSSL 2012-02-02 18:33:26 -05:00
Marc-André Moreau
521f956c00 libfreerdp-core: merging certificate.c with certstore.c 2012-02-02 18:20:17 -05:00
Marc-André Moreau
26d68997eb Merge branch 'master' of github.com:FreeRDP/FreeRDP 2012-02-02 17:36:16 -05:00
Marc-André Moreau
bae5de89e1 libfreerdp-utils: refactoring of certificate store 2012-02-02 17:36:07 -05:00
Pawel Jakub Dawidek
9d2ea6e937 According to specification bits from the first octet and bit 8 from the second octet (if there is more than one octet) shall not all be ones.
Before that change integer >= 0xFF80 was encoded into two bytes instead of three.
While here also add support for encoding integers into three bytes.
2012-02-02 22:46:23 +01:00
Pawel Jakub Dawidek
7c9bbcc8e1 Add missing two bytes for pad2Octets field in FASTPATH_UPDATETYPE_SYNCHRONIZE packet. 2012-02-02 17:54:36 +01:00
Marc-André Moreau
9e4d76648b libfreerdp-core: fix more memory leaks 2012-02-01 21:11:46 -05:00
Marc-André Moreau
b4e542ba46 libfreerdp-core: fix multiple memory leaks detected by valgrind 2012-02-01 18:42:20 -05:00
Norbert Federa
a3a4e9afa9 core: fixed segfault caused by double free of password_cookie blob 2012-02-01 17:58:06 +01:00