akallabeth
63cb0b5f19
[codec,rfx] use WINPR_RESTRICT keyword
2023-08-25 14:13:30 +02:00
akallabeth
3dcd702676
[primitives,yuv] use WINPR_RESTRICT
2023-08-25 14:13:30 +02:00
akallabeth
4e824b243f
[winpr] add WINPR_ATTR_FORMAT_ARG
...
this macro declares the function argument (pos,arg) to be a printf
style format string and enables compiler checks for that.
2023-08-25 12:56:36 +02:00
akallabeth
9cee9b3c08
[c standard] use WINPR_FALLTHROUGH
...
use the macro to silence intentional switch fallthrough locations
2023-08-25 12:56:36 +02:00
akallabeth
0a90e9214e
[core,aad] fix type mismatch warning
2023-08-25 12:56:36 +02:00
akallabeth
e975daec20
[codec,clear] fix missing bounds checks
2023-08-25 12:30:15 +02:00
akallabeth
576f836348
[codec,progressive] fix missing destination checks
2023-08-25 12:16:22 +02:00
akallabeth
11461a1b6d
[codec,interleaved] fix bounds checks
2023-08-25 12:01:05 +02:00
akallabeth
feb5ab52cb
[core,rdp] add log messages for unexpected data
2023-08-25 08:42:31 +02:00
akallabeth
8995241ff5
[utils,passphrase] fix type mismatch
2023-08-24 13:17:57 +02:00
akallabeth
d3ba8ebf00
[core,update] log BeginPaint/EndPaint failure
2023-08-23 14:27:51 +02:00
akallabeth
023c2dba6e
[core,autodetect] log unknown message types
2023-08-23 14:27:51 +02:00
akallabeth
769ffbd8a0
[core,fastpat] add logging for failures
2023-08-23 14:27:51 +02:00
akallabeth
74b1d5da89
[core,redirection] add logging
...
add log messages for all possible failure causes
2023-08-23 14:27:51 +02:00
akallabeth
3e744e13c3
[smartcard] clean up function table wrapper
2023-08-23 12:26:27 +02:00
Marc-André Moreau
30c31d64e8
WinSCard dynamic API loading with /winscard-module cli argument
2023-08-23 12:26:27 +02:00
akallabeth
7a71441476
[warnings] fix integer multiplications
...
Ensure the integer width for size arguments is 64bit in a
multiplication. Leading 64bit constant 1ull expands width, a trailing
one is ignored.
2023-08-22 11:55:00 +02:00
liuxiaojun
6e5f74e462
optimize idwt extrapolate decoder with neon
2023-08-22 10:54:48 +02:00
akallabeth
859b1b5f0b
[codec,nsc] ensure integer width
...
ensure multiplication result is 64bit
2023-08-22 10:26:56 +02:00
Rubycat
68b1614b66
Do not fail on certificates without subject
...
It is possible to implement an rdp client that accepts certificates by
fingerprint by using VerifyCertificateEx. In case the server uses a
certificate without subject (which, apparently, is not mandated by X509)
freerdp_certificate_data_load_cache fails and the certificate is refused
even before calling VerifyCertificateEx. This commit changes
freerdp_certificate_data_load_cache to consider that missing subject is
the same as an empty string.
Also downgrade the log message complaining about missing subject and
issuer to a warning.
2023-08-21 16:03:36 +02:00
Armin Novak
65a05fc490
[core,server] set freed pointer NULL
...
Fixes #9271 : after freeing the memory reset it to NULL to signal it was
already handled.
2023-08-21 13:35:36 +02:00
2fly2
bce9f1cbe6
[core,settings] default disable ThinClient setting
...
fixes show black window when connect transparent app in
windows server 2012r2
2023-08-21 13:03:56 +02:00
Marc-André Moreau
c691ef9c8d
allow selecting smartcard emulator at runtime rather than link time
2023-08-21 12:00:17 +02:00
Armin Novak
9f967b4942
[codec,color] fix freerdp_image_fill
...
in case width or height == 0 out of bounds write might happen.
reported by @pwn2carr
2023-08-21 11:43:50 +02:00
Armin Novak
e204fc8be5
[coded,rfx] check indices are within range
...
reported by @pwn2carr
2023-08-21 11:41:06 +02:00
Armin Novak
1ca6362498
[codec,rfx] free content of currentMessage on fail
2023-08-21 11:39:40 +02:00
Armin Novak
10a29dbc99
[codec,nsc] fix missing plane length check
...
reported by @pwn2carr
2023-08-21 11:38:13 +02:00
Marc-André Moreau
8c670b177b
fix freerdp_key_generate for some versions of OpenSSL (null key->evp)
2023-08-15 15:00:49 +02:00
akallabeth
63a2f65618
[codec,rfx] fix possible out of bound read
...
Allows malicious servers to crash FreeRDP based clients
reported by @pwn2carr
2023-08-04 15:09:59 +02:00
akallabeth
22fffdd5ea
[freerdp,api] log NULL IFCALL/IFCALLRET calls
2023-08-04 12:59:11 +02:00
akallabeth
e51a5b33fb
[core,orders] fix undefined variable, unify log strings
2023-08-03 13:54:03 +02:00
ehdgks0627
2496037f03
Standardize failure messages for order functions
2023-08-03 13:54:03 +02:00
ehdgks0627
105ce6c56b
Update error message when update_read* function failed
2023-08-03 13:54:03 +02:00
Kai Pastor
5ecc011c13
Export interface include directories
2023-08-01 11:12:46 +02:00
Armin Novak
0cd36c1526
[build] fix Wmissing-prototypes
2023-08-01 08:37:58 +02:00
Kai Pastor
21cfc456f5
find_dependency for exported cmake config
2023-08-01 08:13:30 +02:00
Joan Torres
c843e35b75
[codec] encode messages considering endianness
...
The byte order of the pixels is affected by endianness, use bitwise
operations to access those bytes so the endiannes won't affect the final
result.
2023-08-01 07:56:16 +02:00
Joan Torres
a332db7cf5
[libfreerdp] fix endianness issues
...
There were some fields sent without considering endianness, making the
clients fail when parsing those fields.
Use Data_Write_XXX functions so the endiannes won't affect the byte order
and the clients will read properly the fields.
2023-08-01 07:56:16 +02:00
Richard Markiewicz
f59c98eebe
[core,info] Fix rdp_info_read_string conversion check
2023-08-01 07:15:59 +02:00
Armin Novak
ef5c0e78ab
[build] use define WINPR_FALLTHROUGH
...
with c17 compatible compilers annotate with [[fallthrough]]
2023-07-31 23:46:53 +02:00
Armin Novak
e7c2a75e1e
[gateway,rpc] return FREERDP_ERROR_CONNECT_ACCESS_DENIED
...
unify http and rpc gateway return codes
2023-07-31 16:51:14 +02:00
Armin Novak
c656bb9d1d
[core,gateway] ensure '\0' termination of http response
2023-07-31 16:51:14 +02:00
Armin Novak
de6aaded94
[core,gateway] improve http_response_print
...
print out all response data.
2023-07-31 08:46:57 +02:00
Armin Novak
4e1781740c
[codec,test] fix wrong format string
2023-07-31 08:32:43 +02:00
Armin Novak
0afa2e88b5
[crypto,cert] imrove logged warnings for certificates
2023-07-31 08:32:43 +02:00
Armin Novak
1618677e13
[codec,progressive] fix warnings
2023-07-31 08:32:43 +02:00
Armin Novak
8be9a3a5dd
[core,gateway] unify http response logging
2023-07-31 08:32:43 +02:00
Armin Novak
03b78dd57b
[aad] print http status response message
2023-07-28 16:42:23 +02:00
Armin Novak
cd7cb514a8
[core,gateway] unify http response logging
2023-07-28 16:42:23 +02:00
Armin Novak
0bdb62e9b5
[libfreerdp] fix integere narrow warnings
2023-07-28 15:48:32 +02:00