Armin Novak
88d310ff2c
Fixed compiler warnings (casts, ...)
2018-10-18 09:09:30 +02:00
Armin Novak
f91590ecbf
Fixed bugs detected during scanbuild run
2018-10-17 13:19:33 +02:00
Armin Novak
65bfb67f7c
Fixed rpc_client_write_call resource cleanup.
2018-10-09 14:19:05 +02:00
Armin Novak
fc9ff6d2fc
Made gateway NTLM self contained.
2018-09-28 12:29:29 +02:00
Armin Novak
99eb9f7ec9
Refactored and simplified RPC signature functions.
2018-09-28 12:08:27 +02:00
Armin Novak
9516c251c7
Made TSG struct opaque
2018-09-28 12:00:45 +02:00
Armin Novak
7ab1251a67
Refactored rpc_client and resolve gateway only once.
2018-09-27 16:42:27 +02:00
Armin Novak
f5f155b057
Refactored RpcClient functions
2018-09-27 16:26:46 +02:00
Armin Novak
8a677d6cf2
Refactored rdg channel structs.
2018-09-27 16:05:14 +02:00
Armin Novak
d748adbf14
Refactored gateway ncacn HTTP to be self contained.
2018-09-27 15:19:41 +02:00
Armin Novak
a5fdf9e006
Refactored gateway HTTP to be self contained.
2018-09-27 15:04:41 +02:00
Ondrej Holy
83e966d9e2
core/gateway/rpc: Fix leak found by covscan
...
0 is valid return value from socket().
leaked_storage: Variable "auth_3_pdu" going out of scope leaks the storage it points to.
leaked_storage: Variable "response" going out of scope leaks the storage it points to.
leaked_handle: Handle variable "sockfd" going out of scope leaks the handle.
2018-08-22 14:34:02 +02:00
Armin Novak
92c62b1dbf
Fixed #4436 : double free of http response.
...
Fixed #4436 : reset of token split.
2018-02-14 14:29:08 +01:00
Armin Novak
a49a2299b1
Refactored http parser
...
* Using single buffer for all data
* Added response size limit of 64MiB
* Fixed various memory leaks
2018-01-15 16:51:33 +01:00
Armin Novak
c3f008c36c
Functions static where appropriate.
2018-01-15 13:22:01 +01:00
Armin Novak
b2c29158be
Scanbuild warning, argument checks and leak fixes.
...
* Added Stream_GetRemainingCapacity to check remaining stream size
before writes.
* Fixed shadow server memory leak.
* Fixed lots of scanbuild warnings
* Added missing argument checks in many functions
* Added missing static function declarations
2017-03-02 18:13:43 +01:00
Norbert Federa
f71b6b46e8
fix string format specifiers
...
- fixed invalid, missing or additional arguments
- removed all type casts from arguments
- added missing (void*) typecasts for %p arguments
- use inttypes defines where appropriate
2016-12-16 13:48:43 +01:00
MartinHaimberger
db2ce49a98
Merge pull request #2763 from akallabeth/nla_null_auth
...
Fixed server and client NLA state machine for NULL identity.
2015-09-15 14:53:55 +02:00
Armin Novak
188fe4ed2b
Removed rdp disconnect, using unified abortEvent instead.
2015-09-05 14:57:30 +02:00
Armin Novak
48ccf73a36
More SSPI logging.
2015-07-08 17:41:22 +02:00
David FORT
a9709a62cc
Check some return values
2015-05-29 14:24:14 +02:00
Hardening
f8120919af
Add checks for some XXX_New and XXX_Add functions
...
Based on PR #2616
2015-05-18 11:28:00 +02:00
Daniel Bungert
0a1273e508
GW RPC-HTTP - Don't drop 4 byte stub from the pipe
...
* Though not frequent, it's possible to get TsProxySetupReceivePipe
data of stublength 4 that is actual data. This happens when
header->common.call_id == rpc->PipeCallId &&
!(header->common.pfc_flags & PFC_LAST_FRAG).
This should address GW disconnects that manifest as SSL read errors.
2015-04-10 15:09:54 -06:00
Daniel Bungert
3910baf49d
GW RPC-HTTP login fix
...
* f469e069dc
introduced a logic flip
that broke RPC-HTTP Gateway. Fix that.
2015-04-10 14:50:17 -06:00
Bernhard Miklautz
74c8400789
coding style fixes
...
Add missing space after if
2015-03-30 17:15:45 +02:00
Bernhard Miklautz
f469e069dc
stream: Stream_Ensure*Capacity: change return type
...
Change the return type of Stream_Ensure*Capacity from void to BOOL to be
able to detect realloc problems easily. Otherwise the only way to detect
this was to check if the capacity after the call was >= the required
size.
In case Stream_Ensure*Capacity fails the old memory is still available
and need to freed outside.
This commit also adds checks to most calls of Stream_Ensure*Capacity to
check if the call was successful.
2015-03-30 16:33:48 +02:00
Marc-André Moreau
6202f48c12
libfreerdp-core: add configurable TSG/RGB fallback, fix edge cases
2015-03-19 11:44:47 -04:00
Denis Vincent
baab23fd14
libfreerdp-core: Make tsg out channel recycling event driven
2015-02-24 15:34:41 -05:00
Marc-André Moreau
b5f1958b69
libfreerdp-core: cleanup channel recycling
2015-02-19 15:06:57 -05:00
Denis Vincent
3e90726bac
libfreerdp-core: add TS Gateway out channel recycling support
2015-02-19 13:41:00 -05:00
Marc-André Moreau
0e57706de5
libfreerdp-core: cleanup connect error codes, fix Win32 NLA
2015-02-17 21:01:27 -05:00
Marc-André Moreau
668b2c1811
libfreerdp-core: fix tsg buffer flushing
2015-02-17 10:54:39 -05:00
Marc-André Moreau
7639addb40
libfreerdp-core: partial tsg reauth support
2015-02-16 15:35:51 -05:00
Marc-André Moreau
ffe24e8cfb
libfreerdp-core: improve TSProxyCreateTunnelRequest
2015-02-15 18:22:49 -05:00
Marc-André Moreau
4ecff39eb6
libfreerdp-core: more tsg in/out channel refactoring
2015-02-12 14:08:38 -05:00
Marc-André Moreau
c92e82b3dc
libfreerdp-core: improve TSG virtual connection and channel management
2015-02-12 12:03:15 -05:00
Marc-André Moreau
75cad064f1
libfreerdp-core: refactor tsg virtual connection, in/out channels
2015-02-11 15:26:22 -05:00
Marc-André Moreau
70fab69347
libfreerdp-core: gateway connection refactoring
2015-02-11 14:27:29 -05:00
Marc-André Moreau
5fbcdf5b3d
libfreerdp-core: make tsg rpc connection event-driven, fix race condition on connection
2015-02-04 11:18:27 -05:00
Marc-André Moreau
f8259f94c5
libfreerdp-core: add event-driven RTS connection code
2015-02-03 20:39:47 -05:00
Marc-André Moreau
13d4fa74c4
libfreerdp-core: start event-driven gateway http code
2015-02-03 17:17:17 -05:00
Marc-André Moreau
1bf0e2ee03
libfreerdp-core: add more IN/OUT gateway channel states
2015-02-03 16:33:45 -05:00
Marc-André Moreau
7b25f9130b
libfreerdp-core: improve error handling in ts gateway
2015-02-03 14:44:31 -05:00
Marc-André Moreau
5aea07d401
libfreerdp-core: add better state machine transitions to ts gateway
2015-02-02 18:50:26 -05:00
Marc-André Moreau
e4f99834d0
libfreerdp-core: make tsg threadless
2015-02-02 11:50:56 -05:00
Marc-André Moreau
bfe1c31529
libfreerdp-core: remove receive queue, make tsg connection sequence more event-driven
2015-02-02 08:19:07 -05:00
Marc-André Moreau
4239a1d4f4
libfreerdp-core: remove TS Gateway send queue
2015-02-01 20:47:43 -05:00
Marc-André Moreau
4eeabba933
libfreerdp-core: restructure RPC connection sequence
2015-02-01 18:50:21 -05:00
Marc-André Moreau
0a97a5fc4e
libfreerdp-core: fix possible lost signal in tsg_connect
2015-02-01 17:06:50 -05:00
Marc-André Moreau
4f173ae52a
libfreerdp-core: remove usage of magic 60-byte pad in TsProxyCreateTunnelWriteRequest
2015-02-01 15:58:32 -05:00