Commit Graph

764 Commits

Author SHA1 Message Date
Monty
f8fa2f9f5d fixed error on compilation WITH_DEBUG_RDP ON that was raising due to wrong variable in debug statement 2013-07-07 12:14:38 +05:30
Benoît LeBlanc
d72452b4f5 Merge branch 'master' of git://github.com/awakecoding/FreeRDP
# By Bernhard Miklautz (4) and others
# Via Marc-André Moreau
* 'master' of git://github.com/awakecoding/FreeRDP:
  libfreerdp-core: fix unused variable
  libfreerdp-codec: add bitmap encoder
  cmdline: unix/windows return detected error
  client/common: fixed command line parsing issue
  channels/serial: bring it back to life
  nla: invalidate sec handle after creation
  tls: updated certificate mismatch message
2013-07-05 16:35:08 -04:00
Norbert Federa
df7526f888 codec/rfx: Fixed bufferpool size used for RemoteFX
y_r_buffer, cb_g_buffer, cr_b_buffer and dwt_buffer are all word arrays (16bit)
but obviously the bufferpool size was calculated based on the wrong assumption
that these are 32 bit values in commit 37a59efbe3
2013-07-05 12:30:13 +02:00
Marc-André Moreau
1159d55569 libfreerdp-core: fix unused variable 2013-07-04 22:39:32 -04:00
Marc-André Moreau
5f4f3af98a Merge branch 'master' of github.com:FreeRDP/FreeRDP 2013-07-04 20:33:00 -04:00
Marc-André Moreau
0ee7ca5741 libfreerdp-codec: add bitmap encoder 2013-07-04 16:31:54 -04:00
Benoît LeBlanc
c17c2f811b FreeRDP:
- replaced char* by const char* in function prototypes
- MacFreeRDP: moved assignation of context function pointers
- freerdp: added more pointer and return value validations to prevent crashes
2013-07-04 14:42:40 -04:00
Marc-André Moreau
cbd93f1b3b freerdp: add ConnectionResult event 2013-07-03 16:18:45 -04:00
Marc-André Moreau
bc631c93a8 freerdp: separate GatewayUsageMethod from GatewayEnabled 2013-07-03 15:07:12 -04:00
Bernhard Miklautz
0773bb9303 nla: invalidate sec handle after creation
If sec pointer isn't invalidated after creation it is not possible
to check if the upper and lower pointers are valid.

This fixes a segfault in the server part if the client disconnects before
the authentication was finished.
2013-07-01 19:24:19 +02:00
Bernhard Miklautz
87e9a24b1e tls: updated certificate mismatch message
Added information to the message if the name found is an CN or an
alternative name. Also print a message if no CN was not found instead
of (null).
2013-07-01 19:21:57 +02:00
Marc-André Moreau
863b51f938 freerdp: merge with master 2013-06-28 12:50:24 -04:00
Marc-André Moreau
2d860f5385 Merge pull request #1297 from ccpp/master
Improve Certificate Checking (Add support for wildcard certificates and check against RDP gateway hostname)
2013-06-28 09:37:58 -07:00
Marc-André Moreau
6d9e131d68 Merge pull request #1298 from floppym/testfixes
libfreerdp-gdi/test: Fix segfault in gdi_convert_postfix_to_infix.
2013-06-28 09:33:49 -07:00
Bernhard Miklautz
554268674c cache and core: set pointer to NULL after free 2013-06-28 15:18:20 +02:00
Bernhard Miklautz
1c2506f937 pointer cache: fixed double free 2013-06-28 15:17:37 +02:00
C-o-r-E
6f3cc12b2c fixed deadlock in pubsub, remove scale from xf_context 2013-06-27 14:24:46 -04:00
Norbert Federa
40976a91b7 utils/profiler: fix unix build 2013-06-27 13:43:29 +02:00
Norbert Federa
b2108839b0 utils: fix broken stopwatch implementation
Stopwatch (in the way it is used) must be able to measure the wall
clock time with high resolution but used clock() which is not
appropriate for this purpose:
On POSIX systems clock() returns the processor time used by the
program. On Windows clock() does measure the wall clock time but
has only a resolution of 1ms (if at all).
This also renders the freerdp profiler unusable.

This commit changes stopwatch to use the performance counters
on Windows and gettimeofday() for the rest.

Also added a warning about invalid profiling results to the
RemoteFX codec if rfxcontext->priv->UseThreads is enabled because
stopwatch is currently not used in a thread safe way.

Also see GitHub Issue #1325
2013-06-27 13:00:54 +02:00
C-o-r-E
ebdf1ea6a2 picked some changes from awakecoding's branch 2013-06-26 21:56:37 -04:00
Marc-André Moreau
aca13e5eac freerdp: add new events for scaling and panning changes 2013-06-26 19:05:44 -04:00
Marc-André Moreau
aa4ce5ee4b freerdp: add more settings for window panning and scaling 2013-06-26 18:49:01 -04:00
Martin Fleisz
920863cd15 Merge pull request #1292 from bmiklautz/issue_1229
core: Don't sent persistent key list if deact/react
2013-06-26 05:49:16 -07:00
Martin Fleisz
0ca9bcf90d Merge pull request #1310 from byteboon/master
incorrect size calculation in gdi_Bitmap_Decompress
2013-06-26 00:05:47 -07:00
C-o-r-E
340c3a4246 merged completely (painful) from awakecoding's tree 2013-06-25 20:41:32 -04:00
Norbert Federa
9df9c7d28a libfreerdp-utils/pcap: open pcap in binary mode
Use 'b' in fopen's mode string to force binary (untranslated) mode
when reading or writing the pcap file.
This is required on WIN32 and maybe on other non POSIX conforming
systems.

This fixes the mstsc internal error disconnect followed by a crash
of the sample server when latter is used to serve a pcap file on
WIN32.
2013-06-25 17:11:36 +02:00
Marc-André Moreau
bda3a7e9cc mfreerdp: cleanup 2013-06-22 20:27:23 -04:00
Marc-André Moreau
508cef379e Merge branch 'master' of https://github.com/mrthebunny/FreeRDP 2013-06-21 23:35:35 -04:00
Marc-André Moreau
f6df97c61e freerdp: add server-side Bitmap Cache v3 and Frame Marker negotiation 2013-06-21 19:20:20 -04:00
byteboon
3065523405 fixed incorrect size calculation 2013-06-20 11:29:18 -07:00
Benoît LeBlanc
f0bee517ac fixed async transport crash on close
Setting the stop event to close the transport thread before closing
freeing resources.
2013-06-20 10:04:41 -04:00
Vic Lee
237c9e1975 libfreerdp-common: add some null pointer checks. 2013-06-20 14:13:57 +08:00
Vic Lee
6551815991 libfreerdp-codec/rfx: fix a memory leak. 2013-06-20 12:10:01 +08:00
C-o-r-E
20dc2fc968 xfreerdp-client: made MultiTouchGestures CLI option 2013-06-19 18:43:24 -04:00
Marc-André Moreau
f7af23c2e9 freerdp: added BitmapCompressionDisabled setting 2013-06-19 02:48:25 -04:00
Marc-André Moreau
fbf3208b0a libwinpr-utils: rename certain PubSub functions 2013-06-18 21:23:26 -04:00
Marc-André Moreau
90ce8be9fc freerdp-core: added Terminate event 2013-06-18 16:55:23 -04:00
Norbert Federa
86ca8f9523 codec: yCbCrToRGB did not get profiled anymore 2013-06-18 14:33:07 +02:00
Norbert Federa
12ad8cceaf Merge pull request #1291 from bmiklautz/misc-fixes
Misc fixes
2013-06-18 03:03:22 -07:00
Marc-André Moreau
508bae674b libwinpr-utils: improve PubSub with automatic strongly-typed helpers 2013-06-18 00:39:48 -04:00
Mike Gilbert
89f69aa9ba libfreerdp-gdi/test: Fix segfault in gdi_convert_postfix_to_infix. 2013-06-17 20:46:23 -04:00
Chris
44f6f16953 Fixed a possible buffer overflow issue 2013-06-17 21:49:29 +02:00
Chris
cd548da226 Using the more efficient code for comparing host names 2013-06-17 21:26:35 +02:00
Chris
13466349bc 1) Add support for Wildcard Certificates
2) For Gateway connections compare against gateway host name instead of target host
2013-06-17 21:19:01 +02:00
Marc-André Moreau
59b7c53c5f freerdp: remove temporary rdpClient* interface and replace with pubSub hooks 2013-06-15 17:39:45 -04:00
Vic Lee
96d5910a75 libfreerdp-utils: fix profiler on Windows. 2013-06-14 13:21:29 +08:00
Vic Lee
b194ddc211 libfreerdp-codec/rfx: dwSize must be initialized. 2013-06-14 12:16:04 +08:00
Marc-André Moreau
a8c268a9ff xfreerdp: improve common client API 2013-06-13 22:11:23 -04:00
Marc-André Moreau
208c9f844a freerdp: fix core API bugs 2013-06-13 21:34:46 -04:00
Bernhard Miklautz
72c6ecdd3b core: Don't sent persistent key list if deact/react
Client persistent key list should not be sent if deactivation-
reactivation sequence is in progress. See [MS-RDPBCGR] 2.2.1.17
for details.

fixes #1229
2013-06-13 20:27:10 +02:00
Bernhard Miklautz
0c2f6d59dd core: update play-rfx to work with async-updates 2013-06-13 16:38:31 +02:00
Bernhard Miklautz
ce17a827c4 Added play-rfx command line option.
PCAP dumps can now be played with /play-rfx:path_to_file again.
2013-06-13 14:51:25 +02:00
Vic Lee
9dbc240f68 libfreerdp-core/server: fix stream memory leaks. 2013-06-13 16:56:06 +08:00
Vic Lee
6422eb57d8 libfreerdp-core/surface: remove reduncdant frame ack - was done in client. 2013-06-13 13:39:49 +08:00
Marc-André Moreau
404f66820b libfreerdp-core: force flushing of updates 2013-06-09 20:37:58 -04:00
Marc-André Moreau
64d8c3d42b libfreerdp-core: add update_check_flush 2013-06-09 19:47:59 -04:00
Marc-André Moreau
49b056bec0 libfreerdp-core: added orders buffer size approximation functions 2013-06-09 17:56:57 -04:00
Marc-André Moreau
1695f530e7 libfreerdp-core: add method to flush server-side updates 2013-06-09 16:49:19 -04:00
Marc-André Moreau
e405fe2692 libfreerdp-crypto: create server directory for certificates 2013-06-06 16:45:19 -04:00
Marc-André Moreau
2bd6808432 freerdp: merge with master 2013-06-05 10:31:01 -04:00
Marc-André Moreau
6e0cbdddb1 Merge pull request #1261 from simon-engledew/master
Ber Encoding Issue
2013-06-03 16:41:29 -07:00
Hardening
fd835a747c Wire the frame acknowledge callback 2013-06-01 22:57:34 +02:00
Hardening
f37cd53769 Fixed a memory leak with alternative names 2013-06-01 22:37:49 +02:00
Benoit LeBlanc
bda6acbf3f Updated with changes from awakecoding repository. 2013-05-31 14:54:15 -04:00
Marc-André Moreau
2a08093e60 libfreerdp-crypto: fix openssl null pointer dereferencing in tls_accept 2013-05-30 19:44:58 -04:00
Simon Engledew
520f5e5e9b added the INSUFFICIENTPRIVILEGESERROR code if a use is not in the remote desktop group 2013-05-29 14:53:28 +01:00
Marc-André Moreau
9d3ec97f9e freerdp: fix monolithic build with Xcode 2013-05-24 18:38:02 -04:00
Vic Lee
06d06fdd2d core/info: server missing audio info flags. 2013-05-23 14:04:58 -07:00
Vic Lee
fb9606ea77 core/nla: fix non-standard C gramma. 2013-05-23 13:34:34 -07:00
Simon Engledew
bceec08367 Finished merging missing changes from pull request #1257 (https://github.com/FreeRDP/FreeRDP/pull/1257 - commit 0dc22d5). Correctly report the length of ts_password_creds. 2013-05-22 14:29:33 +01:00
Marc-André Moreau
ac86310993 Merge pull request #1257 from simon-engledew/master
Ber Encoding Issue
2013-05-22 05:06:52 -07:00
Martin Fleisz
00060df034 Merge pull request #1255 from bmiklautz/misc-fixes
Misc
2013-05-22 02:14:55 -07:00
Martin Fleisz
120960fd4d libfreerdp-core: Added support for server initiated shutdown to TSG 2013-05-22 10:58:11 +02:00
Simon Engledew
0dc22d5a30 Fixed a range of BER boundary encoding bugs which would occur when any NLA packet hit the 127 character mark. Removed ber#get_content_length as it was not behaving deterministically. 2013-05-21 16:06:00 +01:00
Bernhard Miklautz
a0fc0513e5 core: properly set MultifragMaxRequestSize for rfx
The RemoteFX spec states that the MultifragMaxRequestSize must be at
least as big as the one received by the server. If MultifragMaxRequestSize
is too small the server disables  RemoteFX (Codec).
2013-05-21 15:49:03 +02:00
Bernhard Miklautz
9e59fc905d client: print detected path to known_host file
Use detected path instead of hard coded for error messages
2013-05-21 15:48:27 +02:00
Marc-André Moreau
8095bec3ec channels/drdynvc: call OnChannelDisconnected 2013-05-20 15:23:54 -04:00
Marc-André Moreau
a602e4d1de libfreerdp-core: fix pcap rfx playback 2013-05-17 09:25:42 -04:00
Marc-André Moreau
92ce433090 libfreerdp-codec: optimize color conversion a bit 2013-05-16 19:56:39 -04:00
Marc-André Moreau
d99c8b8dc2 Merge branch 'master' of github.com:awakecoding/FreeRDP 2013-05-16 14:46:05 -04:00
Marc-André Moreau
cd8091a315 freerdp: fix monolithic build with Intel IPP linking 2013-05-16 14:45:49 -04:00
Marc-André Moreau
3c2687b7d6 libfreerdp-crypto: handle EAGAIN with TLS 2013-05-15 20:19:26 -04:00
Marc-André Moreau
e8c5e6c70b libfreerdp-core: send using separate streams, re-enable frame acks 2013-05-15 18:05:40 -04:00
Marc-André Moreau
202614a1a4 libfreerdp-core: reduce reuse of same pdu buffers 2013-05-15 15:54:33 -04:00
Marc-André Moreau
fc592a1750 libfreerdp-core: replace usage of Stream_GetPointer() by Stream_GetPosition() in potentially unsafe places 2013-05-15 14:42:37 -04:00
Marc-André Moreau
5c37356506 libfreerdp-core: reduce reuse of the same send buffer 2013-05-15 13:17:29 -04:00
Marc-André Moreau
367ebf32a3 freerdp: make use of stream macros to access members 2013-05-15 12:14:26 -04:00
Vic Lee
8a1b59a127 libfreerdp-core/tcp: add a null pointer check. 2013-05-14 16:24:43 +08:00
Marc-André Moreau
c9ebd98e00 libfreerdp-core: stub and implement many new server-side graphical orders 2013-05-12 17:46:13 -04:00
Marc-André Moreau
268004d0c9 libfreerdp-core: start implementing server-side alternate secondary drawing orders 2013-05-12 13:42:53 -04:00
Marc-André Moreau
dc0aa4c72d Merge branch 'master' of github.com:FreeRDP/FreeRDP 2013-05-10 16:43:19 -04:00
Marc-André Moreau
ba0b4ee524 libfreerdp-client: load rdpdr when rdpsnd is loaded 2013-05-10 16:39:16 -04:00
Marc-André Moreau
c431208829 libfreerdp-core: handle sending compressed bitmaps 2013-05-09 21:04:41 -04:00
Marc-André Moreau
645dfd7d63 libfreerdp-core: start encoding server-side bounds 2013-05-09 19:41:32 -04:00
Marc-André Moreau
841c710e1c libfreerdp-core: server-side update combining 2013-05-09 16:30:28 -04:00
Marc-André Moreau
565d50d486 libfreerdp-core: fix server-side patblt 2013-05-09 14:33:39 -04:00
Marc-André Moreau
99c821357d freerdp: add /multitouch option 2013-05-08 22:14:16 -04:00
Marc-André Moreau
30e2db0553 Merge pull request #1242 from hardening/http_fixes
Misc fixes in HTTP parsing
2013-05-08 15:44:49 -07:00
Hardening
73e6b5efc9 Misc fixes in HTTP parsing
* HTTP headers are case insensitive (see RFC2616 4.2 for details)
* Check errors when parsing status line
* treat LWS around the colon in headers
2013-05-09 00:39:09 +02:00
Marc-André Moreau
fdf3ddcf9e freerdp: purge deprecated stream utils 2013-05-08 17:48:30 -04:00