Bernhard Miklautz
28e63786cd
Integrate pull request feedback
...
Use while instead of for with additional variable where appropriate.
2015-06-25 10:33:54 +02:00
Armin Novak
80ba4643dc
Fixed cleanup of resources, only in error case now.
2015-06-24 14:59:59 +02:00
Armin Novak
e8bfa29bd2
Replaced registry keys with cmake defines.
2015-06-24 14:02:48 +02:00
Bernhard Miklautz
9f6fa7ef4c
Fix possible endless loops on cleanup.
...
Some cleanup code possibly create endless loops because an unsigned
type was used as run variable but the check was >= 0 in the for loop.
2015-06-24 12:26:13 +02:00
Armin Novak
c78b6f38ab
Fixed cleanup of MachineAddresses and MachinePorts.
2015-06-24 12:14:06 +02:00
Armin Novak
ee221315db
Fixed loop condition.
2015-06-24 10:08:04 +02:00
Armin Novak
a809b87362
Fixed memory leak.
2015-06-24 10:02:42 +02:00
Armin Novak
4c9ee07eb6
Fixed sizeof misuse.
2015-06-24 10:02:30 +02:00
Armin Novak
2ff1205dde
Fixed a resource leak.
2015-06-24 09:45:40 +02:00
Armin Novak
2e762c881c
Fixed a resource leak.
2015-06-24 09:33:20 +02:00
Armin Novak
6ed7b7b4b3
Fixed a resource leak.
2015-06-24 09:29:52 +02:00
Armin Novak
f177430acc
Fixed a resource leak.
2015-06-24 09:29:13 +02:00
Martin Fleisz
ccf5ba3194
Merge pull request #2717 from realjiangms/shadow_encoder_fps
...
server/shadow: shadow encoder related enhancement/fix.
2015-06-24 09:22:55 +02:00
Armin Novak
6698e24228
Fixed leaks, NULL dereferences and broken init.
2015-06-23 21:29:21 +02:00
Hardening
e5008d4b1b
Merge pull request #2725 from akallabeth/warning_fixes_more_more_more
...
Warning fixes more more more
2015-06-23 19:32:26 +02:00
Armin Novak
dd19e22dc0
Fixed missing colon.
2015-06-23 16:53:40 +02:00
Armin Novak
e969049aa3
Removed unused variable and incorrect comment.
2015-06-23 16:20:59 +02:00
Armin Novak
fbbc1affd0
ifdef variables used with specific build options.
2015-06-23 16:20:59 +02:00
Armin Novak
e793300ccc
Fixed typo.
2015-06-23 16:11:11 +02:00
Armin Novak
2d41cb9467
Updated from-stdin help message.
2015-06-23 16:09:39 +02:00
Bernhard Miklautz
2e87d0ee52
Fix leaks in certificate and identity handling
2015-06-23 15:40:37 +02:00
Armin Novak
5a5ed77c57
Added /from-stdin
2015-06-23 14:59:54 +02:00
Bernhard Miklautz
5f7ebd493b
Merge pull request #2721 from akallabeth/warning_fixes_some_more
...
Some warnings fixed
2015-06-23 14:30:23 +02:00
Armin Novak
063b10e8e4
Fixed memory leak.
2015-06-23 12:30:19 +02:00
Armin Novak
2f81d99327
Added missing argument checks.
2015-06-23 12:17:37 +02:00
Armin Novak
30ea9f5056
Fixed malloc with 0 size.
2015-06-23 12:12:59 +02:00
Armin Novak
d83af81295
Fixed uninitialized value.
2015-06-23 12:12:16 +02:00
Armin Novak
89eac97d0e
Fixed uninitialized value.
2015-06-23 12:09:42 +02:00
Armin Novak
24fed46cda
Fixed grabage return value.
2015-06-23 12:08:47 +02:00
Armin Novak
212db120e0
Fixed NULL pointer dereference.
2015-06-23 12:07:38 +02:00
Bernhard Miklautz
72fde88a8f
tsmf_oss: fix compiler warning
2015-06-23 11:40:04 +02:00
Norbert Federa
e8d194c743
Merge pull request #2708 from bmiklautz/dupdup
...
alloc and strdup checks
2015-06-23 11:18:19 +02:00
Bernhard Miklautz
ff8d172a12
core: use error instead of debug
...
When the function would return with an error print an error message
instead of a debug message
2015-06-23 11:15:13 +02:00
Bernhard Miklautz
09445c2b0e
nla and cmdline: integrated feedback
...
* fix possible problems with 0 size lengths
* add return value checks
2015-06-23 10:14:11 +02:00
zihao.jiang
e00655c3c2
server/shadow: shadow encoder related enhancement/fix.
...
1. Export fps related API so that subsystem implementation no longer need to know about details in encoder structure.
2. Discard frameList dictionary.
The 'value' in this dictionary is never used and not properly free'ed when client is disconnected.
The dictionary was used to calculate 'inflight' frame count. Once an ACK is received from client, an item in the dictionary is removed.
We then calculate 'inflight' frame by the count of the items in the dictionary.
However, some rdp clients (win7 mstsc) skips frame ACK if it is inactive, ACK of some frame would actually never arrive.
We actually don't need the dictionary. We only need to record the latest acknowledged frame id, and the difference between last sent frame id is the inflight frame count.
3. Minor fix in default fps calculation. encoder->frameAck is wrongly used as integer while it's actually bool flag.
2015-06-23 14:36:53 +08:00
Bernhard Miklautz
7624519453
oss: fix formating
2015-06-22 19:45:56 +02:00
Bernhard Miklautz
af81a91ea7
windows: fix compilation and warnings
2015-06-22 19:31:25 +02:00
Bernhard Miklautz
06502e6a91
misc: integrate pull request feedback
2015-06-22 19:24:30 +02:00
Bernhard Miklautz
421b74e85e
client/locale: properly check popen return value
...
popen returns NULL if an error occurs and not < 0.
2015-06-22 19:23:58 +02:00
Bernhard Miklautz
19afc6906c
client/android: reset debug level to default
...
* WLOG debug level was hard coded to DEBUG which generates a lot of
noise
* remove indecent and unneeded debug message
2015-06-22 19:23:58 +02:00
Bernhard Miklautz
fc6a3cf3c1
sspi/ntlm: integrate pull request comments
2015-06-22 19:23:58 +02:00
Bernhard Miklautz
1b8dd139a9
cmd line: add missing checks
...
* strdup
* some allocs
2015-06-22 19:23:57 +02:00
Bernhard Miklautz
5de0e02c61
cache: fix regression
...
Fix a regression in cache_new introduced in commit
b4f147e242ea396ef92082d29866e5ab7d041b4e
2015-06-22 19:21:47 +02:00
Bernhard Miklautz
1f414ec9e7
codec/planar: regression - fix conflicting types
...
Update planar.h to fix the conflicting types of
freerdp_bitmap_planar_delta_encode_planes.
2015-06-22 19:21:47 +02:00
David FORT
7c3f8f33ab
Fixes for malloc / calloc + other fixes
...
This patch contains:
* checks for malloc return value + treat callers;
* modified malloc() + ZeroMemory() to calloc();
* misc fixes of micro errors seen during the code audit:
** some invalid checks in gcc.c, also there were some possible
integer overflow. This is interesting because at the end the data are parsed
and freed directly, so it's a vulnerability in some kind of dead code (at least
useless);
** fixed usage of GetComputerNameExA with just one call, when 2 were used
in misc places. According to MSDN GetComputerNameA() is supposed to return
an error when called with NULL;
** there were a bug in the command line parsing of shadow;
** in freerdp_dynamic_channel_collection_add() the size of array was multiplied
by 4 instead of 2 on resize
2015-06-22 19:21:47 +02:00
David FORT
16d36e3083
A malloc() pass on WinPR
...
This patch treats remaining non-checked mallocs. And changes to calloc in places
where it makes sense
2015-06-22 19:10:00 +02:00
Bernhard Miklautz
749d93ae39
client/android: misc updates and fixes
...
* increase minimum required SDK to 14
* change functions from void to BOOL where required to have proper
return values
* update the JAVA classes and JNI accordingly
* add return value checks for *alloc and strdup
2015-06-22 19:10:00 +02:00
Bernhard Miklautz
77927c213e
android: fix misc compiler warnings
...
with gcc version arm-linux-androideabi-gcc (GCC) 4.8
2015-06-22 19:09:59 +02:00
Bernhard Miklautz
7d49893ddf
winpr/wtsapi: disable tests that block on windows
2015-06-22 19:09:59 +02:00
Bernhard Miklautz
ab8d83c8fc
winpr/thread: fix test compilation on windows
...
Use DWORD instead of QWORD.
2015-06-22 19:09:59 +02:00