Armin Novak
0352dc3d6c
Fixed invalid format string.
2018-08-01 12:56:18 +02:00
Pascal J. Bourguignon
17a3782d1a
FIX: moved declarations above the statements for strict C 90 compliance.
2018-06-07 13:29:44 +02:00
Pascal J. Bourguignon
15f2bafeab
Cleaned up const char** -> char** for argv, since we definitely do modify the argv!
...
(we overwrite the password and pin arguments).
This implies changes in the argument parsing tests that now must pass a mutable argv
(copied from the statically declared test argvs).
Some other const inconsistency have been dealt with too.
2018-06-06 16:43:09 +02:00
Armin Novak
5a5b5eb6dd
Fixed loadepng memory leak.
2018-05-15 14:30:35 +02:00
Armin Novak
6e958e7edb
Fix #4628 : CommandLineFindNextArgumentA must check the current argument
...
When determining if there is a next argument first check the current one
for abort criteria.
2018-05-06 10:49:05 +02:00
Kyle Evans
2fb992a962
Upstream the rest of our local FreeBSD patching
...
FreeBSD/DragonflyBSD are also UNIX platforms, as far as trio is concerned, and
we don't need to be setting the CMAKE_INSTALL_RPATH on FreeBSD.
2018-05-02 22:09:42 -05:00
Kyle Evans
f8c391876f
Pull in the LibreSSL compatibility patches from FreeBSD
2018-05-01 08:43:36 -05:00
Armin Novak
842707b106
Fixed printf format string.
2018-04-04 10:44:51 +02:00
Armin Novak
b260937ca6
Use __attribute__((destructor)) on non windows systems.
...
atexit in shared libraries is not universally supported.
2018-04-03 14:04:22 +02:00
Armin Novak
e0d112d548
Removed all calls to WLog_Init and WLog_Uninit
...
Since the calls are no longer required remove their usage.
2018-04-03 13:06:41 +02:00
Armin Novak
d249335708
Removed winpr_exit
...
As the cleanup functions are called by atexit a dedicated
cleanup call is no longer required.
2018-04-03 12:56:33 +02:00
Armin Novak
e1b53a282f
Fix #4524 : Initialize with cleanup handler
...
Use singleton initializer and register cleanup handler for logger.
2018-04-03 10:18:59 +02:00
Armin Novak
2517755d25
Fixed thread function return and parameters.
2018-03-07 14:36:55 +01:00
Martin Fleisz
900aa94796
debug: Fix broken format specifiers
2018-03-06 16:32:36 +01:00
Armin Novak
e36d87b55c
Fix #4445 : Do not call fclose on NULL file.
2018-02-16 09:05:39 +01:00
Martin Fleisz
5d1ff02d02
Merge pull request #4414 from akallabeth/pthread_cleanup_fix
...
Pthread cleanup fix
2018-02-15 11:02:37 +01:00
Martin Fleisz
19a00f2099
Merge pull request #4325 from akallabeth/fixes_com
...
Fixes serial redirection name check and SAM file parser
2018-02-15 10:39:33 +01:00
Armin Novak
2d58e96dcc
Exit main thread with winpr_exit to trigger resource cleanup.
...
When using pthread_once with destructors they are only called,
if each thread (including the main thread) is exited with pthread_exit.
Introducing winpr_exit as a wrapper for that purpose.
2018-02-12 10:33:02 +01:00
Armin Novak
855dc9abaf
Clear message queue on free.
2018-02-09 10:29:18 +01:00
Armin Novak
9804d5a4a7
SamOpen return NULL if file was not opened.
2018-01-08 13:07:11 +01:00
Armin Novak
04708b37e1
Fixed serious issues with SAM file parser
...
The parser ommitted various checks during file parsing.
Invalid syntax did crash the whole thing.
2017-12-21 14:39:43 +01:00
Armin Novak
50a0968c6a
Removed unused variables.
2017-12-21 11:29:24 +01:00
Martin Fleisz
bfe8359b5b
Merge pull request #4239 from akallabeth/test_memleak_fixes
...
Test memleak fixes
2017-12-20 12:38:38 +01:00
Martin Fleisz
5cec90c781
Merge pull request #4305 from hardening/xrandr_fix
...
Fix XRandr for old systems and MacOSX
2017-12-13 17:24:41 +01:00
Martin Fleisz
f6b8a6eaa2
Merge pull request #4276 from akallabeth/big_endian_more
...
Big endian fixes
2017-12-13 09:58:14 +01:00
Armin Novak
7305828122
Fix #4239 : Various memory leaks
...
* Fixed all tests, now can be run with -DWITH_ADDRESS_SANITIZER=ON compiled.
* Enabled address sanitizer for nightly builds.
2017-12-12 11:40:48 +01:00
Armin Novak
0a9ef97a57
Fixed uninitialized variable.
2017-12-12 10:35:02 +01:00
David Fort
41823080f9
Fix users of Stream_GetPosition() that returns size_t
2017-12-11 22:38:58 +01:00
Martin Fleisz
876a7697be
Merge pull request #4297 from akallabeth/cmd_parser_hardening
...
Fix #4296 : Hardened command line post filter.
2017-12-05 14:40:03 +01:00
Greg V
bfe3af4c72
Fix LibreSSL build
...
LibreSSL does not support FIPS mode.
2017-12-01 18:34:48 +03:00
Armin Novak
78a0c4c618
Fix #4296 : Hardened command line post filter.
2017-12-01 13:13:21 +01:00
Mike Gabriel
d4af7eaa59
fix/build: GNU/kFreeBSD is not FreeBSD
2017-11-27 17:04:52 +01:00
Armin Novak
c91900dfb3
Fixed big endian issues with bitmap read.
2017-11-24 12:03:46 +01:00
Ondrej Holy
6973b14eed
Enable FIPS mode automatically
...
FreeRDP aborts if OpenSSL operates in FIPS mode and +fipsmode is not
manually specified. Let's prevent the abortion and enable the necessary
options in that case automatically.
2017-11-23 10:09:17 +01:00
akallabeth
b156b937fe
Merge pull request #3904 from bjcollins/master
...
FIPS Mode support for xfreerdp
2017-11-17 13:31:43 +01:00
Martin Fleisz
4ff1251488
Merge pull request #4236 from akallabeth/scan_fix_remastered
...
Scanbuild warning fixes
2017-11-17 13:02:46 +01:00
Armin Novak
1bb4f121b4
Fixed formatting.
2017-11-17 12:45:28 +01:00
Brent Collins
922a0fa495
Fix checks for openssl version numbers around fips changes, they were using an incorrect version matching 1.1.0 and not 1.0.1
...
Simplify the logic to enable openssl fips mode
2017-11-17 12:43:07 +01:00
Brent Collins
5284100bb0
FIPS_mode() and FIPS_mode_set() does not exist in OpenSSL versions before 1.0.1
2017-11-17 12:43:06 +01:00
Brent Collins
d98b88642b
Add new command-line option to force xfreerdp into a fips compliant mode.
...
This option will ensure that NLA is disabled(since NTLM uses weak crypto algorithms), FIPS
encryption is enabled, and ensure fips mode is enabled for openssl.
Selectively override specific uses of MD5/RC4 with new API calls specifically tailored to override FIPS.
Add comments on why overriding the use of these algorithms under FIPS is acceptable for the locations where overrides happen.
Remove check of server proprietary certificate which was already being ignore to avoid use of MD5.
Initialize winpr openssl earlier to ensure fips mode is set before starting using any crypto algorithms.
2017-11-17 12:43:06 +01:00
David Fort
0d92c725c6
Merge pull request #4000 from akallabeth/ign_keyword_fix
...
Command line ignore empty if flag set
2017-11-16 13:26:01 +01:00
Armin Novak
f24158fe07
Fixed missing function return check.
2017-11-15 15:56:24 +01:00
Armin Novak
0aa5a83536
Fixed multiple warnings in parser
2017-11-15 15:56:21 +01:00
Armin Novak
26d079e53b
Fixed compile warnings.
2017-11-15 15:54:38 +01:00
Armin Novak
4eb5b8e349
Replaced atoi
2017-11-15 15:52:16 +01:00
Armin Novak
8c2bd951ae
Allow printing of custom arguments in help.
2017-11-15 15:25:34 +01:00
Armin Novak
bcfa434da2
Fixed resizing of PubSub
2017-09-25 13:33:04 +02:00
Bernhard Miklautz
52fbfb7b12
fix clang warnings, directly include wtypes.h ( #4097 )
...
* build: clang use -Wno-unused-command-line-argument
With clang 5.0 builds are quite noisy otherwise.
* Directly include wtypes.h
Directly include winpr/wtypes.h where _fseeki64 or _ftelli64 is used.
* fix build warnings with clang 5
clang version: 5.0.0-svn310678-1~exp1 (branches/release_50)
Warning: parentheses-equality
* fix build warnings with clang 5
clang version: 5.0.0-svn310678-1~exp1 (branches/release_50)
Warning: tautological-compare
* fix build warnings with clang 5
clang version: 5.0.0-svn310678-1~exp1 (branches/release_50)
Warning:
incompatible pointer types passing 'size_t *' (aka 'unsigned
long *') to parameter of type 'UINT32 *' (aka 'unsigned int *')
[-Wincompatible-pointer-types]
2017-08-29 09:09:38 +02:00
Armin Novak
c3d4b7d262
fseeko and ftello for 64bit file support.
2017-08-14 08:42:49 +02:00
Valery Kartel
9bf9ff9e8a
Fix build with LibreSSL
2017-07-26 17:12:14 +03:00