Pavel Pautov
ec42228b2a
Consolidate IN/OUT data connections establishment into common function and clean up related code.
2018-04-16 19:06:16 -07:00
Pavel Pautov
00256bba1d
Move NTLM auth related code into dedicated functions.
2018-04-16 19:06:16 -07:00
Pavel Pautov
269dec6377
Consolidate rdg_tls_out_connect/rdg_tls_in_connect into single function. This also fixes connections to RDG server via proxy.
2018-04-16 19:06:13 -07:00
Pavel Pautov
e639e2caf3
Removed unused "readEvent" - no one checks if it was set.
...
Removed needless rdg_check_event_handles declaration.
2018-04-16 16:05:40 -07:00
Pavel Pautov
1530bcf916
Consolidate rdg_send_in_channel_request/rdg_send_out_channel_request into single function.
2018-04-16 16:05:40 -07:00
Pavel Pautov
0fbf8f8957
Explicitly skip "seed" payload on RDG OUT connection, to avoid issues when it's split over several SSL records.
2018-04-16 16:05:40 -07:00
Pavel Pautov
44cb710496
Moved some repeated "read all" code into function.
2018-04-16 16:05:40 -07:00
Armin Novak
1feca7768e
Fixed redirection with session brokers.
...
* Only reconnect channels on redirect, if they have already been connected.
* Prefer TargetNetAddress over FQDN to connect.
2018-04-16 16:46:48 +02:00
Martin Fleisz
855af9e941
Merge pull request #4557 from akallabeth/connect_error_fix
...
Set connection error if TCP connect fails.
2018-04-12 12:10:56 +02:00
David Fort
14cce798e8
Merge pull request #4544 from oshogbo/nSize
...
Don't restrict the hostname size.
2018-04-12 11:11:57 +02:00
Martin Fleisz
d1b4b410fc
Merge pull request #4547 from andreesteve/gatewayip
...
Gateway client (RDG) must connect to same IP/server for both channels
2018-04-12 10:43:34 +02:00
Martin Fleisz
e297a4f0e2
Merge pull request #4563 from oshogbo/pointer
...
Don't assume that the pointer function are set.
2018-04-11 17:10:48 +02:00
Mariusz Zaborski
0e25335c8f
Don't assume that the pointer function are set.
2018-04-11 16:12:39 +02:00
Armin Novak
685f5a8d20
Do not clear last error if not reconnecting.
2018-04-11 10:06:11 +02:00
Armin Novak
2fc31fcb37
Set connection error if TCP connect fails.
2018-04-11 09:09:23 +02:00
Andre Esteve
d240069b5e
Gateway (RDG) use same IP for both channels
2018-04-10 20:59:33 -07:00
akallabeth
09c766cdeb
Merge pull request #4551 from oshogbo/nego_0
...
Fix setting of negotiated security protocol.
2018-04-09 19:00:48 +02:00
Mariusz Zaborski
480abdde91
Fix setting of negotiated security protocol.
...
PROTOCOL_RDP is equals 0 so if we and it with anything is still 0.
Correct way of doing it is to compare two values.
2018-04-09 17:14:37 +02:00
Bernhard Miklautz
e818dd5679
Merge pull request #4549 from oshogbo/krb
...
Fix checking of krb in encrypt public key echo.
2018-04-09 16:26:18 +02:00
Mariusz Zaborski
dc2c826edd
Fix checking of krb in encrypt public key echo.
...
In commit 0e1a073384
there was a mistake -
originally code said different then kerberos. Because of that NLA authentication
of server side didn't work for me.
2018-04-09 15:09:38 +02:00
Armin Novak
7af9ba9171
Refactored reconnect and redirect API
...
Reconnect and redirect share the same code on disconnect.
Move that to a single function and export it as it may be required
to terminate the session properly before reconnect is called.
2018-04-09 14:04:30 +02:00
Armin Novak
0a7691de58
Fixed channel (dis)connect on redirect or reconnect.
2018-04-09 11:26:12 +02:00
Armin Novak
1698a54b04
Removed unnecessarty string duplications.
2018-04-09 11:26:05 +02:00
Mariusz Zaborski
00374382d9
There is no reason to restrict nSize to 2 the hostname can be empty on
...
UNIX-like machines.
2018-04-06 21:07:51 +02:00
Armin Novak
3762e06714
Fixed RDP debug message invalid function.
2018-04-06 11:34:24 +02:00
Armin Novak
3f712cab70
Fixed formatting of changed files.
2018-04-05 13:14:16 +02:00
Armin Novak
4d45bd6661
Added CMake option WITH_DSP_EXPERIMENTAL
...
Some encoder/decoder formats are currently not really working or
have not been thouroughly tested. To allow fearless hackers
fine tuning this flag is added to easily enable/disable these formats.
2018-04-05 13:14:16 +02:00
Armin Novak
f89c1857b9
Rewrite of sound and microphone channels
...
The sound and microphone redirection channels (and in part TSMF)
did not properly decouple encoding/decoding from the backends used
to play/record sound.
Encapsulating encoding/decoding in rewritten freerdp_dsp_* functions
with variable backends, simplifying alsa/oss/pulse/... audio backends.
2018-04-05 13:14:16 +02:00
Armin Novak
b5668e35b0
Fixed format string mismatch.
2018-04-05 10:49:24 +02:00
Armin Novak
72d574b31e
Fixed type mismatches with H264 backend buffer pointers.
2018-04-05 10:48:45 +02:00
Armin Novak
26d9957608
Fix pointer type mismatch struct sockaddr_storage* and struct sockaddr*
2018-04-05 10:47:50 +02:00
MartinHaimberger
a9ecd6a6cc
Merge pull request #4535 from akallabeth/warning_fixes
...
Warning fixes
2018-04-05 10:20:43 +02:00
MartinHaimberger
0af63d4c6f
Merge pull request #4481 from akallabeth/fastpath_fix
...
Fastpath uncompressed length issue
2018-04-05 10:17:51 +02:00
Martin Fleisz
ff8b2c1b0e
core: Fix IPv6 handling on Windows
...
On Windows the sockaddr struct is smaller than sockaddr_in6.
This causes getsockname to fail because the buffer is too small.
The new code uses sockaddr_storage which should be large enough to
hold any supported protocol address structure.
See: http://pubs.opengroup.org/onlinepubs/009696699/basedefs/sys/socket.h.html
2018-04-04 17:19:18 +02:00
Armin Novak
e47d7eb968
Simplified fastpath buffer handling.
2018-04-04 13:24:43 +02:00
Armin Novak
f840150a54
Fixed missing return value checks.
2018-04-04 13:24:32 +02:00
Armin Novak
3f1ef0efc6
Removed unnecessary range check.
2018-04-04 10:45:32 +02:00
Armin Novak
2bda3a30b0
Fixed integer to float type cast.
2018-04-04 10:45:07 +02:00
Armin Novak
b0fe199060
Fixed intrinsic integer overflow.
...
Adding 128 in 8bit is not possible due to range [-128,127].
Instead subtract -128, that should eliminate the overflow.
2018-04-04 10:43:31 +02:00
Martin Fleisz
edce38613a
Merge pull request #4529 from akallabeth/wlog_cleanup_fix
...
Fix #4524 : Initialize with cleanup handler
2018-04-04 09:32:46 +02:00
Armin Novak
e0d112d548
Removed all calls to WLog_Init and WLog_Uninit
...
Since the calls are no longer required remove their usage.
2018-04-03 13:06:41 +02:00
Martin Fleisz
5c59b5f2b8
cssp: Fix handling of nonce
2018-03-29 21:42:14 +02:00
Martin Fleisz
eb1f693fc4
cssp: Separate client/server version handling ( #4502 )
2018-03-23 12:12:08 +01:00
Martin Fleisz
e9ba4b58ec
cssp: Fix warnings ( #4503 )
2018-03-21 12:57:58 +01:00
Martin Fleisz
8df96364f2
cssp: Add support for protocol version 6
2018-03-20 10:37:38 +01:00
Bernhard Miklautz
e7ae3f6bab
fix nla: don't use server version
...
FreeRDP currently only supports CredSSP protocol version 3. However the
current implementation always sent back the version received by the
server indicating that this version was supported.
With recent windows updates applied the protocol changed and this approach
doesn't work anymore (see
https://msdn.microsoft.com/en-us/library/mt752485.aspx for protocol changes).
With this fix FreeRDP always sends version 3 as supported version.
Credit goes to @mfleisz.
Fixes #4449
2018-03-14 14:04:56 +01:00
Armin Novak
44eebbb6e0
Fixed compiler warnings.
2018-03-07 14:47:06 +01:00
Armin Novak
66cc038c93
Fixed threadpool work function return and arguments.
2018-03-07 14:36:55 +01:00
Armin Novak
2517755d25
Fixed thread function return and parameters.
2018-03-07 14:36:55 +01:00
akallabeth
dd538ccd4b
Merge pull request #4470 from mfleisz/misc_fixes
...
Various fixes after running VS 2017 code analysis
2018-03-07 14:05:22 +01:00
akallabeth
ce61ec1d39
Merge pull request #4464 from perkerk/misc-windows-client
...
Misc changes for Windows client
2018-03-07 13:47:23 +01:00
Eric Brown
2e0253ae3a
Clean up mf_uninit
2018-03-07 04:30:15 -06:00
Martin Fleisz
0599a3cdbf
codec: Another realloc fix
2018-03-06 16:02:28 +01:00
Martin Fleisz
811406382d
core: Fix possible out-of-bounds read
2018-03-06 15:52:34 +01:00
Martin Fleisz
07f05c5cb3
nla: Add NULL pointer check
2018-03-06 15:39:03 +01:00
Martin Fleisz
ba5ad2e2f4
codec: Prevent invalid mem access on realloc failure
2018-03-06 15:34:55 +01:00
Martin Fleisz
21eeea2cee
codec: Fix broken reallocs
2018-03-06 15:32:04 +01:00
Armin Novak
a419677e8f
Fix invalid handle offset.
2018-03-06 13:58:40 +01:00
Eric Brown
0c24ade668
Misc fixes for Windows clients
2018-03-02 12:42:04 -06:00
Eric Brown
3c52e3dd7c
Fix H.264 codec init access violation on Windows N/KN systems
2018-03-02 12:39:28 -06:00
Armin Novak
1f7d33a2f2
Fixed read/write of surface bits command.
...
The optional field exBitmapDataHeader of TS_ BITMAP_DATA_EX was ignored.
Read and expose the data (currently unused)
2018-03-01 11:38:59 +01:00
Martin Fleisz
8e5d5fa8ea
Merge pull request #4450 from akallabeth/assist_fix
...
Assistance and RDP file parser fix
2018-02-21 16:56:55 +01:00
Martin Fleisz
3cfa837b0c
Merge pull request #4441 from akallabeth/paa
...
[cleanup] Support for gatewayaccesstoken / PAA
2018-02-19 17:28:32 +01:00
Armin Novak
212a448a38
Added assistance file name NULL check.
2018-02-19 10:00:23 +01:00
Armin Novak
1a902c249c
Fix PROFILER_* macros
...
Add the semicolon to the macro to allow clean
undefinition if the profiler is not used.
This used to break VisualC compilers.
2018-02-15 11:30:38 +01:00
Jacco Braat
2af67baea3
Modified RDG connection setup using PAA Cookie.
...
Skip NTLM auth on the IN/OUT channels. Add PAACookie to TUNNEL_CREATE.
2018-02-15 10:56:58 +01:00
Jacco Braat
b592684734
Added to rdp file parsing: gatewayaccesstoken:s:<token>
...
Added to commandline parsing: /gat:<token>
Added GatewayAccessToken to sings
2018-02-15 10:56:57 +01:00
Armin Novak
92c62b1dbf
Fixed #4436 : double free of http response.
...
Fixed #4436 : reset of token split.
2018-02-14 14:29:08 +01:00
Armin Novak
77a9e2edfc
Do not export internal variables.
2018-02-14 13:51:38 +01:00
Armin Novak
990b8c23a9
Fixed PubSub function pointer casts.
2018-02-14 11:00:52 +01:00
David Fort
6e5d86f332
http: fix compilation with valgrind memcheck helpers
2018-02-14 10:16:38 +01:00
David Fort
441975a4aa
video, geometry: fix prototypes for timer callbacks
2018-02-14 10:16:38 +01:00
David Fort
484abe0567
video: fix invalid geometry and invalid argument passing to time pubsub
2018-02-14 00:08:52 +01:00
Bernhard Miklautz
8566021a1c
Merge pull request #4425 from akallabeth/windows_nego_fix
...
Fixed windows unicode authentication.
2018-02-13 15:26:44 +01:00
Martin Fleisz
b8599b08f2
Merge pull request #4364 from akallabeth/gateway_refactor
...
Gateway refactor
2018-02-13 13:48:45 +01:00
Armin Novak
53d2150e00
Fixed windows unicode authentication.
2018-02-13 11:29:56 +01:00
Armin Novak
d9277b7fb8
Fixed copy offset issue.
2018-02-13 10:52:53 +01:00
Armin Novak
c7d701bdf8
Added software decoding fallback for RDPVOR
2018-02-13 10:52:53 +01:00
David Fort
a07efb73ec
video: an implementation of MS-RDPEVOR for X11
...
Implements the decoding of video streams using common H264 decoders. We also implement
a trivial feedback algorithm.
Sponsored by: Rangee GmbH (http://www.rangee.de )
2018-02-13 10:51:07 +01:00
Armin Novak
2cf10cc359
bitmap free now always deallocating all resources.
2018-02-13 10:18:43 +01:00
Armin Novak
50c7777bbb
Prevent malloc of size 0
2018-02-09 11:41:53 +01:00
Armin Novak
8c7fe93cc6
Added client channel queue object free function.
2018-02-09 11:04:31 +01:00
Martin Fleisz
eb2da0844c
Merge pull request #4411 from akallabeth/resolve_ipv6_fix
...
Fixed IPv4/IPv6 to string
2018-02-09 09:40:00 +01:00
Armin Novak
78de329f1f
Fixed IPv4/IPv6 to string
2018-02-08 17:26:31 +01:00
Armin Novak
c0ec81c3c7
Do not update client if output suppressed.
2018-02-08 11:59:00 +01:00
Armin Novak
253beda330
Fixed formatting.
2018-02-08 11:55:57 +01:00
Armin Novak
fde818c6f6
Fixed FFMPEG log messages.
2018-02-07 13:32:29 +01:00
Armin Novak
fac61bf48b
Use dynamic logger in MediaFoundation backend
2018-02-07 13:26:39 +01:00
Armin Novak
aff9a22367
Fixed obsolete TAG definitions and use.
2018-02-07 13:26:39 +01:00
Armin Novak
77d0c77ed9
Fix OpenH264 trace logging, set up context first
2018-02-07 13:26:39 +01:00
Armin Novak
7adc384d9a
Using dynamic logger for GFX-H264 backend.
2018-02-07 13:26:39 +01:00
Norbert Federa
1a377ba978
Merge pull request #4392 from akallabeth/yuv_asm
...
Fixed AVC444v1 luma UV averaging
2018-02-07 13:00:00 +01:00
Bernhard Miklautz
db8519fd8a
Merge pull request #4397 from SriRamanujam/vaapi
...
Use libavcodec's VA-API to accelerate H.264 decoding.
2018-02-07 12:56:31 +01:00
Armin Novak
1d99696db2
Fixed AVC444 YUV conversion matrix
2018-02-07 11:23:33 +01:00
Armin Novak
53cdd95de0
Refactored RGB to AVC444v2
2018-02-07 10:48:43 +01:00
Armin Novak
eb8e9cb410
Added SSSE3 UV average to AVC444v1
2018-02-07 10:48:43 +01:00
Armin Novak
46159c4cab
Added UV average to AVC444v1
2018-02-07 10:48:43 +01:00
Sri Ramanujam
26eee4aecf
TO BE SQUASHED: use hw_frames_ctx to set up vaapi on older versions of libavcodec
2018-02-02 15:49:59 -05:00
Sri Ramanujam
edf9c52c6b
TO BE SQUASHED: initial changes from code review
2018-02-02 14:30:31 -05:00
Armin Novak
bc33fa8b1b
Tuned FFMPEG encoder settings.
...
Using preset medium with zerolatency.
2018-02-02 13:59:08 +01:00
Armin Novak
9f57e07a23
Align YUV buffer strides and height.
2018-02-02 10:39:33 +01:00
Armin Novak
3b70d1178b
Added AVC444 chroma support to shadow server.
2018-02-02 10:39:33 +01:00
Sri Ramanujam
bedc1ac4c6
Use libavcodec's VA-API decoding.
...
Leverages libavcodec's hw decode support to provide VA-API based
hardware decoding. Depends on the local build of ffmpeg having hardware
VA-API support compiled in and the appropriate libva drivers and
libraries installed.
2018-02-02 02:31:23 -05:00
Norbert Federa
46f03d5e78
disabled expensive debug call in channel send
2018-01-31 12:44:45 +01:00
Armin Novak
c82610c304
Deactiveate optimized primitives if no implementation compiled.
2018-01-30 14:53:53 +01:00
Armin Novak
8f7bc7990f
Added SSE optimized RGB to AVC444 frame split and test.
2018-01-30 11:17:16 +01:00
Armin Novak
ce10e22b86
Added optimized C function for specific color format.
2018-01-30 11:17:15 +01:00
Armin Novak
f27ee2e3ab
Split optimized YUV implementations to separate files.
2018-01-30 11:17:15 +01:00
David Fort
5e48664695
primitives: use INIT_ONCE instead of static booleans
...
This may prevent some race conditions
2018-01-29 00:25:20 +01:00
Armin Novak
0fc19e5590
Functions static where appropriate.
2018-01-19 10:59:10 +01:00
Armin Novak
e1c00b878d
Fixes argument size type, function static where appropriate.
2018-01-19 09:15:26 +01:00
Armin Novak
29f2d2d9bb
Fixed missing packageName setup in server NLA
2018-01-17 09:09:58 +01:00
Armin Novak
0e1a073384
Simplified package name comparisons.
2018-01-17 08:18:45 +01:00
Armin Novak
dc3d536398
Changed length arguments and return to size_t
2018-01-17 08:14:06 +01:00
Armin Novak
20b4b286f0
Fixed strtoull not supported on windows.
2018-01-16 08:15:34 +01:00
Armin Novak
a49a2299b1
Refactored http parser
...
* Using single buffer for all data
* Added response size limit of 64MiB
* Fixed various memory leaks
2018-01-15 16:51:33 +01:00
Armin Novak
c3f008c36c
Functions static where appropriate.
2018-01-15 13:22:01 +01:00
Armin Novak
59e8b67287
Fixed broken #ifdef
2018-01-15 10:18:03 +01:00
akallabeth
3b719ae7d4
Merge pull request #4359 from MartinHaimberger/yuvfix
...
YUV conversation: fixed luma frame creation
2018-01-15 10:13:26 +01:00
Armin Novak
97cc55deec
Fixed bitmap capability debug.
2018-01-12 09:22:08 +01:00
Martin Haimberger
94a58bd18d
YUV conversation: fixed luma frame creation
...
in the conversation function general_RGBToAVC444YUVv2_ANY
2018-01-12 00:16:45 -08:00
MartinHaimberger
b6a1af0ba1
Merge pull request #4349 from akallabeth/primitives_update
...
Added new and optimized YUV primitives.
2018-01-10 15:33:13 +01:00
Armin Novak
23e1afb44a
Added new and optimized YUV primitives.
...
* RGBToAVC444YUVv2: Split a RGB frame in luma and/or chroma v2 YUV420 frames
* RGBX specific versions of RGBToAVC444YUV and RGBToYUV420_8u_P3AC4R
2018-01-10 14:46:18 +01:00
David Fort
ab94f6a5fd
Merge pull request #4339 from akallabeth/gdi_sw_crash_fix
...
Fixed #4336 : Initialize rectangle.
2018-01-10 09:57:54 +01:00
Armin Novak
5140ee09b3
Reduced log priority in gdi_CRgnToRect
2018-01-08 13:03:06 +01:00
David Fort
e1cc601963
Merge pull request #4323 from akallabeth/scanbuild_fixes
...
Scanbuild and other warnings fixed
2018-01-08 11:16:21 +01:00
akallabeth
900ec855de
Merge pull request #4334 from h3xx/fix-ffmpeg-support
...
Fix building against current ffmpeg
2018-01-08 09:21:53 +01:00
akallabeth
4077d55a6c
Merge pull request #4332 from hardening/xrandr_and_fixes
...
Xrandr and fixes
2018-01-08 09:20:56 +01:00
Armin Novak
bcf3babcaa
Fixed #4336 : Initialize rectangle.
2018-01-08 09:01:22 +01:00
Mike Gilbert
51cdd8df19
codec/nsc_sse2: add runtime CPU feature check
2017-12-29 14:06:49 -05:00
Mike Gilbert
082aac83a0
cmake: do not add -msse2/-msse3 globally
2017-12-29 14:06:49 -05:00
Mike Gilbert
9bfe2fcfb9
cmake: rework logic to apply -msse2, -msse3, -mssse3 to specific files
...
If we apply -mssse3 to files that don't need it, gcc may automagically
generate instructions that will not run on certain CPUs. This breaks the
runtime feature detection code (IsProcessorFeaturePresent).
Fixes: https://github.com/FreeRDP/FreeRDP/issues/4308
2017-12-29 14:06:49 -05:00
Dan Church
ed571e74a5
Provide support for older versions of libavcodec
...
My method was to find the LIBAVUTIL_VERSION_* at the commit where the
updated AV_ prefixed constants became available, add one "micro" version
to it, then if it's not at least that version, provide the unprefixed
constant. It just so happens that the same commit introduced all
the AV_* constants.
2017-12-29 11:13:03 -06:00
Dan Church
78df32c77f
Fix future ffmpeg support
...
The AV_ prefixed constants have been available since
ffmpeg@def97856de6021965db86c25a732d78689bd6bb0 (2015-07-07), or version
2.8.
The non-prefixed constants are set to be removed in the next ffmpeg
release, and were removed in
ffmpeg@302554835e39b79b977ed60c9afe81b44590dfef (2016-12-05).
2017-12-28 09:41:45 -06:00
David Fort
191b8f950f
Fix for #4330
...
Since ec027bf
dynamic resolution is broken when used with egfx. Before that commit
we were tracking a server sent resize by setting a DesktopResize callback. This callback
is called when the desktop is resized by the server. Anyway the problem was that when this
callback is called, the activation sequence is not always completed, which were leading to
some freeze with 2012r2 servers (sending packets before the sequence is finished).
So with the faulty commit, we are tracking server resizes by subscribing to the Actived
event, that is called at the end of a reactivation sequence, so we're sure to not send packets
when not fully activated.
Anyway the issue that shows on (#4330 ) is that when you use egfx, no reactivation sequence happens,
the server only sends a ResetGraphics message with the new size, and so we miss the resized event.
This fix introduces a new GraphicsReset event, makes the display channel subscribe to that event,
and react accordingly.
2017-12-23 13:50:54 +01:00
David Fort
5e2d6ea029
zgfx: add a check
2017-12-22 17:55:48 +01:00
Armin Novak
cf899eb5ba
Fix #4299 : gdi_CRgnToRect
...
The coordinates from RDP ROP commands do not (always) have
0,0 as the origin of the drawing operation.
Adjust the coordinates to our local coordinate system.
2017-12-22 13:43:37 +01:00
Armin Novak
c60c355a9d
Added ROP to primary order debug message.
2017-12-22 10:37:04 +01:00
Armin Novak
b293b17ac9
Added ROP to string functions for log messages.
2017-12-22 10:25:05 +01:00
Armin Novak
1d01582a87
Fixed dead store warnings.
2017-12-21 11:47:16 +01:00
Armin Novak
50a0968c6a
Removed unused variables.
2017-12-21 11:29:24 +01:00
Armin Novak
9c93c6cbf3
Fixed unused variable warnings.
2017-12-21 11:04:50 +01:00
Armin Novak
e4766c656e
Fixed missing initialization warnings.
2017-12-21 11:04:32 +01:00
Armin Novak
6a21bdae3d
Fixed various scanbuild warnings.
2017-12-21 09:34:35 +01:00
akallabeth
e3e65734e8
Merge pull request #4303 from krisztian-kovacs-balabit/use-redirection-password
...
Use redirection password
2017-12-20 17:01:58 +01:00
Martin Fleisz
80a49f46dc
Merge pull request #4320 from ondrejholy/coverity-fixes
...
Coverity Scan fixes
2017-12-20 14:17:20 +01:00
Martin Fleisz
ec027bf46c
Merge pull request #4318 from hardening/display_improvement
...
Dynamic resolution improvements
2017-12-20 13:43:22 +01:00
Martin Fleisz
bfe8359b5b
Merge pull request #4239 from akallabeth/test_memleak_fixes
...
Test memleak fixes
2017-12-20 12:38:38 +01:00
David Fort
2a6c9e1b87
Add an activated event and a Timer event
...
Added an event that is triggered when the activation sequence is finished.
We also define a timer event that is neat to have for regular operation.
2017-12-19 15:21:15 +01:00
Ondrej Holy
9f5d0d4c4d
crypto: Improve PER OID calculations
...
"(oid[0] << 4) & (oid[1] & 0x0F)" statement is always 0. It is not
problem currently because the only OID which is written by this
function should have 0 there. The function to read/write are pretty
limited anyway and can't work properly with all kind of OIDs. Maybe
it would be better to hardcode the OID there without decoding
and encoding. But those functions are already there so let's improve
them a bit according the spec and warn about limited set of
supported OIDs.
See:
https://msdn.microsoft.com/en-us/library/windows/desktop/bb540809
2017-12-19 14:42:06 +01:00