Commit Graph

6304 Commits

Author SHA1 Message Date
cbr-rc
7db06cc359 do not always return FALSE when gdi is NULL 2024-11-14 17:27:10 +01:00
Martin Fleisz
16789a181a [core]: Fix some issues with RAIL window state order logging
This commit fixes following issues when logging window state orders:

- Always print Window and Owner Ids as integer numbers
- Log all window styles (including extended styles)
- Log window title (very useful to identify the window in the log)
2024-11-14 10:19:43 +01:00
akallabeth
43e471938b
Merge pull request #10843 from akallabeth/cleanups3
Cleanups3
2024-11-12 17:52:55 +01:00
akallabeth
387147bb4e
[codec,xcrush] fix a regression with xcrush_generate_output 2024-11-12 17:14:52 +01:00
akallabeth
db07add07a
[deprecation] replace all usages of sprintf 2024-11-12 16:46:11 +01:00
akallabeth
08839a11de
[utils,passphrase] NULL checks 2024-11-12 16:46:04 +01:00
akallabeth
7f27e168b3
[emu,scard] flag allocator with nolint
The allocator keeps an internal list of allocated contexts. No manual
free required.
2024-11-12 16:46:01 +01:00
akallabeth
78acedb40e
[warnigns] fix Wshorten-64-to-32 2024-11-11 10:22:37 +01:00
Martin Fleisz
1520d94d33
Merge pull request #10797 from akallabeth/warn-fixes
Warn fixes
2024-11-07 13:50:51 +01:00
Martin Fleisz
c7486fc47b
Merge pull request #10801 from akallabeth/cleanups
Cleanups
2024-11-07 13:03:36 +01:00
akallabeth
7e7ea3e688
[core,settings] WINPR_ATTR_MALLOC for alloc_array 2024-11-07 11:46:50 +01:00
akallabeth
315ab17984
[core,rdstls] use less verbose logging
the rdstls_recv function is called with possibly incomplete data, do not
log length check failures
2024-11-06 20:41:01 +01:00
akallabeth
ec9b5c33bc
[core,rdstls] do silent password check
In rdstls_parse_pdu_data_type do not use logging stream functions. This
function might be called with incomplete data so avoid spamming the log.
2024-11-05 17:50:47 +01:00
Vic Lee
ce604a5a81 [core,primitive] fix rgb primitive copy without conversion. 2024-11-04 17:53:59 +08:00
akallabeth
1b177eeda9
[core,security] fix assertion
The assert for the buffer size required too many bytes in the output
buffer.
2024-10-31 13:11:57 +01:00
akallabeth
a58a390726
[gdi,shape] fix logically dead code 2024-10-31 11:42:34 +01:00
akallabeth
7f44ef8114
[cache,glyph] eliminate logically dead code 2024-10-31 11:42:31 +01:00
akallabeth
4ec28e1f82
[warnings] fix -Wimplicit-int-conversion 2024-10-31 11:42:29 +01:00
akallabeth
dcf5a8e28c
[warnings] fix -Wswitch-default 2024-10-31 11:42:24 +01:00
akallabeth
6b6ae5fa9d
[utils,helpers] revert removed define
the define was conditionally unused. guard it now so it does not show up
as unused
2024-10-31 08:51:55 +01:00
akallabeth
dc76879e0b
[warnings] fix some compiler warnings
* fix compiler warnings found in a lot of places
* add missing enum type for clipboard channel
* mark deallocator for winpr image function
2024-10-30 16:12:20 +01:00
akallabeth
8e33854c62
[tests] improve TestCommonAssistance
Compare encrypted passwords against reference values to ensure the
encryption routines work as expected
2024-10-30 13:22:59 +01:00
akallabeth
2a41730f70
[common,assistance] replace winpr_Cipher_New
* use winpr_Cipher_NewEx where possible
* use winpr_RC4_New where RC4 is used
2024-10-30 13:22:55 +01:00
akallabeth
3ae0a10142
[core] replace usage of winpr_Cipher_New
prefer winpr_CipherNewEx to be on the safe side.
2024-10-30 13:22:52 +01:00
akallabeth
2b0b52be9e
[core,rdp] adjust warning for RC4
RC4 is not supported by winpr_Cipher_New but only by explicitly calling
winpr_RC4_New. Adjust the availability test to use the correct
functions.
2024-10-30 13:22:50 +01:00
akallabeth
24ab4b297f
[utils,string] fix freerdp_extract_key_value
reset errno before strtoul to avoid aborting due to a previous errno
value from a different function call
2024-10-29 16:50:00 +01:00
akallabeth
566d4cf637
[stream] fix sign issues with stream API use 2024-10-29 15:50:07 +01:00
akallabeth
aa954d9be9
[warnings] fix various compiler warnings 2024-10-29 15:49:43 +01:00
akarl10
1ea08b776f Fix Http Negotiate for Websocket
When using negotiate in non direct NTLM mode the success response
contains an aditional token for the authentication layer.
Add HTTP_STATUS_SWITCH_PROTOCOLS to the list of valid HTTP status codes
where to extract the last auth token
2024-10-26 23:43:37 +02:00
akallabeth
d19b7fa5d0
Merge pull request #10768 from akallabeth/stream-write-assert
[winpr,stream] assert Stream_Write_(U)INT[8|16|32] ranges
2024-10-26 14:40:43 +02:00
akallabeth
88d9b1f110
[crypto,per] abort on invalid parameters 2024-10-25 11:48:16 +02:00
akallabeth
5f86284663
[core,orders] fix update_write_coord
* Add value range checks
* Add proper log message
* Add failure return
2024-10-25 11:48:14 +02:00
akallabeth
738cbd54b2
[core] fix issues with value ranges written 2024-10-25 11:48:12 +02:00
akallabeth
a3aa01214c
[resource root] unify locations
unify resource locations in case WITH_BINARY_VERSIONING is set.
2024-10-25 11:40:40 +02:00
akallabeth
392a085728
[core,settings] enforce fullscreen monitor requirements
* Monitor must start at 0/0
* Monitor must be primary
2024-10-24 11:32:10 +02:00
akallabeth
7ab30a1b18
[client,common] const correct pointer array arguments 2024-10-24 11:32:08 +02:00
akallabeth
401f81683c
[core,settings] fake monitor in window mode
RDP requires sending monitor information to the server. If we are in
windowed mode fake that information with the windows size
2024-10-24 11:32:03 +02:00
akallabeth
1675d926d2
Merge pull request #10776 from akallabeth/packaging-tests
[cmake] split tests
2024-10-24 11:26:17 +02:00
akallabeth
de055a6765
Merge pull request #10777 from akallabeth/cmake-build-type
[cmake] enforce a supported build type
2024-10-24 09:47:47 +02:00
Armin Novak
527db6783b
[cmake] split tests
* Keep BUILD_TESTING, but only run tests compatible with API (for
  packaging)
* Add BUILD_TESTING_INTERNAL for all tests including internal function
  tests that modify API to be run on our CI
2024-10-24 09:45:44 +02:00
akallabeth
d511316e86
[core,rdp] add build and supported cipher/digest checks
checking for:
 * WITH_VERBOSE_WINPR_ASSERT (runtime slowdown)
 * digests MD4, MD5, SHA1 and SHA256
 * HMAC md5 and sha1
 * Cipher RC4/ARC4_128, DES_EDE3_CBC, AES128_CBC, AES192_CBC,
   AES_256_CBC
2024-10-24 09:12:22 +02:00
Armin Novak
e48fb1eabd
[core,warnings] warn about runtime check options 2024-10-24 09:08:03 +02:00
Armin Novak
0cb84a0d8f
[crypto,cert] fix error handling for bio_read_pem 2024-10-23 11:34:06 +02:00
Armin Novak
9b32cc59b8
[core,gateway] restore non-local value 2024-10-23 10:52:21 +02:00
Armin Novak
74b596758c
[crypto,tls] add check for overflow 2024-10-23 10:50:07 +02:00
akallabeth
d8dc2956e5
[codec,color] fix overlapping check
only consider images that do not contain the same lines not overlapping.
Ignore any x offsets as this may lead to alignment problems resulting in
invalid overlapping areas.
2024-10-22 11:03:14 +02:00
akallabeth
28037f100c
[warnings] fix sign comparison issues 2024-10-22 10:11:38 +02:00
akallabeth
9e18bd94f9
[crypto,x509] replace sprintf 2024-10-22 09:50:39 +02:00
akallabeth
4f4d400f7e
[core,gateway] fix out of range check 2024-10-22 09:50:36 +02:00
akallabeth
6929ade1c4
[crypto,tls] fix cast 2024-10-22 09:50:24 +02:00