Armin Novak
2e019b2fd1
Implemented GFX locking and enforce return value checks.
...
To fix #4825 GFX functions must now aquire a lock before accessing surfaces.
This prevents simultaneous update of internal data by client and gfx threads.
Also enforce return value checks, where not already done.
2018-11-29 11:55:27 +01:00
Armin Novak
d06c3980a0
Fixed error log for avc420_decompress failures.
2018-11-26 11:33:23 +01:00
Armin Novak
09b9d4f199
Fixed CVE-2018-8787
...
Thanks to Eyal Itkin from Check Point Software Technologies.
2018-11-20 11:08:31 +01:00
Armin Novak
3e2caa88a4
Fixed invalid NULL check
2018-11-20 09:38:02 +01:00
Armin Novak
53fdea8455
Clip coordinates for lineTo and polyLine
2018-11-19 17:25:19 +01:00
Armin Novak
d75c464dbd
Fixed signed/unsigned warnings.
2018-11-19 17:25:19 +01:00
Armin Novak
75d532f87c
Fixed glyph cache bounds setting.
2018-11-19 13:58:53 +01:00
Armin Novak
e94ed7d762
Fixed gdi_BitBlt coordinate clipping.
2018-11-19 12:55:50 +01:00
Armin Novak
a078d8714e
Fixed opaque rect bounding rectangle.
2018-11-19 12:55:50 +01:00
akallabeth
b6eca4fc54
signed gdi regions to adjust negative coordinates
2018-11-19 12:52:43 +01:00
Armin Novak
88d310ff2c
Fixed compiler warnings (casts, ...)
2018-10-18 09:09:30 +02:00
Armin Novak
a432a297ca
Fixed division by 0 if invalid formats are used.
2018-10-17 11:37:51 +02:00
Armin Novak
c0d38778f1
Fixed length sanity check.
2018-10-17 10:09:37 +02:00
Armin Novak
777bfe5c40
Fixed const correctness of arguments.
2018-10-16 17:29:10 +02:00
Armin Novak
75517c06fb
Added parameter checks.
2018-10-16 17:26:57 +02:00
Armin Novak
3629a84d3f
Fixed missing input validation.
2018-10-16 17:10:03 +02:00
Armin Novak
5ea4a7d3b0
Proper order checks.
2018-10-16 15:56:17 +02:00
Armin Novak
7d8e6377df
Fixed a memory leak in cleaning up brushes.
2018-10-16 09:31:30 +02:00
Armin Novak
1d77875a69
Fix NULL function pointer BeginPaint
2018-09-24 12:47:46 +02:00
Armin Novak
13e59b5d6a
Fix #4868 : Allow empty bands data.
2018-09-19 14:18:29 +02:00
Armin Novak
6d3beabd54
Removed unused variables in tests.
2018-08-24 13:40:36 +02:00
Armin Novak
1f7d33a2f2
Fixed read/write of surface bits command.
...
The optional field exBitmapDataHeader of TS_ BITMAP_DATA_EX was ignored.
Read and expose the data (currently unused)
2018-03-01 11:38:59 +01:00
Armin Novak
1a902c249c
Fix PROFILER_* macros
...
Add the semicolon to the macro to allow clean
undefinition if the profiler is not used.
This used to break VisualC compilers.
2018-02-15 11:30:38 +01:00
Armin Novak
990b8c23a9
Fixed PubSub function pointer casts.
2018-02-14 11:00:52 +01:00
David Fort
441975a4aa
video, geometry: fix prototypes for timer callbacks
2018-02-14 10:16:38 +01:00
David Fort
484abe0567
video: fix invalid geometry and invalid argument passing to time pubsub
2018-02-14 00:08:52 +01:00
Armin Novak
d9277b7fb8
Fixed copy offset issue.
2018-02-13 10:52:53 +01:00
Armin Novak
c7d701bdf8
Added software decoding fallback for RDPVOR
2018-02-13 10:52:53 +01:00
Armin Novak
2cf10cc359
bitmap free now always deallocating all resources.
2018-02-13 10:18:43 +01:00
Armin Novak
c0ec81c3c7
Do not update client if output suppressed.
2018-02-08 11:59:00 +01:00
Armin Novak
253beda330
Fixed formatting.
2018-02-08 11:55:57 +01:00
David Fort
ab94f6a5fd
Merge pull request #4339 from akallabeth/gdi_sw_crash_fix
...
Fixed #4336 : Initialize rectangle.
2018-01-10 09:57:54 +01:00
Armin Novak
5140ee09b3
Reduced log priority in gdi_CRgnToRect
2018-01-08 13:03:06 +01:00
David Fort
e1cc601963
Merge pull request #4323 from akallabeth/scanbuild_fixes
...
Scanbuild and other warnings fixed
2018-01-08 11:16:21 +01:00
Armin Novak
bcf3babcaa
Fixed #4336 : Initialize rectangle.
2018-01-08 09:01:22 +01:00
Armin Novak
cf899eb5ba
Fix #4299 : gdi_CRgnToRect
...
The coordinates from RDP ROP commands do not (always) have
0,0 as the origin of the drawing operation.
Adjust the coordinates to our local coordinate system.
2017-12-22 13:43:37 +01:00
Armin Novak
b293b17ac9
Added ROP to string functions for log messages.
2017-12-22 10:25:05 +01:00
Armin Novak
9c93c6cbf3
Fixed unused variable warnings.
2017-12-21 11:04:50 +01:00
Martin Fleisz
bfe8359b5b
Merge pull request #4239 from akallabeth/test_memleak_fixes
...
Test memleak fixes
2017-12-20 12:38:38 +01:00
Martin Fleisz
5cec90c781
Merge pull request #4305 from hardening/xrandr_fix
...
Fix XRandr for old systems and MacOSX
2017-12-13 17:24:41 +01:00
Armin Novak
2f35c4b158
Fixed remaining color renaming issues.
2017-12-12 11:41:43 +01:00
Armin Novak
ae2a96293b
Cleanup and initialization checks.
2017-12-12 11:40:48 +01:00
Armin Novak
7305828122
Fix #4239 : Various memory leaks
...
* Fixed all tests, now can be run with -DWITH_ADDRESS_SANITIZER=ON compiled.
* Enabled address sanitizer for nightly builds.
2017-12-12 11:40:48 +01:00
David Fort
3b670703fb
Merge pull request #4277 from akallabeth/mac_server
...
Mac fixes
2017-12-12 10:40:14 +01:00
David Fort
11ee81be60
Fix XRandr for old systems and MacOSX
...
We need a recent enough version of XRandr to correctly detect monitor.
Also this patch adds some typo or style fixes.
2017-12-08 10:59:38 +01:00
daixj
d10448fde2
Fix #4291 : xfreerdp segfault when connecting freerdp-shadow-cli
2017-11-29 05:12:40 -05:00
Armin Novak
57958cb178
Fixed #3810 : Renamed color functions
2017-11-24 13:21:43 +01:00
Armin Novak
24233b299c
Fix #4111 : 15bpp color handling for brush.
2017-11-20 15:00:09 +01:00
Armin Novak
ceda3d3f4a
Fixed color for drawing rectangles.
2017-11-15 15:56:25 +01:00
David Fort
5d5376faa7
egfx: fix disconnection caused by invalid cache entries due to wrong announced cache size
...
Added some checks so that when setting a cache entry fails, we close connection (or
we fail later when trying to use that empty entry).
The small cache egfx capability has also been fixed.
2017-10-10 17:12:16 +02:00