Commit Graph

726 Commits

Author SHA1 Message Date
Marc-André Moreau
1c0e874b5b libfreerdp-core: more GCC and MCS fixes 2014-01-23 17:41:05 -05:00
Marc-André Moreau
38b125f336 libfreerdp-core: fix and update parsing of server-side GCC client data blocks 2014-01-23 16:00:02 -05:00
Mike McDonald
a563362ea2 Changed #define for SOL_TCP to be IPPROTO_TCP instead of 6 2014-01-21 11:06:29 -05:00
Mike McDonald
c0d26443ce Added #define for SOL_TCP to fix compilation error on iOS 2014-01-21 08:27:21 -05:00
Benoit LeBlanc
b142bd4e4d Added PubSub notification on mouse events (only triggered in Windows) 2014-01-17 18:17:10 -05:00
Mike McDonald
c4f6dcc24f Added auto reconnect to FreeRDP core and X11 client 2014-01-16 17:38:56 -05:00
Benoît LeBlanc
4dbe3126aa Merge branch 'master' of git://github.com/awakecoding/FreeRDP 2014-01-13 14:53:15 -05:00
Marc-André Moreau
47f3b879db libfreerdp-core: implement parsing of less frequent core rdp messages 2014-01-11 22:54:08 -05:00
Benoît LeBlanc
bb9fa6979d Fix compilation on windows (variable declaration was not in standard C) 2014-01-08 21:02:40 -05:00
Marc-André Moreau
843953048c Merge branch 'master' of github.com:FreeRDP/FreeRDP 2014-01-08 11:16:35 -05:00
Hardening
f1d6afca6a Fix CVE-2014-0791
This patch fixes CVE-2014-0791, the remaining length in the stream is checked
before doing some malloc().
2014-01-08 16:57:56 +01:00
Benoît LeBlanc
70cc837eaf Transport: trigger OnErrorInfo if a read/write error forced the thread to closed. 2013-12-20 18:26:07 -05:00
Benoît LeBlanc
ac6385448b tsg_write: return error when transport layer is closed 2013-12-20 18:24:29 -05:00
Benoît LeBlanc
3dddce811c rpc client thread: added periodic check on transport layer state, replacing an infinite wait operation. 2013-12-20 18:23:57 -05:00
Benoît LeBlanc
ad4d5c1ce7 Added timeout on blocking send, receive operations 2013-12-20 18:22:29 -05:00
Benoît LeBlanc
44e7d2f36c error handling in rpc and transport functions 2013-12-20 17:56:59 -05:00
Marc-André Moreau
05947dd0b2 libfreerdp-core: fix linux build 2013-12-18 22:02:59 -05:00
Marc-André Moreau
5e4f77b05f Merge branch 'master' of github.com:mrthebunny/FreeRDP 2013-12-18 21:52:41 -05:00
Marc-André Moreau
51ad85e0ee libfreerdp-core: send Access Denied TLS alert when server-side NLA fails 2013-12-18 19:44:18 -05:00
Benoît LeBlanc
9245d364cc Fixed handling gateway authentication error
Handle NULL pdu
2013-12-18 12:59:53 -05:00
Benoît LeBlanc
5de7a4f082 Code cleanup 2013-12-18 12:44:40 -05:00
Hardening
33f0eb0915 More security fixes for capabilities
This patch fixes a security issue which would allow an attackant to set bytes to 1 at choosen places.
It also fixes a warning when DEBUG_CAPABILITIES is set.
2013-12-18 10:54:02 +01:00
Benoît LeBlanc
3adff0ec60 - added CANCELEDBYUSER error code.
- AUTHENTICATIONERROR error code correclty set on gateway authentication (http error 401)
- Better error handling on connection errors and user cancelation
2013-12-13 10:11:36 -05:00
Hardening
8767931431 Harden capability parsing
Don't check only the number of capabilities but also the remaining size in the stream
2013-12-13 15:08:43 +01:00
Benoît LeBlanc
469303a545 Fix: PromptCredentialsOnce / GatewayUseCredentials were always set to true regardless of the value present in the rdp file. 2013-12-12 11:32:36 -05:00
Benoît LeBlanc
72f58b220d Remove deprecated ParamChanged event 2013-12-10 17:37:08 -05:00
Benoît LeBlanc
cb46bbade0 Merge branch 'master' of git://github.com/awakecoding/FreeRDP 2013-12-09 09:37:38 -05:00
Marc-André Moreau
6dfdc286ec libfreerdp-core: disconnect client when accept fails 2013-12-08 14:43:11 -05:00
Hardening
98245b8177 Fixed typo in the initialization 2013-12-08 11:22:36 +01:00
Benoît LeBlanc
8c1f836ac8 - SSL verification callback: send correct hostname and port
- Gateway Authentication callback.
- Handling “use same credentials”
2013-12-06 22:15:45 -05:00
Hardening
d7b7fcc688 Parse the Surface frame marker flag
This patch adds the parsing for the surface framemarker flag, so that
we can test it later.
2013-12-06 23:25:31 +01:00
Marc-André Moreau
85b7ad90fe libfreerdp-core: fix possible crash on unauthorized TS Gateway error 2013-12-05 17:31:33 -05:00
Hardening
1d6a07d2d5 More security in gcc.c
As strange as it looks, i have found more errors that could lead to
security issues in gcc.c.
2013-11-28 23:17:21 +01:00
Marc-André Moreau
f429b909a9 libfreerdp-core: fix transport_free in cases where transport thread was not started 2013-11-26 11:30:44 -05:00
Marc-André Moreau
128fb72ec6 mfreerdp: fix possible crash on gdi termination 2013-11-25 00:25:16 -05:00
Marc-André Moreau
83ad1730b8 Merge branch 'master' of github.com:FreeRDP/FreeRDP
Conflicts:
	libfreerdp/core/input.c
	libfreerdp/core/update.c
2013-11-23 16:39:29 -05:00
Benoît LeBlanc
d734bde420 Fix leak: free gdi object (if it wasn’t freed before) 2013-11-22 13:37:28 -05:00
Bernhard Miklautz
261651b43b core: don't use c99 style initialization
fixes #1602
2013-11-18 20:29:00 +01:00
Marc-André Moreau
b0369cf284 libfreerdp-core: add external certificate management, pass X509 PEM certificate through client callback 2013-11-18 13:54:33 -05:00
Marc-André Moreau
5fc0f72c90 Merge branch 'master' of github.com:mrthebunny/FreeRDP 2013-11-15 09:36:39 -05:00
Benoît LeBlanc
c4de5a4e4b Fixed compilation on windows (code was not standard C) 2013-11-15 08:21:36 -05:00
Marc-André Moreau
498227eb1b libfreerdp-core: map more Disconnect Provider Ultimatum PDU reason codes to error info pdu 2013-11-14 23:41:46 -05:00
Marc-André Moreau
fa12414a4b libfreerdp-core: fix parsing of MCS Disconnect Provider Ultimatum, workaround for 2008 R2 lack of error info pdu on user logoff 2013-11-14 23:05:29 -05:00
Marc-André Moreau
c4492411e4 Merge branch 'master' of github.com:FreeRDP/FreeRDP 2013-11-14 19:41:59 -05:00
Armin Novak
31ffb498f8 Fixed argument checks in <transport_disconnect> 2013-11-14 10:09:21 +01:00
Marc-André Moreau
b0b8b6aa9e Merge branch 'master' of github.com:FreeRDP/FreeRDP 2013-11-12 12:59:41 -05:00
Armin Novak
7cb0a70fd6 Added custom message resource free to update message queue. 2013-11-12 15:05:15 +01:00
Armin Novak
0ac908ba20 Added assertions to detect invalid call sequences of <transport_free>
and <transport_disconnect>.
2013-11-12 15:04:26 +01:00
Armin Novak
7ae5c8eeef Added functions to free input and update queue messages. 2013-11-12 15:03:48 +01:00
Armin Novak
b6fff6a992 Split message handling and resource cleanup for input and update messages. 2013-11-12 15:03:07 +01:00
Armin Novak
f46a560e76 Added message queue custom free handler for input queue. 2013-11-12 15:02:25 +01:00
Armin Novak
800f946053 Added assertions to spot invalid call sequence for <freerdp_check_fds> 2013-11-12 15:01:25 +01:00
Marc-André Moreau
70aed3fa85 libfreerdp-core: minor style cleanup 2013-11-08 13:57:41 -05:00
Marc-André Moreau
5536033a8a libfreerdp-core: transport refactoring 2013-11-07 17:37:58 -05:00
Marc-André Moreau
61f95fbe16 libfreerdp-core: transport code style cleanup 2013-11-07 15:14:59 -05:00
Marc-André Moreau
a04fd2c65f libfreerdp-core: added missing error info values 2013-11-06 16:25:59 -05:00
Marc-André Moreau
0e1fd4a777 freerdp: merge with master 2013-11-06 13:53:10 -05:00
Bernhard Miklautz
a0161a12ac moved version information to freerdp/version.h
fixed #1465
2013-11-06 17:29:33 +01:00
Marc-André Moreau
b8a1f7d6c0 freerdp: implement restricted admin mode pass-the-hash option 2013-11-06 10:02:58 -05:00
Marc-André Moreau
a3d0e271b5 freerdp: add restricted admin option 2013-11-06 01:51:55 -05:00
Marc-André Moreau
9921e519a9 mfreerdp: fix termination of MacFreeRDP 2013-11-05 11:49:42 -05:00
Marc-André Moreau
3d339b04d9 libfreerdp-core: modify parsing functions to return int instead of BOOL to propagate session redirection return code 2013-11-04 15:52:29 -05:00
Marc-André Moreau
1f31fd9ae1 libfreerdp-core: fix deadlock in transport thread 2013-11-04 14:16:59 -05:00
Marc-André Moreau
813a26a212 libfreerdp-core: change transport thread 2013-11-04 12:40:29 -05:00
Marc-André Moreau
5406ebd5d8 channels/drive: refactoring 2013-11-03 19:10:33 -05:00
Marc-André Moreau
13b6678977 libfreerdp-core: start untangling session redirection 2013-11-03 16:25:56 -05:00
Marc-André Moreau
3e3c0f1942 libfreerdp-core: fix potential asynchronous queuing memory problems for primary drawing orders 2013-11-03 13:29:48 -05:00
Marc-André Moreau
f34ab12778 libfreerdp-core: fix leak in freerdp_settings_clone 2013-11-03 12:34:55 -05:00
Marc-André Moreau
3caff4e460 libfreerdp-core: prevent multi-session crashes on Mac OS X 2013-11-01 20:23:56 -04:00
Marc-André Moreau
76414588b1 libfreerdp-core: fix transport failure case with session redirection 2013-11-01 14:13:09 -04:00
Marc-André Moreau
16f287015f libfreerdp-core: fix redirection parsing bug 2013-11-01 11:45:28 -04:00
Marc-André Moreau
1bada90ab7 libfreerdp-core: fix redirection parsing bug, add logging 2013-11-01 11:33:59 -04:00
Marc-André Moreau
aea4960924 libfreerdp-core: get rid of rdpString in redirection module 2013-11-01 10:59:30 -04:00
Marc-André Moreau
9829504fc1 libfreerdp-core: start async transport thread after successful transport-level connection 2013-11-01 10:24:19 -04:00
Marc-André Moreau
3cdc490bf4 libfreerdp-cache: refactor glyph cache and add logging 2013-11-01 10:01:16 -04:00
Marc-André Moreau
1fc2d780f7 libfreerdp-core: fix memory leaks reported by valgrind 2013-10-31 23:35:24 -04:00
Marc-André Moreau
3bc47a2bf8 libfreerdp-core: fix leaks and potential use after free 2013-10-31 21:12:06 -04:00
Marc-André Moreau
938d423ec9 freerdp: fix build on Windows 2013-10-30 17:56:44 -04:00
Marc-André Moreau
55565e056c freerdp: export targets 2013-10-28 23:06:39 -04:00
Marc-André Moreau
8c4b1361d1 libfreerdp-core: merge with TSG TLS update 2013-10-28 20:20:18 -04:00
Dan Bungert
66ecabb647 Final cleanups - merge ready. 2013-10-28 16:59:02 -06:00
Dan Bungert
f02daaa2d5 More cleanups - remove LWD and all references. 2013-10-28 15:46:28 -06:00
Dan Bungert
1dd2e649e3 Cleanup pass 1 2013-10-28 15:08:50 -06:00
Dan Bungert
a38c3ac794 Debug message fix for DEBUG_NLA 2013-10-28 14:54:00 -06:00
Dan Bungert
c025042d07 NLA over TLS support
Improve credssp transport layer handling, so that it works
with the correct TLS object.
2013-10-28 14:39:10 -06:00
Dan Bungert
426dc2cf84 fix blocking issues. Full TLS over TLS. 2013-10-25 17:17:36 -06:00
Dan Bungert
cefcac3414 more debug 2013-10-25 15:29:46 -06:00
Dan Bungert
f13c8a0be7 Logging 2013-10-25 10:43:21 -06:00
Dan Bungert
db890d9bf2 TLS over TLS baseline functionality.
TLS over TLS works and we get screen drawing and server interaction.
Network traffic flows in spurts with frequent apparent hangups.
2013-10-24 12:58:06 -06:00
Dan Bungert
eb25e45149 TLS over TLS maybe working. 2013-10-24 12:58:06 -06:00
Marc-André Moreau
b5dd670e73 libfreerdp-core: extend OpenSSL TSG BIO 2013-10-24 12:56:43 -06:00
Marc-André Moreau
bd6760bd13 libfreerdp-core: start implement TSG OpenSSL BIO 2013-10-24 12:56:43 -06:00
Marc-André Moreau
e9787c7a9d libfreerdp-core: minor TS Gateway fixes 2013-10-24 12:56:43 -06:00
Marc-André Moreau
d30f66b1b7 Merge branch 'master' of github.com:FreeRDP/FreeRDP 2013-10-23 14:18:40 -04:00
Marc-André Moreau
3cd5652c7d libfreerdp-core: fix asynchronous queueing of RemoteApp messages 2013-10-22 16:28:23 -04:00
Daryl Poe
076b8a84c2 commandline session reconnect 2013-10-22 09:14:29 -06:00
Marc-André Moreau
3951a6e1c3 channels/rdpgfx: implement basic negotiation 2013-10-21 23:33:25 -04:00
Marc-André Moreau
5cf0d0218b Merge branch 'master' of github.com:mrthebunny/FreeRDP 2013-10-18 22:43:18 -04:00
Marc-André Moreau
b1494322a9 libfreerdp-core: fix deep cloning of rdpSettings* 2013-10-18 22:42:50 -04:00
Benoît LeBlanc
801c1fe1d6 - Fixed crash in tls_read (unchecked null pointer)
- also check for empty string on username and password to launch authentication callback
2013-10-18 16:23:29 -04:00
Marc-André Moreau
8609a19cac Merge branch 'master' of github.com:FreeRDP/FreeRDP 2013-10-17 17:34:16 -04:00
Dan Bungert
04c2e4aef6 Gateway: Logoff crash fix
This addresses a race condition where the freerdp client
may crash on logoff.
2013-10-17 14:53:39 -06:00
Dan Bungert
486250b182 Gateway: Parsing fix for Create Tunnel Response
This fix addresses a logon issue that may occur when a logon
message is present.
2013-10-17 14:51:04 -06:00
Marc-André Moreau
970d8d2260 libfreerdp-core: add freerdp_settings_clone 2013-10-16 22:55:51 -04:00
Marc-André Moreau
3e41d5da87 libfreerdp-rail: minor cleanup 2013-10-15 22:42:07 -04:00
Marc-André Moreau
69345954b8 libfreerdp-core: fix decoupling of rdpSettings* from rdpContext* 2013-10-12 22:58:09 -04:00
Marc-André Moreau
b70ecbbf62 libfreerdp-core: decouple initialization of rdpSettings from freerdp* instance 2013-10-12 18:20:25 -04:00
Marc-André Moreau
3fe3cdf876 libfreerdp-core: extend OpenSSL TSG BIO 2013-10-11 15:27:22 -04:00
Marc-André Moreau
08eadc2ee3 libfreerdp-core: start implement TSG OpenSSL BIO 2013-10-11 06:12:50 -04:00
Marc-André Moreau
c058095251 libfreerdp-core: cleanup TS Gateway code 2013-10-11 05:07:33 -04:00
Marc-André Moreau
0dd5788266 libfreerdp-core: minor TS Gateway fixes 2013-10-11 02:10:02 -04:00
Marc-André Moreau
a24d31be31 libfreerdp-core: refactor and add new WLog debug output for graphical orders 2013-10-10 13:00:04 -04:00
Marc-André Moreau
7a7c967425 libfreerdp-rail: cleanup RAIL code 2013-10-09 22:38:26 -04:00
Marc-André Moreau
90b90ad496 libwinpr-utils: improve quality of data for reconstructed IP headers 2013-10-09 15:11:56 -04:00
Marc-André Moreau
a3f0f4c8dc libfreerdp-core: started logging packets to pcap file 2013-10-08 23:43:57 -04:00
Marc-André Moreau
a0c0d7b998 libfreerdp-core: added debug output for surface commands 2013-10-08 20:40:58 -04:00
Marc-André Moreau
74c5fa8015 Merge pull request #1501 from bmiklautz/stable-sync
Merged changes from stable-1.1
2013-09-25 08:27:36 -07:00
Bernhard Miklautz
c99d9ee72b core/glyph: copy data when adding glyph to cache
fixes #1500
2013-09-24 23:25:18 +02:00
Daryl Poe
fee219168a send RDP_NEG_REQ also in the case of a null server certificate
(cherry picked from commit afec6957c4)
2013-09-23 10:03:13 +02:00
Marc-André Moreau
d2b9d9f9d5 libfreerdp-common: add extra .rdp file options 2013-09-17 15:58:48 -04:00
Marc-André Moreau
c4a8fe0064 libfreerdp-core: simplify management and consistency of PerformanceFlags 2013-09-17 14:56:23 -04:00
Marc-André Moreau
518995a05e freerdp: merge with master 2013-09-16 17:10:27 -04:00
Marc-André Moreau
336e47e82f Merge pull request #1460 from akallabeth/thread_handle_fixes
Thread handle fixes
2013-09-16 13:40:32 -07:00
Armin Novak
4e0c7d251d Fixed double free. 2013-09-06 11:07:33 +02:00
Marc-André Moreau
a0e09e6273 libfreerdp-core: fix server-side licensing sequence 2013-09-05 18:53:55 -04:00
Armin Novak
9a3b4ac6c2 Fixed invalid event number. 2013-09-05 17:17:54 +02:00
Armin Novak
214807731f Added missing assert include. 2013-09-05 13:44:12 +02:00
Armin Novak
777d8c3535 Fixed thread handling. 2013-09-05 13:40:04 +02:00
Armin Novak
61c0c98dac Fixed missing free for subbuffers of packet. 2013-09-05 12:14:34 +02:00
Armin Novak
e2e96b8c55 Fixed clang issues. 2013-09-05 12:14:34 +02:00
Armin Novak
ef91766cf3 Fixed clang issues. 2013-09-05 12:14:34 +02:00
Armin Novak
e5c138a5b9 Fixed various memory leaks, allocation size issues and API misuse
warnings shown by clang as well as some compiler warnings.
2013-09-05 12:14:34 +02:00
Armin Novak
a3b531c036 Fixed issues found with clang-analyzer 2013-09-05 12:14:33 +02:00
Armin Novak
1e2455fa4a Fixed various memory leaks and compiler warnings. 2013-09-05 12:14:33 +02:00
Armin Novak
022439aa4c Fixed coverity issue 1047611 2013-09-05 12:14:32 +02:00
Armin Novak
e6c3dbde3d Fixed coverity issue 1047612 2013-09-05 12:14:32 +02:00
Armin Novak
66da66cdc2 Fixed coverity issue 1047614 2013-09-05 12:14:32 +02:00
Armin Novak
15466fc37d Fixed coverity issue 1047615 2013-09-05 12:14:31 +02:00
Armin Novak
a861cdbdd9 Fixed coverity issue 1047616 2013-09-05 12:14:31 +02:00
Armin Novak
91cfc90f3b Fixed coverity issue 1047617 2013-09-05 12:14:31 +02:00
Armin Novak
f9c327ce01 Fixed coverity issue 1047618 2013-09-05 12:14:31 +02:00
Marc-André Moreau
7edfe66274 freerdp: various missing link dependencies and symbol exports 2013-09-03 21:48:26 -04:00
Marc-André Moreau
307ebab08f Merge pull request #1444 from bmiklautz/master-stable-1.1-sync
fix per-device CAL licensing
2013-09-03 15:35:33 -07:00
Marc-André Moreau
bff140eeff Merge pull request #1453 from bmiklautz/issue/773
fastpath: fixed sending of multiple input messages
2013-09-03 15:34:59 -07:00
Marc-André Moreau
445c19e0a3 Merge pull request #1434 from akallabeth/memleak_fixes
Fixed various memory leaks and resource deallocation problems.
2013-09-03 15:33:26 -07:00
Vic Lee
b04544121c server: fix double demand active pdu during reactivation. 2013-09-03 19:09:53 +08:00
Bernhard Miklautz
2802efd52a fastpath: fixed sending of multiple input messages 2013-09-02 18:07:55 +02:00
Daryl Poe
f71f179c28 fix per-device CAL licensing
(cherry picked from commit d6d0d81d08)
2013-08-26 09:37:48 +02:00
Armin Novak
2f20a8c12b Fixed various memory leaks and resource deallocation problems. 2013-08-19 17:44:52 +02:00
Marc-André Moreau
87593b4f19 Merge branch 'master' of github.com:FreeRDP/FreeRDP 2013-08-15 13:16:05 -04:00