Armin Novak
2e762c881c
Fixed a resource leak.
2015-06-24 09:33:20 +02:00
Armin Novak
6ed7b7b4b3
Fixed a resource leak.
2015-06-24 09:29:52 +02:00
Armin Novak
f177430acc
Fixed a resource leak.
2015-06-24 09:29:13 +02:00
Armin Novak
6698e24228
Fixed leaks, NULL dereferences and broken init.
2015-06-23 21:29:21 +02:00
Hardening
e5008d4b1b
Merge pull request #2725 from akallabeth/warning_fixes_more_more_more
...
Warning fixes more more more
2015-06-23 19:32:26 +02:00
Armin Novak
e969049aa3
Removed unused variable and incorrect comment.
2015-06-23 16:20:59 +02:00
Armin Novak
fbbc1affd0
ifdef variables used with specific build options.
2015-06-23 16:20:59 +02:00
Bernhard Miklautz
5f7ebd493b
Merge pull request #2721 from akallabeth/warning_fixes_some_more
...
Some warnings fixed
2015-06-23 14:30:23 +02:00
Armin Novak
063b10e8e4
Fixed memory leak.
2015-06-23 12:30:19 +02:00
Armin Novak
2f81d99327
Added missing argument checks.
2015-06-23 12:17:37 +02:00
Armin Novak
30ea9f5056
Fixed malloc with 0 size.
2015-06-23 12:12:59 +02:00
Armin Novak
d83af81295
Fixed uninitialized value.
2015-06-23 12:12:16 +02:00
Armin Novak
89eac97d0e
Fixed uninitialized value.
2015-06-23 12:09:42 +02:00
Armin Novak
24fed46cda
Fixed grabage return value.
2015-06-23 12:08:47 +02:00
Armin Novak
212db120e0
Fixed NULL pointer dereference.
2015-06-23 12:07:38 +02:00
Norbert Federa
e8d194c743
Merge pull request #2708 from bmiklautz/dupdup
...
alloc and strdup checks
2015-06-23 11:18:19 +02:00
Bernhard Miklautz
09445c2b0e
nla and cmdline: integrated feedback
...
* fix possible problems with 0 size lengths
* add return value checks
2015-06-23 10:14:11 +02:00
Bernhard Miklautz
af81a91ea7
windows: fix compilation and warnings
2015-06-22 19:31:25 +02:00
Bernhard Miklautz
06502e6a91
misc: integrate pull request feedback
2015-06-22 19:24:30 +02:00
Bernhard Miklautz
421b74e85e
client/locale: properly check popen return value
...
popen returns NULL if an error occurs and not < 0.
2015-06-22 19:23:58 +02:00
Bernhard Miklautz
19afc6906c
client/android: reset debug level to default
...
* WLOG debug level was hard coded to DEBUG which generates a lot of
noise
* remove indecent and unneeded debug message
2015-06-22 19:23:58 +02:00
Bernhard Miklautz
fc6a3cf3c1
sspi/ntlm: integrate pull request comments
2015-06-22 19:23:58 +02:00
Bernhard Miklautz
1b8dd139a9
cmd line: add missing checks
...
* strdup
* some allocs
2015-06-22 19:23:57 +02:00
Bernhard Miklautz
5de0e02c61
cache: fix regression
...
Fix a regression in cache_new introduced in commit
b4f147e242ea396ef92082d29866e5ab7d041b4e
2015-06-22 19:21:47 +02:00
Bernhard Miklautz
1f414ec9e7
codec/planar: regression - fix conflicting types
...
Update planar.h to fix the conflicting types of
freerdp_bitmap_planar_delta_encode_planes.
2015-06-22 19:21:47 +02:00
David FORT
7c3f8f33ab
Fixes for malloc / calloc + other fixes
...
This patch contains:
* checks for malloc return value + treat callers;
* modified malloc() + ZeroMemory() to calloc();
* misc fixes of micro errors seen during the code audit:
** some invalid checks in gcc.c, also there were some possible
integer overflow. This is interesting because at the end the data are parsed
and freed directly, so it's a vulnerability in some kind of dead code (at least
useless);
** fixed usage of GetComputerNameExA with just one call, when 2 were used
in misc places. According to MSDN GetComputerNameA() is supposed to return
an error when called with NULL;
** there were a bug in the command line parsing of shadow;
** in freerdp_dynamic_channel_collection_add() the size of array was multiplied
by 4 instead of 2 on resize
2015-06-22 19:21:47 +02:00
David FORT
16d36e3083
A malloc() pass on WinPR
...
This patch treats remaining non-checked mallocs. And changes to calloc in places
where it makes sense
2015-06-22 19:10:00 +02:00
Bernhard Miklautz
749d93ae39
client/android: misc updates and fixes
...
* increase minimum required SDK to 14
* change functions from void to BOOL where required to have proper
return values
* update the JAVA classes and JNI accordingly
* add return value checks for *alloc and strdup
2015-06-22 19:10:00 +02:00
Bernhard Miklautz
77927c213e
android: fix misc compiler warnings
...
with gcc version arm-linux-androideabi-gcc (GCC) 4.8
2015-06-22 19:09:59 +02:00
Bernhard Miklautz
7d49893ddf
winpr/wtsapi: disable tests that block on windows
2015-06-22 19:09:59 +02:00
Bernhard Miklautz
ab8d83c8fc
winpr/thread: fix test compilation on windows
...
Use DWORD instead of QWORD.
2015-06-22 19:09:59 +02:00
Bernhard Miklautz
d9d1759abc
Fix compiler warnings:
...
gcc 4.7.2
client/X11/xf_keyboard.c: In function ‘xf_keyboard_action_script_init’:
client/X11/xf_keyboard.c:48:6: warning: unused variable ‘exitCode’
[-Wunused-variable]
gcc 4.9
client/X11/xf_client.c: In function ‘xf_client_thread’:
client/X11/xf_client.c:1537:3: warning: ‘inputThread’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
2015-06-22 19:09:59 +02:00
Bernhard Miklautz
196695e011
client/ios: fix unchecked strdups
2015-06-22 19:09:59 +02:00
Bernhard Miklautz
bf73f4e4f1
Fix unchecked strdups
...
* add missing checks
* adapt function return values where necessary
* add initial test for settings
2015-06-22 19:09:59 +02:00
Marc-André Moreau
9fab504862
Merge pull request #2686 from bmiklautz/ios/openssl
...
ios: update openssl build script
2015-06-22 10:24:26 -04:00
Marc-André Moreau
3b3ffce042
Merge pull request #2705 from akallabeth/sspi_fix_v2
...
Sspi fix v2 - Fixes static build
2015-06-22 10:19:22 -04:00
Marc-André Moreau
750e752d45
Merge pull request #2697 from realjiangms/shadow_audio
...
Shadow server: fix channel disposal and add audio support. fix message mechanism in client
2015-06-22 09:52:53 -04:00
Marc-André Moreau
82179c7d8b
Merge pull request #2698 from realjiangms/shadow_stand_alone
...
server/shadow: Decouple shadow_subsystem and subsystem implementation detail.
2015-06-22 09:39:17 -04:00
Marc-André Moreau
d10203c2a2
Merge pull request #2699 from realjiangms/shadow_connect_disconnect
...
server/shadow: add connect/disconnect anchor in subsystem callback
2015-06-22 09:38:46 -04:00
Marc-André Moreau
86bf5a91c4
Merge pull request #2701 from akallabeth/upn_syntax_support
...
Allowing UPN syntax for user argument.
2015-06-22 09:31:38 -04:00
Marc-André Moreau
20f78405c8
Merge pull request #2684 from Skool/master
...
Add bépo layout
2015-06-22 09:31:15 -04:00
Marc-André Moreau
093aaa4dc0
Merge pull request #2636 from xhaakon/master
...
Fix crashes in shadow server
2015-06-22 09:15:37 -04:00
Marc-André Moreau
9aabec73f5
Merge pull request #2713 from bmiklautz/divbyzero
...
core/metrics: prevent division by zero
2015-06-22 08:53:36 -04:00
Marc-André Moreau
1e39d7728c
Merge pull request #2702 from akallabeth/nla_null_identity_support
...
NLA Use current users credentials if none provided.
2015-06-22 08:53:05 -04:00
Bernhard Miklautz
b7e24309cf
Merge pull request #2711 from nfedera/nf-fix-rdprecvmessagechannelpdu
...
core: message channel pdu broken with rdp security
2015-06-22 12:26:31 +02:00
Bernhard Miklautz
41ef7ca17c
core/metrics: prevent division by zero
2015-06-19 17:21:16 +02:00
Norbert Federa
91a9b23b91
core: message channel pdu broken with rdp security
...
rdp_recv_message_channel_pdu always read the rdp security header
even if it was already previously read (which is the case if rdp
security is active)
This caused malfunctions and disconnects when heartbeat or bandwidth
autodetect packets were sent/received in rdp security mode.
Credit goes to @MartinHaimberger for identifying the broken code
part.
2015-06-19 14:49:17 +02:00
Armin Novak
a7943a53cd
Setting hostname as default domain now.
2015-06-18 16:07:25 +02:00
Armin Novak
c3e368bd4b
Fixed typo and invalid domain name.
2015-06-18 16:07:09 +02:00
Armin Novak
e563b2b62e
Fixed domain setting for windows client.
2015-06-18 13:01:28 +02:00