2ac2f43503
[freerdp,settings] Add UTF16 helper functions
...
This new function allows get or set settings as WCHAR
string directly. Converts the string automatically from/to utf-8
internally
2022-11-28 10:42:36 +01:00
1304af4748
[core,rdp] Refactor rdp security encryption
...
Unify rc4 encryption key handling, use common free and reset functions
2022-11-25 12:35:14 +01:00
c8956513d6
[core,rdp] Add a check for broken RDP security
...
RDP security is rarely used nowadays, but there have been reports about
situations where the encryption key is missing.
Add this check to properly terminate the connection in case of such an
unexpected event.
2022-11-25 12:35:14 +01:00
c5e425242a
[settings] Typo in GatewayHttpExtAuthSspiNtlm
2022-11-23 11:19:21 +01:00
7b95014157
[winpr,crypto] Split crypto header renamed
...
* Renamed custom winpr crypto function header
* Added compatiblity header
2022-11-23 09:39:56 +01:00
108e52192e
[rdg] fix PAA Rdg-Auth-Scheme header
2022-11-22 15:58:33 +01:00
af64cccae2
[core,settings] Ensure collection is empty
...
In freerdp_static_channel_collection_add delete the old entry before
adding a new one.
2022-11-22 15:30:31 +01:00
68bd3b63ae
[server] Fix rdp_peer_handle_state_demand_active
...
* Return type is state_run_t
* Fix use, check for success
2022-11-22 15:30:31 +01:00
febc4b3073
[gdi,gfx] Fixed possible memory leaks
...
* WINPR_ASSERT all callbacks required to be set
* Unify cache slot creation/destruction
* Destroy cache slot before setting it
2022-11-22 15:30:31 +01:00
7faf13a811
[core,capabilities] fix pointer cache size read
2022-11-22 15:30:31 +01:00
296fe9cfdb
[core,pointer] improve logging
2022-11-22 15:30:31 +01:00
94072dc64a
[core,client] Fix transitions, improve logging
2022-11-22 15:30:31 +01:00
9a000632be
Revert "Added license settings handling"
...
This reverts commit 58d7e1a2be
2022-11-22 15:30:31 +01:00
7a037d80df
[gdi,gfx] Fix width and height on reset
...
Since gdi->width and height are signed, use the MAX(0,gdi->width)
2022-11-22 15:30:31 +01:00
4284d67088
[core,state] fix state transitions, added logging
2022-11-22 15:30:31 +01:00
9dcf2c7e39
[nla] Advance input stream position
...
In nla_decode_ts_request the input stream position was not advanced.
This lead to issues when testing proper input data processing in the
client receive state callback
2022-11-22 15:30:31 +01:00
f5e4ca6f6a
[core] Log data not processed in event loop
2022-11-22 15:30:31 +01:00
ab5858376a
[core] fixed CONNECTION_STATE_MCS_CREATE_REQUEST parsing
2022-11-22 15:30:31 +01:00
13a58bd346
[crypto] Added sha3 define guards
...
sha3 is only supported with OpenSSL 1.1.1a or later
2022-11-22 12:09:39 +01:00
d03f230426
[winpr,crypto] Split headers
...
Split windows API emulation from custom functions
Including both might yield issues with OpenSSL headers
2022-11-21 13:27:08 +01:00
3a10bcd36a
[ntlm]: use rfc5929 binding hash algorithm
...
rfc5929 mandates some specific hashes for the binding algorithm
2022-11-21 13:27:08 +01:00
eb2782b3af
[core,nego] Fixed a broken format string
2022-11-21 10:51:19 +01:00
f81b3b05d2
Fixed -Wtautological-value-range-compare
2022-11-21 10:12:31 +01:00
7c5652c15a
Fixed -Wmissing-prototypes
2022-11-21 10:12:31 +01:00
a40ade5abc
Fixed -Wincompatible-pointer-types
2022-11-21 10:12:31 +01:00
0a8eaf753e
Fixed -Wunused-but-set-variable
2022-11-21 10:12:31 +01:00
b56b09840a
Fixed -Wshadow
2022-11-21 10:12:31 +01:00
31c1700c0c
Fixed -Wunused-variable
2022-11-21 10:12:31 +01:00
8de60f9472
Fixed -Wextra-semi-stmt
2022-11-21 10:12:31 +01:00
dacebc62a3
Use Stream_CheckAndLogRequiredLength, fix WLog TAG
...
* Log stream length requirement violations
* Use proper defines for WLog tags
2022-11-21 09:57:27 +01:00
eb7adaec46
core: Preserve user provided credentials when being redirected
...
This PR fixes an issue where user credentials were lost when connecting
to a farm that redirects the client.
During a redirect the connection settings were overriden by the settings
stored in `rdp->originalSettings`. However these settings miss any
credentials the user provides during the connection phase, thus causing
another authentication prompt to appear.
2022-11-18 14:01:13 +01:00
b1583d56c0
[rdg] implementation of http_extauth_sspi_ntlm
2022-11-16 20:28:53 +01:00
f42f8c32fd
[core,test] Fix TestConnect use after free
2022-11-16 16:03:21 +01:00
fd7a952e70
[core,transport] only return ioEvent if we use it
...
transport_get_event_handles only returns the ioEvent handle in its
list if transport_io_callback_set_event was called at least once.
2022-11-16 15:32:32 +01:00
d83f70bc32
[core,transport] event handle for transportIO
...
With the latest client changes the internal event loop requires a handle
to wait on. Add a new function to (re)set the newly added transport event handle.
2022-11-16 15:32:32 +01:00
4ccb38aa13
[core] Check return value of *_transition_to_state
...
The state transition might not be allowed, so abort if that fails.
2022-11-16 15:32:32 +01:00
4461144031
autodetect: prepare for multi-transport
...
Autodetect packets can be transported either in TCP TPKT packets or be contained
in multi-transport subheaders (transported on UDP). These changes do the appropriate
modifications so that in further developments we can take the transport type in account
when treating / writing these packets.
2022-11-16 11:50:46 +01:00
2c39bb41a8
fix use of return code from list_provider_keys()
...
list_provider_keys() returns a Boolean, true == success. But
smartcard_hw_enumerateCerts() expects the return value on success to
be ERROR_SUCCESS == 0, and so inverts success/failure.
2022-11-16 11:50:15 +01:00
4ddef3e141
[capabilities] properly set RemoteFxOnly
...
The check was inverted, setting the flag properly now
2022-11-16 11:02:10 +01:00
bc31bae2b5
[core] Unify RDP state machine
...
Up to this commit the client and server state machine handling used
different return values for state machine changes.
This is fixed with this commit:
* Use common enum return values
* Use common helper functions
2022-11-15 09:57:46 +01:00
8760cecbc7
[rdg] Unified rpcFallback resource cleanup
...
Since the cleanup routines are always the same unify these in
rdg_connect.
2022-11-14 09:47:13 +01:00
355c7ec72a
rdg: Fallback to rpc if http status is not sent
...
It seems MS RDG 2016+ does not send a http status code if
something with the request or configuration is not ok. It is worth
retrying with rpc in that case
2022-11-14 09:47:13 +01:00
5b90d0bc1d
Added missing length checks in zgfx_decompress_segment
2022-11-14 09:28:22 +01:00
0629bb9c20
codec: Fix broken logging in progressive codec
2022-11-14 09:27:41 +01:00
4ef72bbe14
Cleanup of client RDP state machine
...
* Use enum for most common return types
* Add success/failed check functions
* Add a function creating a string from the return value
2022-11-11 11:51:27 +01:00
872f52c014
[core] properly pass redirection return code
...
If a redirection packet is receivet pass the appropriate return
code through the call stack to let the client take action
2022-11-11 11:51:27 +01:00
98cf410144
Fixed missing state machine rerun trigger
...
When changing the peer state return 1 to indicate a rerun is
required.
2022-11-11 11:51:27 +01:00
12f0e996c0
[server] Fix state transition return value
...
When transitioning from CONNECTION_STATE_FINALIZATION_FONT_LIST to
CONNECTION_STATE_ACTIVE we must return a value > 0 so that the
state machine can properly initialize the new state.
2022-11-11 11:51:27 +01:00
367ecf3c0b
Properly handle demand active state
...
The demand active state might be called when receiving data from the
client during initial connection phase or might be triggered server
side after sending a deactivate all pdu
2022-11-11 11:51:27 +01:00
8210ee77db
Fixed return of rdp_client_transition_to_state
...
Use BOOL to just indicate success/failure and actually check return
of functions called.
2022-11-11 11:51:27 +01:00
akallabeth