Norbert Federa
92b0076c53
winpr: fix PathCchStripPrefix
...
And again S_FALSE was incorrectly used to indicate an error.
Fix this and be more compatible to the Windows 8 implementation of
this function:
- return E_INVALIDARG instead of S_FALSE if pszPath is NULL
- return E_INVALIDARG instead of S_FALSE if cchPath < 4
- return E_INVALIDARG if cchPath > PATHCCH_MAX_CCH
- allow stripping of "\\?\c:" and don't require "\\?\c:\"
- verify that the character at the drive letter position is
actually an alphabetic character
- since the passed pszPath must not necessarily be null terminated
and we always have enough space after the memmove we can always
ensure the null termination of the stripped result
Also extended/fixed the TestPathCchStripPrefixctest
2015-06-03 16:06:02 +02:00
Norbert Federa
17ceafbb0c
winpr: fix PathCchAddExtension
...
The HRESULT S_FALSE does not indicate an error:
- return E_INVALIDARG instead of S_FALSE
- return HRESULT_FROM_WIN32(ERROR_INSUFFICIENT_BUFFER) instead of S_FALSE
Also extended/fixed the corresponding ctest
2015-06-03 16:06:02 +02:00
Norbert Federa
03b0472c29
winpr: fix PathCchAddBackslashEx
...
The HRESULT S_FALSE does not indicate an error:
- return E_INVALIDARG instead of S_FALSE
- return HRESULT_FROM_WIN32(ERROR_INSUFFICIENT_BUFFER) instead of S_FALSE
Also extended/fixed the corresponding ctest
2015-06-03 16:06:02 +02:00
Norbert Federa
21e6012226
winpr: fix PathCchAddBackslash
...
The HRESULT S_FALSE does not indicate an error:
- return E_INVALIDARG instead of S_FALSE
- return HRESULT_FROM_WIN32(ERROR_INSUFFICIENT_BUFFER) instead of S_FALSE
Also extended/fixed the corresponding ctest
2015-06-03 16:06:01 +02:00
Norbert Federa
87683ec87b
client/windows: invalid usage of S_FALSE HRESULT
...
S_FALSE is a success code and not an error (note the S_)
2015-06-03 16:06:01 +02:00
Bernhard Miklautz
6b92fe3805
Merge pull request #2673 from nfedera/fix-hresult
...
winpr: fixed HRESULT & SCODE types, added a ctest
2015-06-03 10:05:09 +02:00
Norbert Federa
77769f10b6
winpr: fixed HRESULT & SCODE types, added a ctest
...
- HRESULT was unsigned which means that until now all usages of the
SUCCEDED(hr) and FAILED(hr) macros never detected any errors
- Also fixed the (unused) SCODE typedef
- Added new ctest TestTypes
2015-06-02 19:52:52 +02:00
Hardening
c1b2fbe6d0
Merge pull request #2672 from akallabeth/img_test_fix
...
Fixed for TestImage unit test
2015-06-02 19:22:29 +02:00
Armin Novak
c6c43d5f06
Writing failure to stderr.
2015-06-02 17:54:27 +02:00
Armin Novak
1c3b38f58b
Fixed image test.
2015-06-02 17:53:16 +02:00
Armin Novak
2a3cd74c02
Fixed image test.
2015-06-02 15:17:54 +02:00
Marc-André Moreau
608174cba6
Merge pull request #2649 from xhaakon/cross-monitor-subrect
...
shadow_screen: allow sub-rectangle to span multiple monitors
2015-06-02 09:15:29 -04:00
Armin Novak
6b4cc2ff25
Fixed size of string buffer.
2015-06-02 12:45:35 +02:00
MartinHaimberger
02bf7ec0bf
Merge pull request #2669 from llyzs/h264
...
h264: add encoder constant QP rate control.
2015-06-02 12:38:21 +02:00
Armin Novak
ea1dae219d
Added config compatibility for default builds.
2015-06-02 12:00:52 +02:00
Armin Novak
e6283db1b9
Added missing NULL check.
2015-06-02 10:10:47 +02:00
Armin Novak
d3a88014da
Fixed directory creation checks.
2015-06-02 10:01:10 +02:00
Armin Novak
dd1a03191d
Fixed settings path creation.
2015-06-02 09:51:05 +02:00
Armin Novak
70df8d8ba9
Fixed static function arguments.
2015-06-02 09:50:59 +02:00
Armin Novak
8f68b9c261
Using vendor/product scheme for settings now.
2015-06-02 09:50:53 +02:00
Armin Novak
d1223d3799
Fixed windows known path locations.
2015-06-02 09:50:48 +02:00
Vic Lee
1d31f25992
h264: add encoder constant QP rate control.
2015-06-02 15:32:45 +08:00
ivan-83
e22a4461c7
rdpsnd oss remove unneded mem operations
2015-05-30 03:02:25 +03:00
ivan-83
d925f2f9fe
rdpsnd: latency process
2015-05-30 02:22:18 +03:00
Hardening
29de9b6d4e
Merge pull request #2658 from hardening/fix_2657
...
Fix for #2657
2015-05-29 17:58:30 +02:00
Hardening
c75ba04d72
Merge pull request #2647 from hardening/fix_message_queue
...
Fixed MessageQueue and callers
2015-05-29 14:38:58 +02:00
David FORT
84ae1d1cfb
Take in account nfedera's remarks
2015-05-29 14:24:14 +02:00
David FORT
a9709a62cc
Check some return values
2015-05-29 14:24:14 +02:00
David FORT
909a965fe9
Added misc checks in rdg.c
2015-05-29 14:24:14 +02:00
David FORT
d26ce6971c
Fixed nfedera's remarks
2015-05-29 14:24:14 +02:00
David FORT
12f873f1f9
Fixed MessageQueue and callers
2015-05-29 14:24:14 +02:00
Hardening
4586450e27
Merge pull request #2661 from MartinHaimberger/mh-stream-fix
...
stream: check stream_new in winpr and libfreerdp
2015-05-29 14:12:59 +02:00
Martin Haimberger
951a2d2210
stream: check stream_new in winpr and libfreerdp
...
also fixed a few things
2015-05-29 04:46:50 -07:00
Hardening
1b366816a2
Merge pull request #2608 from oshogbo/master
...
Add check to protect memcpy(3) from using NULL pointer.
2015-05-29 10:49:42 +02:00
Hardening
dbb67cdf7f
Merge pull request #2642 from hardening/shadow_fix
...
Specify to skip compression with remoteFx frames
2015-05-28 22:58:15 +02:00
Hardening
2ec3734607
Merge pull request #2659 from oshogbo/unused
...
Remove unused variable.
2015-05-28 22:57:17 +02:00
Hardening
ca274b6b49
Merge pull request #2660 from nfedera/fix-tsmf-channel
...
tsmf: fix invalid check and a potential segfault
2015-05-28 11:09:07 +02:00
Hardening
f7f58f64c8
Merge pull request #2646 from eledoux/thread_list
...
fixed a synchronization issue on thread_list
2015-05-28 10:51:53 +02:00
Norbert Federa
8e70012d65
tsmf: fix invalid check and a potential segfault
...
This resuscitates tsmf which was accidently broken in commit f8120919
2015-05-28 10:49:38 +02:00
ivan-83
a520d8b3fa
Merge branch 'master' of github.com:ivan-83/FreeRDP
2015-05-28 03:26:24 +03:00
ivan-83
9313197023
Code style changed.
2015-05-28 00:00:25 +03:00
ivan-83
99e63b51f8
revert wlog debug formating
2015-05-27 23:53:40 +03:00
ivan-83
1a7ef0942b
* tsmf: OSS code cleanup
...
+ urbdrc: add devd support (not tested)
* fix FindUUID detection ubder BSD
* wlog: fix prev commit: build error on Windows
* cmdline: add /usb syntax help
2015-05-27 23:53:40 +03:00
ivan-83
307d22ca11
* debug and error messages now print function name and line number
...
* add debug messages to trace fake network dissconects
2015-05-27 23:48:07 +03:00
ivan-83
20a1d2b097
* tsmf: OSS now work, but only with ffmpeg, and sound is bad (like with alsa), ffmpeg code possible have bug with wrong resample
2015-05-27 23:23:57 +03:00
ivan-83
3912172fc8
+ tsmf: OSS initial suppot (not work yet)
...
* tsmf: fix video playback on FreeBSD (proper shared object name)
* tsmf: renamed args: audio->sys, audio-dev->dev
* audin: OSS fix, now it work
* cmdline: add syntax help for /audin, /rdpsnd, /tsmf
* add debug messages
2015-05-27 23:22:36 +03:00
ivan-83
5ba4d6cd6c
Code style changed.
2015-05-27 22:59:57 +03:00
ivan-83
0fda0eb0de
Code style changed.
2015-05-27 22:59:57 +03:00
ivan-83
92662a1854
revert wlog debug formating
2015-05-27 22:58:41 +03:00
ivan-83
83a40a32a7
* tsmf: OSS code cleanup
...
+ urbdrc: add devd support (not tested)
* fix FindUUID detection ubder BSD
* wlog: fix prev commit: build error on Windows
* cmdline: add /usb syntax help
2015-05-27 22:58:41 +03:00