Mati Shabtay
2048708235
client/rdpgfx_main.h: Formatting
2019-05-05 16:27:11 +03:00
Armin Novak
841cb70f91
Fixed const correctness of gfx function pointer
...
Signed-off-by: Mati Shabtay <matishabtay@gmail.com>
2019-05-05 16:17:15 +03:00
Mati Shabtay
eee234c239
rdpgfx/client: Add callbacks for manual caps sending and frame acking
2019-05-05 15:56:35 +03:00
Mati Shabtay
e9dfe13a70
client/rdgpfx_main.c: Fix rdpgfx_recv_caps_confirm_pdu caps length read
2019-05-05 13:39:04 +03:00
kubistika
e9faaedc85
rdpgfx: Fix GFX v10.6 PDUs parsing and naming according to the spec
2019-05-05 12:34:57 +03:00
Bernhard Miklautz
f867c90e4c
Merge pull request #5308 from akallabeth/fix_win32_overlinking
...
Fixed windows overlinking.
2019-05-03 12:01:51 +02:00
r-barnett
40ef08ddc5
Fix smartcard segfault when no devices are present ( #5364 )
...
* Don't assume smartcard reader list is not empty.
* Check status of retrieval of smartcard device list before trying to filter it
* style fixes
2019-05-02 06:11:57 +02:00
amratsingh
84e50582b7
android_freerdp.c: fixed wrong registered signature ( #5371 )
2019-05-02 05:59:52 +02:00
Martin Fleisz
25fc56a625
Merge pull request #5260 from akallabeth/rail_spec_update
...
Rail spec update
2019-04-29 11:27:26 +02:00
Martin Fleisz
6eb108058e
Merge pull request #5306 from akallabeth/gfx_server_caps_input_checks
...
Fixed input stream length checks in rdpgfx_recv_caps_advertise_pdu
2019-04-29 11:27:06 +02:00
Armin Novak
5e42c8943d
Fixed typo in RAIL_ZORDER_SYNC
2019-04-26 13:14:30 +02:00
Armin Novak
8af9c138e3
Fixed input stream length checks in rdpgfx_recv_caps_advertise_pdu
2019-04-26 13:11:46 +02:00
Pascal J. Bourguignon
431c37f3a9
5360 segfault using smartcard without any readers ( #5361 )
...
* Fix: corrected test for astyle.
* Fix: added test for NULL readers returned by ConvertFromUnicode.
2019-04-26 09:10:41 +02:00
Mati Shabtay
e1ef302a8d
rail_orders.c: Fix wrong callback call on server handshake ex recv ( #5345 )
2019-04-25 10:55:24 +02:00
sgtatham
236c7918cb
xf_cliprdr: detect null terminators more reliably. ( #5353 )
...
Clipboard formats containing plain text are specified to be terminated
by a \0 character in MS's documentation on standard clipboard formats:
https://docs.microsoft.com/en-us/windows/desktop/dataxchg/standard-clipboard-formats
xf_cliprdr_server_format_data_response receives pasted data from the
server to transfer to the client, in a sufficiently raw form that the
\0 terminator is still present, so it has to remove it. It does so by
checking only at the very end of the data. But I've observed that when
pasting out of at least one Windows program (namely Outlook 1903 on
Windows 10), the intended paste data arrives in this function followed
by \0 and then a spurious \n. In that situation the null-terminator
removal will fail to notice the \0, and will leave both bogus
characters on the end of the paste.
Fixed by using memchr to find the _first_ \0 in the paste data, which
should not lose any actually intentional data because it's in
accordance with the spec above.
2019-04-25 10:54:10 +02:00
David Fort
f9dab4f012
Merge pull request #5354 from ffontaine/master
...
xf_floatbar.c: fix build without Xfixes
2019-04-23 09:56:16 +02:00
Fabrice Fontaine
7dbb64cb62
xf_floatbar.c: fix build without Xfixes
...
Remove unneeded include on Xfixes.h as it is not always available and
not used in xf_floatbar.c
Fixes:
- http://autobuild.buildroot.org/results/69245e574787bada718c52c805ec137041dc233d
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
2019-04-18 23:56:16 +02:00
Armin Novak
2a26aa0d87
Unified update->BeginPaint and update->EndPaint
...
Since these functions were called from 2 different threads
(main thread or dynamic channel) depending on fastpath or
gfx channel use lock between these.
If not locked the invalid region may be accessed from both
threads and lead to crashes as experienced with nightly df280a7ff
2019-04-11 15:33:23 +02:00
byteboon
df280a7ffd
FreeRDP#5329 if using OldLicenseBehaviour, don't try to save the Cal since we're not going to try to load it ( #5330 )
2019-04-08 09:42:02 +02:00
Kubistika
967f2aefac
Fix segfault when IniFile_Load is called with invalid input ( #5331 )
...
* Fix segfault when IniFile_Load is called with invalid input
* Fix leak in TestIni.c third testcase
* TestIni.c: Refactor in order to avoid some old compilers errors
2019-04-08 09:26:46 +02:00
David Fort
7ae72ee512
Merge pull request #5240 from akallabeth/sign_compare_fixes_v2
...
Sign compare fixes v2
2019-04-05 14:13:03 +02:00
Mati Shabtay
6e8c02c9ee
Added optional PreFrameAck callback to RdpgfxClientContext ( #5303 )
...
* RdpgfxClientContext: Add PreFrameAck callback
* client/rdpgfx_main.c: Call PreFrameAck callback before acking frame
* client/rdpgfx_main.c: Fix windows_msbuild_vs2010 CI build
* client/rdpgfx_main.c: Fix error logs log level
2019-04-05 13:37:51 +02:00
Armin Novak
9218712ecf
Remove unnecessary clipboard data copy.
2019-04-05 10:04:36 +02:00
David Fort
e0d60a0310
clipboard: correctly handle flags during renegociatiion ( #5323 )
2019-04-05 09:36:53 +02:00
Armin Novak
f8dd9a9f75
Fixed ntlm_av_pair_get_len return, no signed value required
2019-04-05 09:28:09 +02:00
Armin Novak
2c9cd5067f
Fixed argument pointer type cast
2019-04-05 09:22:50 +02:00
Armin Novak
624d895106
Fixed sign issues
2019-04-05 09:22:35 +02:00
Armin Novak
8d6a12f312
Fixed unnecessary casts in freerdp_image_copy.
2019-04-05 09:14:35 +02:00
Armin Novak
f33e494884
Disabled -Wimplicit-fallthrough for instances where its use is intended.
2019-04-05 09:14:35 +02:00
Armin Novak
082eef05e1
Fixed broken implicit fallthrough
2019-04-05 09:14:35 +02:00
Armin Novak
f9b688a446
Removed duplicate argument checks.
2019-04-05 09:14:35 +02:00
Armin Novak
a1ee97c154
Fixed GetModuleFileNameW.
2019-04-05 09:14:35 +02:00
Armin Novak
29c920c568
Fixed review remarks.
2019-04-05 09:14:35 +02:00
Armin Novak
a16813d237
Fixed SleepEx return value and added log messages for unimplemented features.
2019-04-05 09:14:35 +02:00
Armin Novak
c7b7d527f3
Fixed unused argument warnings for tests.
2019-04-05 09:14:35 +02:00
Armin Novak
e605a10921
Fixed NULL argument warning.
2019-04-05 09:14:35 +02:00
Armin Novak
71924958bd
Added event name to handle.
2019-04-05 09:14:35 +02:00
Armin Novak
55e9132fa4
Fixed NULL argument warning.
2019-04-05 09:14:35 +02:00
Armin Novak
27d2a9e040
Fixed unused argument warnings.
2019-04-05 09:14:35 +02:00
Armin Novak
05901280fe
Fixed unused argument warnings.
2019-04-05 09:14:35 +02:00
Armin Novak
e76b5d442b
Silenced unused parameter warnings, added log messages.
2019-04-05 09:14:35 +02:00
Armin Novak
8b5ef6f41f
Silenced unused parameter warnings, added log messages.
2019-04-05 09:14:35 +02:00
Armin Novak
1d87fdc803
Implemented GetModuleFileNameW
2019-04-05 09:14:35 +02:00
Armin Novak
b5d9b6dba4
Improved timer implementation and error messages.
2019-04-05 09:14:35 +02:00
Armin Novak
f8e5e8cd7d
Improved error logging for wait functions.
2019-04-05 09:14:35 +02:00
Armin Novak
ebb93a1273
Improved implementation of LoadLibrary functions.
2019-04-05 09:14:35 +02:00
Armin Novak
7b246121b4
Improved mutex and event functions
...
* Added name for debugging to handle.
* Implemented *Ex functions
2019-04-05 09:14:35 +02:00
Armin Novak
281dd22061
Fixed unicode key down and up messages.
2019-04-05 09:14:35 +02:00
Armin Novak
295ac3daa4
Fixed dead store warnings
2019-04-05 09:14:35 +02:00
Armin Novak
d91d1edd0c
Fixed dead store warnings
2019-04-05 09:14:35 +02:00