akallabeth
47c5070805
Merge pull request #10635 from akallabeth/initialize-variables
...
Initialize variables
2024-09-30 16:04:20 +02:00
akallabeth
508238711c
Merge pull request #10676 from akallabeth/cmake-file-to-hex
...
Cmake file to hex
2024-09-30 15:58:18 +02:00
akallabeth
ce30f80d2c
[client,common] disable clang-tidy for function
...
change_lock moves ownership of allocated CliprdrLocalStream to
file->local_streams. Do not complain about possible memory leak (false
positive)
2024-09-30 15:41:42 +02:00
akallabeth
fe590801a1
[cmake] replace custom file2hex tool
...
Use CMake to read file and convert to C array of hex values
2024-09-30 10:50:36 +02:00
akallabeth
6e6f50c088
[client,common] improve grab description
...
Better describe what +grab-keyboard and +grab-mouse do.
2024-09-27 13:39:00 +02:00
Armin Novak
66b6a90cc7
[client,x11] fix xf_GetWindowProperty arguments
...
Use BYTE* as argument and cast later to desired type
2024-09-25 10:31:38 +02:00
David Fort
609d04deab
Merge pull request #10671 from akallabeth/workarea-fix
...
[client,x11] fix reading of work area
2024-09-25 07:18:54 +02:00
akallabeth
0d8764263f
[client,sdl] eliminate unused variables
2024-09-24 19:45:20 +02:00
akallabeth
01d565398e
[client,x11] fix reading of work area
...
https://specifications.freedesktop.org/wm-spec/1.4/ar01s03.html
_NET_CURRENT_DESKTOP might not be supported by a window manager. Ignore
failures there and just take the first monitor dimensions.
2024-09-24 13:07:22 +02:00
akallabeth
1f3e6decf2
[client,common] fix possible integer overflow
2024-09-24 11:31:40 +02:00
akallabeth
3d210d815d
[client,X11] fix sign of shifted type
2024-09-24 11:30:23 +02:00
akallabeth
26003e59cc
[va_list] initialize with ={0};
2024-09-24 11:06:18 +02:00
David Fort
57c703cf67
sdl3: various fixes with the clipboard
...
There were various invalid checks with function return values. The patch also
fixes a deadlock between the SDL clipboard data function and the FreeRDP
thread.
2024-09-23 15:35:11 +02:00
akallabeth
239440e28d
[warnings] remove or comment unused macros
2024-09-20 18:49:38 +02:00
akallabeth
69527e117a
[client,X11] update _NET_WM_STATE for WS_EX_TOPMOST
...
* Set _NET_WM_STATE_ABOVE if WS_EX_TOPMOST is set and WS_EX_TOOLWINDOW
clear for a window style
* Clear _NET_WM_STATE_ABOVE in all other cases
2024-09-20 11:33:29 +02:00
akallabeth
d0c1e6055f
[client,X11] add missing _NET_WM_STATE* atoms
2024-09-20 11:33:26 +02:00
akallabeth
0a24f12281
[client,X11] update window style
...
* if WINDOW_ORDER_STATE_NEW is not set also update
2024-09-20 11:31:34 +02:00
akallabeth
fd3c7633d6
[client,X11] fix rails modal windows
...
xf_XSetTransientForHint of windows of type
(WS_EX_CONTROLPARENT | WS_EX_TOOLWINDOW | WS_EX_DLGMODALFRAME)
and parent window set
2024-09-20 11:31:32 +02:00
akallabeth
c8e6b1b71f
[client,x11] log rail WINDOW_STATE_ORDER
2024-09-20 11:31:30 +02:00
akallabeth
2b1abcd550
[client,x11] add helper util x11_error_to_string
...
The helper function x11_error_to_string stringifies a X11 error return
code.
2024-09-20 11:31:27 +02:00
akallabeth
f67e641cce
[client,X11] add helper functions for rail window style
...
* window_styles_to_string
* window_styles_ex_to_string
2024-09-20 11:31:24 +02:00
akallabeth
7a607dbc53
Merge pull request #10630 from akallabeth/disable-ctad-maybe-unuspported
...
[build,c++] add CXXCompilerFlags to (un)set warnings
2024-09-20 10:48:56 +02:00
akallabeth
699fc70941
[client,sdl] update to current sdl3-api
2024-09-20 10:19:29 +02:00
Armin Novak
02b98e9287
[client,sdl] use constexpr instead of defines
2024-09-20 09:17:03 +02:00
Armin Novak
96052ca2fb
[build,c++] add CXXCompilerFlags to set warnings
...
Just like with the C components and CompilerFlags.cmake add a
configuration for C++ that disables specific warnings only found in C++
code.
2024-09-20 09:16:30 +02:00
akallabeth
84719a4d83
[client,sdl] fix class constructors and operators
...
delete unused move/copy constructors and operators
2024-09-18 23:33:50 +02:00
Armin Novak
3905ef0b01
[client,sdl] split sdl_client_thread_run
...
the function can easily be split into three funcions covering a specific
part of the thread loop. Makes the whole thing less complex and easier
to read.
2024-09-18 13:01:46 +02:00
akallabeth
8ef4b2aefa
[client,SDL] move thread cleanup to own function
...
The cleanup code for the RDP thread of the SDL clients grew quite
complex. Move to a function to reduce complexity and make the main
thread more readable again.
2024-09-18 11:48:35 +02:00
akallabeth
b7601ec755
[client,SDL] remove goto usage, replace with RAII
...
* use std::uniqe_ptr to clean up malloced strings
* use ScopeGuard to run cleanup code whenever the function is exited
2024-09-18 11:48:35 +02:00
akallabeth
ed2c5e9a5b
[client,sdl] add scope guard
...
add a class wrapping a cleanup function called when the class instance
is out of scope. useful to clean up C resources in a lambda function
2024-09-18 11:48:34 +02:00
akallabeth
586f40631f
[warnings] fix shorten-64-to-32
2024-09-17 16:13:48 +02:00
David Fort
688f450fc2
SDL3 client: improve the treatment of clipboard data requests
...
This patch adds a success flag on clipboard data requests, so that we can react
correctly in the SDL handler. I've also made some errors non fatal like if you requests
a kind of data that doesn't exist the client should not terminateit's for that.
2024-09-17 11:37:48 +02:00
akallabeth
befa4233ad
[warnings] fixed bugprone-not-null-terminated-result
2024-09-16 08:22:42 +02:00
akallabeth
bb242b9a89
[return checks] fix use of WaitForSingleObject
2024-09-16 08:22:37 +02:00
akallabeth
965d231e49
[return checks] fix use of CloseHandle
2024-09-16 08:22:31 +02:00
akallabeth
cd18dea174
[return checks] fix use of unicode functions
2024-09-16 06:48:26 +02:00
akallabeth
f655843260
[return checks] fix use of rdpSettings getter/setter
2024-09-16 06:48:23 +02:00
akallabeth
07ea37d1d7
[return checks] fix use of CommandLineParseArgumentsA
2024-09-16 06:48:16 +02:00
akallabeth
4c8f6383ae
[return checks] fix use of freerdp_interruptible_getc
2024-09-16 06:48:13 +02:00
akallabeth
94020c183c
[return checks] fix use of ResetEvent
2024-09-16 06:48:09 +02:00
akallabeth
7c8c14294f
[return checks] fix use of ReleaseMutex
2024-09-16 06:48:06 +02:00
akallabeth
7d67b8e204
[return checks] fix use of SetEvent
2024-09-16 06:47:58 +02:00
akallabeth
0d5bc92a2b
[warnings] fix apple iOS/macos
2024-09-15 19:47:13 +02:00
akallabeth
869bfd5e86
[client,android] mark includes SYSTEM
2024-09-15 19:47:03 +02:00
akallabeth
1bd6d70057
[warnings] fix some warnings on mac os
2024-09-15 10:06:22 +02:00
akallabeth
ba41d5e532
[warnings] fix unchecked return
2024-09-15 09:08:02 +02:00
akallabeth
a1cef8dd85
[warnings] silence and fix unused results
2024-09-14 21:29:28 +02:00
akallabeth
3460f64f57
[client,common] fix possible NULL dereference
2024-09-14 21:29:21 +02:00
akallabeth
16cec716e0
[strtok] replace function with strtok_s
...
Since strtok is not thread safe replace it with strtok_s (WinPR wrapper
around strtok_r for systems not supporting the ISO function names)
2024-09-13 21:19:17 +02:00
akallabeth
7ef9345743
Merge pull request #10549 from hardening/rcg2
...
core, channels: client-side remote credential guard
2024-09-13 08:24:14 +02:00
