Commit Graph

2404 Commits

Author SHA1 Message Date
akallabeth
104f3f043e Check stream capacity in rdp_capability_set_finish
(cherry picked from commit 6b0d2a2c3e)
2021-02-25 09:51:41 +01:00
akallabeth
51bf892909 Added data_pdu_type_to_string
(cherry picked from commit b6b8d74521)
2021-02-25 09:51:41 +01:00
akallabeth
bd0558c47f Fixed missing check for fastpath input messages
Input events are only allowed after a connection was established
(connection state is active)
This check aborts input sending when done before that.

(cherry picked from commit 102869f6a8)
2021-02-25 09:51:41 +01:00
Armin Novak
847de7f4ae Fix ColorFidelity use
(cherry picked from commit 8187ab7732)
2021-02-25 09:51:41 +01:00
Armin Novak
605e89a38d Fix color fidelity issues with windows 7
(cherry picked from commit 57b58df806)
2021-02-25 09:51:41 +01:00
Armin Novak
a4048b7d11 Fixed problematic cast of integer mask to bool
(cherry picked from commit 8c353e9292)
2021-02-25 09:51:41 +01:00
Martin Fleisz
ce61bc41cb core: Remove error code from string returned by rpc_error_to_string
This PR removes the error code from the error string returned by
rpc_error_to_string. The error code is passed into the function so it is
not necessary to append it to the returned string as well.

The PR also fixes the screwed formatting of the error code tables.

(cherry picked from commit c78566d2a2)
2021-02-25 09:51:41 +01:00
akallabeth
6522361760 Fixed #6656: invalid read of proxy port.
(cherry picked from commit 3c237fd687)
2020-12-10 07:39:41 +01:00
Armin Novak
e4b30a5cb6 Removed obsolete connectErrorCode
(cherry picked from commit 3b63903d3f)
2020-12-02 14:17:54 +01:00
akallabeth
67d404c783 Fixed remarks.
(cherry picked from commit c0284239a7)
2020-12-02 09:43:22 +01:00
Bernhard Miklautz
c94e9ea14b new [orders]: BMF_24BPP support and some comments
* cached brush orders missed the BMF_24BPP documented case
  ([MS-RDPEGDI] 2.2.2.2.1.2.7)
* add some comments on secondary (brush) order details

(cherry picked from commit efdc99528f)
2020-12-02 09:43:22 +01:00
akallabeth
f00d7aa644 Fix warning #6515
(cherry picked from commit 6d8f355633)
2020-12-02 08:57:00 +01:00
kubistika
39f56443f2 reset codecs in gdi_pipeline_init
(cherry picked from commit 42e63cbf98)
2020-12-01 15:10:23 +01:00
akallabeth
6c74c84f28 Refactored reading of optional order bytes
(cherry picked from commit ef8f1fd9f0)
2020-12-01 15:10:23 +01:00
akallabeth
ce788af28a Fixed parsing of FastGlyph order.
(cherry picked from commit 0456fc307c)
2020-12-01 15:10:23 +01:00
akallabeth
87f1ed1f2d Use settings string setter to overwrite computername
(cherry picked from commit 4d7cddd7c6)
2020-12-01 15:10:23 +01:00
Armin Novak
b0843b68b3 Refactored rdg_read_http_unicode_string warning fixes
(cherry picked from commit bfa07e701d)
2020-12-01 15:10:23 +01:00
Armin Novak
507fecf50e Fixed warnings.
(cherry picked from commit e50a8e09ee)
2020-12-01 15:10:23 +01:00
Armin Novak
e805752c4e Fixed compilation warnings.
(cherry picked from commit 57b405ca26)
2020-12-01 15:10:23 +01:00
Armin Novak
ab1f6d8792 Fixed #6418: Warning due to invalid const qualifier
(cherry picked from commit 226b072af8)
2020-12-01 15:10:23 +01:00
Armin Novak
d27d31e496 Improve NLA auth token debugging
(cherry picked from commit 10ed4ec422)
2020-12-01 15:10:23 +01:00
Armin Novak
81180aff65 Improve NLA error code logging.
(cherry picked from commit 32c9a519df)
2020-12-01 15:10:23 +01:00
akallabeth
92488d5a3c Use freerdp_settings_[s|g]et* api to access proxy vaiables.
Fixes #6414

(cherry picked from commit 44ea09e7ad)
2020-08-05 11:48:39 +02:00
Martin Fleisz
3522179074 Add GatewayMessageType to public API
(cherry picked from commit 174f3257c9)
2020-08-05 10:59:50 +02:00
Martin Fleisz
18c05a1d5f gateway: Add processing of consent and service messages with HTTP gateway
(cherry picked from commit 130494e34a)
2020-08-05 10:59:50 +02:00
akallabeth
5f3ba52de6 Fix #6399: Call ConvertFromUnicode with length -1.
The input string has ensured NULL termination, so let the function
determine the correct length.

(cherry picked from commit 36499527e7)
2020-07-31 11:30:43 +02:00
Norbert Federa
8526965eef core: fix invalid inttype and reference
The error message in tpdu_read_header() printed the pointer address and
used PRIu16 for an UINT8 type

(cherry picked from commit 54fdf7947d)

Fixes #6380
2020-07-20 14:12:34 +02:00
Giovanni Panozzo
138256fbc5 Fix seeking in Cache Brush and other Secondary Drawing Orders
(cherry picked from commit 9f7e475c16)

Fixes #6374
2020-07-15 16:45:14 +02:00
Kobi Mizrachi
db2d8b11e9 libfreerdp: core: add ServerHeartbeat callback
(cherry picked from commit 2096ede5cc)
2020-07-07 09:59:41 +02:00
akallabeth
0c58e0b6dc Added hint for errors due to missing offscreen-cache
(cherry picked from commit 57e7a99393)
2020-07-06 11:14:05 +02:00
Armin Novak
62530e2d9d Fixed #6298: Mask CACHED_BRUSH when checking brush style
(cherry picked from commit ce1a9d8d19)
2020-06-26 11:01:45 +02:00
akallabeth
12800786a8 Fixed OOB read in update_recv_secondary_order
CVE-2020-4032 thanks to @antonio-morales for finding this.

(cherry picked from commit e7bffa64ef)
2020-06-22 12:13:05 +02:00
akallabeth
746d10179c Fixed OOB read in update_read_cache_bitmap_v3_order
CVE-2020-11096 thanks @antonio-morales for finding this.

(cherry picked from commit b8beb55913)
2020-06-22 12:12:50 +02:00
akallabeth
c687b8c267 Fixed invalid access in update_recv_primary_order
CVE-2020-11095 thanks @antonio-morales for finding this.

(cherry picked from commit 733ee32083)
2020-06-22 12:12:41 +02:00
akallabeth
d5609e5467 Fixed OOB Read in license_read_new_or_upgrade_license_packet
CVE-2020-11099 thanks to @antonio-morales for finding this.

(cherry picked from commit 6ade7b4cbf)
2020-06-22 12:11:35 +02:00
Armin Novak
da15d1a3a1 Added missing SECBUFFER_READONLY flag in rpc_client_write_call
(cherry picked from commit 0d80353bf3)
2020-06-22 09:31:02 +02:00
Armin Novak
2d166aea89 TSG improvements
* Respect connection timeout during connect
* Better debug output
* Cleaned up data types,

(cherry picked from commit ff79636d33)
2020-06-22 09:30:57 +02:00
Martin Fleisz
cb07d5a4f6 Fix usage of DsMakeSpn with IP address hostnames
(cherry picked from commit 4e7b60b002)
2020-06-16 09:09:33 +02:00
akallabeth
d2c653baf3 Lock remaining occurances of security_encrypt/security_decrypt variables
(cherry picked from commit f01ae7d257)
2020-06-16 09:07:04 +02:00
akallabeth
4f80017786 Lock security_decrypt to avoid simultaneous counter manipulation
(cherry picked from commit 164c00f68b)
2020-06-16 09:06:56 +02:00
akallabeth
ece877b515 Fixed some more resource cleanup leaks in nla
(cherry picked from commit 354bb7d6ae)
2020-05-20 15:41:24 +02:00
akallabeth
df63cfb55f Reformatted to satisfy clang-format
(cherry picked from commit a4e95f8e65)
2020-05-20 15:41:24 +02:00
Armin Novak
c6bcfb0736 Fixed #6200: Arraysize check
(cherry picked from commit 06c48df0df)
2020-05-20 15:41:24 +02:00
Armin Novak
87bca1088a Fixed #6199: Reading version information in tsg
(cherry picked from commit e501c56e5c)
2020-05-20 15:41:24 +02:00
akallabeth
442ac71ec7 Renamed variable to avoid MSVC define collission
(cherry picked from commit f9e1f21b0ce47d8eeea40314ce6b8b666964dc7d)
2020-05-20 15:41:24 +02:00
akallabeth
fba85da673 Ensure buffers are NULL before reuse in NLA
(cherry picked from commit 5f53b2b7c7109016b7127d595e13bd333ac77613)
2020-05-20 15:41:24 +02:00
akallabeth
9d5bb41445 Removed unused variable warnings
(cherry picked from commit 8052708f3354a686de98b62d641e9d0eb61a74db)
2020-05-20 15:41:24 +02:00
akallabeth
d6cd14059b Fixed GHSL-2020-101 missing NULL check
(cherry picked from commit b207dbba35c505bbc3ad5aadc10b34980c6b7e8e)
2020-05-20 15:41:24 +02:00
akallabeth
a58129346d Fixed extended info packet alignment.
(cherry picked from commit 03ebaf2dc1547c75f8693dd5087ce2e8dc17765a)
2020-05-18 17:10:01 +02:00
akallabeth
4e24cca056 Fixed rdp_read_info_packet unaligned access and size checks
(cherry picked from commit c75d08d70e878d35cd12ffac2aefcda405576092)
2020-05-18 17:10:01 +02:00