akallabeth
0ebeb51f51
Split peer_recv_callback to avoid recursive calls
2022-03-28 15:52:32 +02:00
akallabeth
d3ae821477
Improved logging, compiler warning fixes
...
* Improved logging in TPKT, TPDU, MCS, PER
* Proper use of rdpSettings functions
* Fixed missing return values
* Refactored rdp_server_transition_to_state
2022-03-28 15:52:32 +02:00
akallabeth
7b5ebced28
Fixed use of rdpSettings, prefer getter/setter
2022-03-28 15:52:32 +02:00
akallabeth
102e43baaa
Added functions to set transport io user context
2022-03-28 15:52:32 +02:00
akallabeth
f7b6d3be73
Add peer SetState function to manually set state
...
Expose internal state machine manipulation to allow skipping parts
of a peer connection state
2022-03-28 15:52:32 +02:00
Martin Fleisz
ecf7a5929d
nla: Fix handling of NULL identity
...
While the identity got correctly reset if no username was set,
identityPtr was dangling and caused AcquireCredentialsHandle to fail.
2022-03-25 12:28:32 +01:00
akallabeth
c2e882c509
Nla server cleanup && server auth fix ( #7743 )
...
* Reduce negotiate logging verbosity
* Remove duplicate pointers from rdpNla
* Fixed server nla auth
* Encapsulated nla_server_recv_credentials
2022-03-25 10:47:05 +01:00
akallabeth
14568872a9
Instance cleanup ( #7738 )
...
* Cleaned up freerdp::autodetect
* Deprecate freerdp::input
* Deprecated freerdp::update
* Deprecated freerdp::settings
* Deprecated freerdp::autodetect
* Removed rdpTransport::settings
* Deprecated freerdp_per::update|settings|autodetect
* Fixed mac client and server compilation
* Fixed windows compilation
* Added deprecation warnings
* Fixed initialization of structs.
* Fixed android build
* Fixed freerdp_client_context_new const correctness
* Fixed checks for android implementation
Replaced checks with assertions where appropriate
* Fixed checks for windows client
Replaced checks with assertions where appropriate
* Fixed proxy client pointer dereference
2022-03-23 13:18:35 +01:00
Armin Novak
e5b50c550b
Use GetComputerName instead of gethostname
2022-03-22 10:59:58 +01:00
Armin Novak
705dca41f6
Added a warning for unknown PDU_TYPE_DATA messages
2022-03-16 18:07:08 +01:00
Armin Novak
91ef44ed35
Workaround for [MS-RDPBCGR] 2.2.9.2.3 Frame Marker Command (TS_FRAME_MARKER)
...
Connections with windows 2016 and 2019 sometimes receive short
frame marker. Ignore these to prevent disconnects
2022-03-09 15:52:33 +01:00
akallabeth
704289ffee
Smartcard tls logon fix ( #7709 )
...
* Early return authenticate if TLS smartcard logon
* Removed obsolete SmartcardPin and unified AuthenticateEx calls
* Remove password-is-pin from command line
The setting is implied by smartcard-logon and only of interest in
server side code, so the setting is useless
* Rework AUTH_SMARTCARD_PIN
Just prompt for PIN and not user/domain if this is requested.
* Fixed a memory leak in nla.c
* Align credentail prompt
* Handle AUTH_NLA & smartcard, just ask for PIN
* Added assertions, removed duplicate password prompt check
* Move smartcard logon after credential prompt
2022-03-09 09:09:53 +01:00
Armin Novak
32e05b649d
Added more log messages for SurfaceCommand failures
2022-03-08 15:41:48 +01:00
Armin Novak
71aac852d6
Remove async-input from clients
2022-03-08 15:37:19 +01:00
David Fort
6a3b5573ad
drdynvc: add missing messages definitions
2022-03-07 14:30:52 +01:00
akallabeth
fa3cf9417f
Fixed #7696 : Abort freerdp_connect if manually canceled ( #7700 )
...
If freerdp_abort_connect is called, set FREERDP_ERROR_CONNECT_CANCELLED
This way freerdp_reconnect can distinguish between network issues and
user interaction and abort a retry attempt.
2022-03-07 13:47:43 +01:00
akallabeth
3d38d2636c
Decreased logging verbosity for INFO level
2022-03-04 09:34:02 +01:00
Armin Novak
d1f8c00f7b
Fixed duplicated symbols
2022-03-03 11:26:48 +01:00
Armin Novak
4d03d7c0bf
Freerdp remove #ifdef HAVE_CONFIG_H
2022-03-03 11:26:48 +01:00
Armin Novak
b2ad47a809
Reorganized FreeRDP headers
2022-03-03 11:26:48 +01:00
akallabeth
850e0b107f
Discard SmartcardCerts in case of error.
2022-03-03 08:15:28 +01:00
David Fort
f33c679552
smartcard: fix smartcard enumeration
...
There was a bug in smartcard listing that was leading to be unable to open a key
with slotId != 0. When any error or skipped item was happening during listing
the code was crashing.
2022-03-03 08:15:28 +01:00
akallabeth
64f47848c9
Proxy fixes ( #7686 )
...
* Fixed a memory leak in server side NLA auth
* Fixed #7675 : Pass channel packets directly
2022-03-02 09:13:41 +01:00
David Fort
502f44949a
nla: fix smartcard login under windows
...
Remove incorrect UNICODE flag for Ascii structures.
2022-03-02 07:32:45 +01:00
Armin Novak
499d73e6f4
Replaced strdup with _strdup
2022-02-24 08:52:25 +01:00
Armin Novak
150674f341
Moved headers to appropriate places
2022-02-24 08:52:25 +01:00
David Fort
0435b5a65d
Implement smartcard logon
2022-02-24 08:52:25 +01:00
Armin Novak
b3790d7454
Removed Smartcard files from settings
...
* Removed file names from settings
* Added temporary file creation for pkinit
2022-02-24 08:52:25 +01:00
Armin Novak
649527ef8d
Fixed const correctness of freerdp_smartcard_list
2022-02-24 08:52:25 +01:00
Armin Novak
b46d74806e
Removed FreeRDP_ListSmartcards setting
...
* Directly print smartcard list without intermediate setting
* Centralize the help text, clients do not need to add extra code
2022-02-24 08:52:25 +01:00
David Fort
44c82cd929
Fixes various akallabeth remarks
2022-02-24 08:52:25 +01:00
David Fort
6a5521bb84
fix snprintf usage
2022-02-24 08:52:25 +01:00
Armin Novak
a00238d253
Use freerdp_settings_set and _strdup
2022-02-24 08:52:25 +01:00
Armin Novak
99d63ea89e
Fixed missing static and WINPR_API
2022-02-24 08:52:25 +01:00
David Fort
cb351a099d
Enable smartcard NLA logon
2022-02-24 08:52:25 +01:00
David Fort
62ac25ef54
smartcard_emu: enable to specify the smartcard pin
2022-02-24 08:52:25 +01:00
David Fort
d545ab66e1
tscredential: generate automatically the file from a parser
2022-02-24 08:52:25 +01:00
Armin Novak
fb8eb7251e
Added relative mouse setting
2022-02-22 09:44:13 +01:00
Armin Novak
bf9f1eccc1
Fixed issued with mingw build
2022-02-18 08:38:28 +01:00
Armin Novak
e6877e8135
Hardened registry read in settings
2022-02-15 13:43:36 +00:00
akallabeth
2d2627deab
Fixed SSPI fallback to NTLM ( #7642 )
...
* Fixed SSPI fallback to NTLM
* Fixed wide/ansi mixup
* WITH_GSS fixes
* Move to WinPR as this is not related to FreeRDP
* Add option WITH_GSS_NO_NTLM_FALLBACK to disable NTLM fallback
* Abort NLA if status is SEC_E_NO_CREDENTIALS
* Properly invalidate sspi::SubContext
2022-02-15 09:04:17 +01:00
akallabeth
8cc6582044
Unify struct definitions ( #7633 )
...
* Unified enum/struct definitions, fixed include issues
* Fixed mac compilation issues
* Added missing include
* Fixed windows server build warnings
* Fixed VS2010 build issue
* Removed unnecessary library linking
* Fixed ThreadPool WinXP compatibility
* Fixed pr review remarks
2022-02-14 14:59:22 +01:00
Hiroshi Ota
e27a7e834e
Fix missing KBD_JAPANESE condition
2022-02-14 08:42:36 +00:00
Armin Novak
85f5dbd4b5
Added missing static to internal functions
2022-02-10 12:49:00 +00:00
Armin Novak
edeea86dd1
Improved http_proxy_connect checks
...
* Assert function arguments
* Unify error handling
* Additional buffer size checks
2022-02-07 08:22:19 +00:00
Ayose
b43942a348
HTTP Basic authentication for HTTP proxy connections
...
This patch adds support for authentication when the connection is done
through a HTTP proxy.
It only supports HTTP Basic Authentication (like `curl --proxy`).
It is tested against Apache 2.4.
2022-02-07 08:22:19 +00:00
David Fort
46eb50df2c
proxy: improve channel treatment
...
This PR introduces per channel context so that we can speed up operations like
retrieving the channel name from its id, or knowing what shall be done for a
packet (no config ACL recomputation at each packet).
2022-02-04 08:44:22 +00:00
Armin Novak
cefb4e1237
Use freerdp_settings_set and _strdup
2022-02-02 13:43:31 +00:00
Armin Novak
10e40147fb
Fixed various const warnings
2022-02-01 10:25:37 +00:00
Armin Novak
1f59dff316
Fixed const warnings
2022-02-01 10:25:37 +00:00
