Norbert Federa
ef4b29e5b3
ConvertFromUnicode fixes and misc hardening
...
- Added missing ConvertFromUnicode checks
- If ConvertToUnicode allocates memory, guarantee the null termination
similar to ConvertFromUnicode's implementation
- Fixed some TestUnicodeConversion.c CTest return values
- Added some CTests for ConvertFromUnicode and ConvertToUnicode
- Misc code and protocol hardening fixes in the surrounding code regions
that have been touched
2016-03-03 16:56:19 +01:00
David FORT
7c3f8f33ab
Fixes for malloc / calloc + other fixes
...
This patch contains:
* checks for malloc return value + treat callers;
* modified malloc() + ZeroMemory() to calloc();
* misc fixes of micro errors seen during the code audit:
** some invalid checks in gcc.c, also there were some possible
integer overflow. This is interesting because at the end the data are parsed
and freed directly, so it's a vulnerability in some kind of dead code (at least
useless);
** fixed usage of GetComputerNameExA with just one call, when 2 were used
in misc places. According to MSDN GetComputerNameA() is supposed to return
an error when called with NULL;
** there were a bug in the command line parsing of shadow;
** in freerdp_dynamic_channel_collection_add() the size of array was multiplied
by 4 instead of 2 on resize
2015-06-22 19:21:47 +02:00
Hardening
f8120919af
Add checks for some XXX_New and XXX_Add functions
...
Based on PR #2616
2015-05-18 11:28:00 +02:00
David FORT
c330a3715e
Fix empty window title
...
When the size of a RAIL string was 0, we were reporting an OOM error.
2015-05-07 15:08:00 +02:00
Jonathan Kaplan
8dee5dab27
Fix issue when numWindowIds is 0
2015-04-28 00:21:38 -07:00
Armin Novak
6b0667c959
Fixed use after free and realloc checks.
2015-03-31 15:18:45 +02:00
Zhang Zhaolong
99b14815a5
core: fix incorrect usage of realloc.
...
realloc can handle the case that its first parameter is NULL.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
2015-03-11 13:40:20 +08:00
Marc-André Moreau
589c21d819
libfreerdp-utils: remove rail utils
2014-11-12 10:18:53 -05:00
Armin Novak
2f519d7f16
Replaced logging in libfreerdp with wlog defines.
2014-09-15 08:48:46 +02:00
Armin Novak
f4c133eaf8
Replaced custom logging mechanism with WLog wrapper.
2014-08-07 16:51:24 +02:00
Hardening
07e0eba7db
Check that bpp has reasonable value
...
As bpp is often used for malloc computations, let's check that it has
a reasonable value.
2014-05-29 10:12:02 +02:00
Marc-André Moreau
3cd5652c7d
libfreerdp-core: fix asynchronous queueing of RemoteApp messages
2013-10-22 16:28:23 -04:00
Marc-André Moreau
3e41d5da87
libfreerdp-rail: minor cleanup
2013-10-15 22:42:07 -04:00
Marc-André Moreau
a24d31be31
libfreerdp-core: refactor and add new WLog debug output for graphical orders
2013-10-10 13:00:04 -04:00
Armin Novak
e2e96b8c55
Fixed clang issues.
2013-09-05 12:14:34 +02:00
Armin Novak
e5c138a5b9
Fixed various memory leaks, allocation size issues and API misuse
...
warnings shown by clang as well as some compiler warnings.
2013-09-05 12:14:34 +02:00
Marc-André Moreau
5b92413843
freerdp: purge deprecated stream utils
2013-05-08 16:09:16 -04:00
Marc-André Moreau
51715636a5
freerdp: remove some deprecated stream utils
2013-04-29 22:35:15 -04:00
Marc-André Moreau
a8201b0d1b
libwinpr-utils: combine old and new stream utils
2013-03-21 15:19:33 -04:00
rdp.effort
4d90284657
Renamed CODEC_ID_NONE to RDP_CODEC_ID_NONE as it is already defined in
...
avcodecs.h
Fixed a warning in schannel_openssl.c
Added checks for: input, mcs, tpdu, certificate, license
2013-01-12 14:49:01 +01:00
Marc-André Moreau
8a32de3801
libfreerdp: purged source tree from deprecated memory utils
2012-11-21 21:22:06 -05:00
Marc-André Moreau
b2c3ca8cc4
libfreerdp-utils: replace all calls to deprecated function xzalloc
2012-11-21 19:22:41 -05:00
Marc-André Moreau
9d064171a7
freerdp: get rid of old types
2012-10-09 03:26:39 -04:00
Marc-André Moreau
1bf8a45519
freerdp: change uint8, sint8, uint16, sint16 to BYTE, INT8, UINT16, INT16
2012-10-09 03:01:37 -04:00
Marc-André Moreau
9909a12af5
libfreerdp-utils: get rid of xmalloc, xrealloc and xfree
2012-10-08 23:21:26 -04:00
Marc-André Moreau
e60a092d81
freerdp: fix headers
2012-10-08 23:02:04 -04:00
Marc-André Moreau
c7719e9982
libfreerdp-utils: get rid of rect utils
2012-09-24 04:59:18 -04:00
Marc-André Moreau
d5d1eb7762
libfreerdp: add proper config.h inclusions
2012-08-14 17:09:01 -04:00
Marc-André Moreau
19028a27b0
libfreerdp: move all libraries to libfreerdp directory, one step closer to monolithic build option
2012-08-13 23:19:51 -04:00
