Norbert Federa
1c43a6e115
Merge pull request #2738 from bmiklautz/ffuncs
...
hardening: check fread and fwrite return values
2015-07-01 13:02:32 +02:00
Bernhard Miklautz
798df32fd9
Integrate pull request feedback
...
* unify fwrite usage - set nmemb to 1 and the size to the size to write.
2015-07-01 12:22:32 +02:00
zihao.jiang
75407edf37
Fix event created for WSAEventSelect: The event we pass to WSAEventSelect should be WSAEVENT instead of normal event.
...
From MSDN, it looks same as CreateEvent(NULL, FALSE, FALSE, NULL):
The WSACreateEvent function creates a manual-reset event object with an initial state of nonsignaled. The event object is unnamed.
However they are not really equivalent. When we use normal event, the WSAEventSelect still works but the event appears to be 'auto-reset'.
2015-07-01 01:52:59 +08:00
zihao.jiang
7a59f09ecf
server/shadow: Fix compile error on win32.
2015-07-01 01:36:23 +08:00
ilammy
1012bccdaa
client/x11: do not discard events when updating EGFX surface mapping
...
Passing True to XSync() discards any pending X11 events. Occasionally
this caused ButtonRelease or KeyRelease to be lost and not forwarded
to the remote computed, leading to stuck keys and buttons.
This should resolve issue #2391
2015-06-30 12:48:08 +03:00
Bernhard Miklautz
cc4b5f98c3
Merge pull request #2745 from mfleisz/fix_makecert
...
makecert: Fix double free crashes
2015-06-30 10:46:38 +02:00
Martin Fleisz
d64195d46a
makecert: Fix incorrect return value check
2015-06-30 08:14:28 +02:00
Marc-André Moreau
ff5b876260
channels/drdynvc: silence harmless warnings with Windows 8 / Windows 2012 channel close
2015-06-29 14:47:46 -04:00
Marc-André Moreau
161359f6ec
libfreerdp-core: fix receiving of logon error info during capability exchange
2015-06-29 12:43:18 -04:00
Martin Fleisz
15473557da
makecert: Formatting
2015-06-29 18:10:59 +02:00
Martin Fleisz
bdf02d631e
makecert: Add strdup checks
2015-06-29 18:07:26 +02:00
Martin Fleisz
5632773808
makecert: Fix double free crashes
2015-06-29 17:49:13 +02:00
Bernhard Miklautz
5f2fa8a5e3
Merge pull request #2740 from realjiangms/shadow_fix_cert_2708
...
server/shadow: Fix incorrect handle of makecert_context_process.
2015-06-29 11:28:06 +02:00
Marc-André Moreau
084b365be7
Merge pull request #2741 from awakecoding/master
...
egfx progressive codec frame handling
2015-06-28 15:14:04 -04:00
zihao.jiang
c7b598bc4d
server/shadow: Fix incorrect handle of makecert_context_process.
...
Also fix another typo for makecert_context_set_output_file_name
2015-06-29 02:16:31 +08:00
Marc-André Moreau
a8e62e938a
libfreerdp-codec: fix egfx artifacts resulting from incorrect handling of rects inside the same egfx frame
2015-06-28 13:57:46 -04:00
zihao.jiang
2673a77905
server/shadow: Fix alpha pointer message so that it allows pixel with both 'xor' and 'and'.
...
Integrate idea from @bmiklautz: make convert_alpha_pointer_data function as common
2015-06-28 22:16:29 +08:00
zihao.jiang
457413727f
server/shadow: Fix alpha pointer message so that it allows pixel with both 'xor' and 'and'.
...
Original pointer alpha update message is too specific for x11 implementation.
It doesn't allow pointer alpha mask with both 'xor' color and 'and' mask, e.g.: the 'edit' pointer in windows text box.
1. Move shadow_client_convert_alpha_pointer_data to x11 implementation as it is specific for x11.
2. Update message definition to be more generic: to accept 'xor/and' mask directly.
Implementation of subsystem can implement its own way to convert pointer mask data.
3. Fixed fault handling to free the resource allocated.
2015-06-28 22:16:29 +08:00
Bernhard Miklautz
1cee185e3c
hardening: check fread and fwrite return values
2015-06-26 20:38:30 +02:00
Marc-André Moreau
5ec19d2045
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-06-26 14:00:03 -04:00
Marc-André Moreau
24ed6b06cc
channels/rdpgfx: update debug output
2015-06-26 13:59:41 -04:00
Norbert Federa
20878e50fe
Merge pull request #2724 from bmiklautz/leak_fix
...
Fix leaks in certificate and identity handling
2015-06-26 15:30:00 +02:00
Marc-André Moreau
cf2f4bf9cf
Merge pull request #2737 from nfedera/nf-fix-gdi-return-value-weirdness
...
libfreerdp/gdi: fixed gdi return value madness
2015-06-26 09:24:08 -04:00
Bernhard Miklautz
77ef5a80de
nla: clear identity memory before releasing
2015-06-26 15:12:33 +02:00
Norbert Federa
ac95b7274e
Merge pull request #2727 from akallabeth/leak_fixes_reformat
...
Fixed leaks, NULL dereferences and broken init.
2015-06-26 15:01:08 +02:00
Norbert Federa
bb9536b867
libfreerdp/gdi: fixed gdi return value madness
...
Mostly booleanization to comply with the MS API
2015-06-26 14:32:38 +02:00
Marc-André Moreau
ddf2519f1e
Merge pull request #2719 from bmiklautz/pull/2481
...
OSS, tsmf, usb and BSD fixes and improvements
2015-06-26 08:27:22 -04:00
Bernhard Miklautz
da021fe1a8
Merge pull request #2736 from akallabeth/windows_client_fix
...
Fixed windows client pre_connect return.
2015-06-26 14:20:37 +02:00
Norbert Federa
5281070045
Merge pull request #2734 from giox069/master
...
Fixes for software GDI issues #2732 and #2137
2015-06-26 13:15:56 +02:00
Armin Novak
8165031eb4
Fixed windows client pre_connect return.
2015-06-26 13:13:32 +02:00
Bernhard Miklautz
54c4dd6264
Merge pull request #2735 from akallabeth/clipboard_temp_file_name_conversion_fix
...
[Clipboard] Fixed out of bound array access.
2015-06-26 12:49:42 +02:00
Hardening
b411c11f6e
Merge pull request #2729 from akallabeth/win_reg_key_by_vendor_product_define
...
Replaced hard coded registry keys with cmake defines.
2015-06-26 11:15:09 +02:00
Armin Novak
015754633d
Fixed out of bound array access.
2015-06-26 09:50:21 +02:00
Giovanni Panozzo
8a45b567fc
Returing OK when there is nothing to draw after clipping, fixes #2732
2015-06-25 16:54:08 +02:00
Giovanni Panozzo
85b5c5f890
Signed glyph offset calculation, fixes #2137
2015-06-25 16:49:29 +02:00
Norbert Federa
91353f00a8
Merge pull request #2731 from akallabeth/mutex_cleanup_fix
...
Fixed mutex trylock in MutexCloseHandle.
2015-06-25 12:39:12 +02:00
Armin Novak
b81aaa9cc2
Fixed mutex trylock in MutexCloseHandle.
2015-06-25 12:24:28 +02:00
Norbert Federa
a4c9a7f604
Merge pull request #2728 from bmiklautz/unsigned
...
Fix possible endless loops on cleanup.
2015-06-25 12:11:50 +02:00
Bernhard Miklautz
cbbc680131
clipboard: fix of by one error on cleanup
2015-06-25 11:53:03 +02:00
Bernhard Miklautz
28e63786cd
Integrate pull request feedback
...
Use while instead of for with additional variable where appropriate.
2015-06-25 10:33:54 +02:00
David FORT
a8fefae3a1
Harden the sound channel
...
This patch adds checks for the sound channel and plugins:
* checks for protocol bytes;
* checks for malloc/calloc;
* be more strict when interacting with sound plugin
2015-06-24 17:06:45 +02:00
Armin Novak
80ba4643dc
Fixed cleanup of resources, only in error case now.
2015-06-24 14:59:59 +02:00
Armin Novak
e8bfa29bd2
Replaced registry keys with cmake defines.
2015-06-24 14:02:48 +02:00
Bernhard Miklautz
9f6fa7ef4c
Fix possible endless loops on cleanup.
...
Some cleanup code possibly create endless loops because an unsigned
type was used as run variable but the check was >= 0 in the for loop.
2015-06-24 12:26:13 +02:00
Armin Novak
c78b6f38ab
Fixed cleanup of MachineAddresses and MachinePorts.
2015-06-24 12:14:06 +02:00
Armin Novak
ee221315db
Fixed loop condition.
2015-06-24 10:08:04 +02:00
Armin Novak
a809b87362
Fixed memory leak.
2015-06-24 10:02:42 +02:00
Armin Novak
4c9ee07eb6
Fixed sizeof misuse.
2015-06-24 10:02:30 +02:00
Armin Novak
2ff1205dde
Fixed a resource leak.
2015-06-24 09:45:40 +02:00
Armin Novak
2e762c881c
Fixed a resource leak.
2015-06-24 09:33:20 +02:00