mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
14,328 Commits 6 Branches 74 Tags
Commit Graph

4130 Commits

Author SHA1 Message Date
akallabeth
072b3d9a00 Fixed #6267: adjust write_pixel_16 endian handling 
(cherry picked from commit 51d3e07c8a4bca32bf82538075e4518b63e8ed4d)
 2020-06-16 09:09:11 +02:00
Ondrej Holy
25ac571dd7 gdi: Fix missing unlock 
This fixes the following defect reported by covscan tool:
libfreerdp/gdi/gfx.c:144: missing_unlock: Returning without unlocking "update->mux".

(cherry picked from commit 914808f62cd2ac4a6984ee638112e8dc3aad9e52)
 2020-06-16 09:08:15 +02:00
Armin Novak
39c5243247 Fixed #6245: Added additional tests to assistance parser 
(cherry picked from commit 69141aa830b6e73e859f907b9bd2a4cac2777d8f)
 2020-06-16 09:07:27 +02:00
akallabeth
d2c653baf3 Lock remaining occurances of security_encrypt/security_decrypt variables 
(cherry picked from commit f01ae7d2573b677eba6c8a50fe12246a23b15f2e)
 2020-06-16 09:07:04 +02:00
akallabeth
4f80017786 Lock security_decrypt to avoid simultaneous counter manipulation 
(cherry picked from commit 164c00f68b64781d8c624a8c71fab6691519d294)
 2020-06-16 09:06:56 +02:00
Kobi Mizrachi
6e87805869 codec: fix typo in progressive codec log 
(cherry picked from commit 8d72051ab157d89af3f919a441170ca57bf67e84)
 2020-05-20 15:41:24 +02:00
akallabeth
ece877b515 Fixed some more resource cleanup leaks in nla 
(cherry picked from commit 354bb7d6ae98df282775d154b609a39c1068a09b)
 2020-05-20 15:41:24 +02:00
akallabeth
df63cfb55f Reformatted to satisfy clang-format 
(cherry picked from commit a4e95f8e65dfbfd2625034ad6740645366a6c0c0)
 2020-05-20 15:41:24 +02:00
akallabeth
f975fe2746 Abort on first possible certificate validation error 
Only retry certificate validation if the purpose was wrong.

(cherry picked from commit de619e9964684eced5fb3108de81440b979aace0)
 2020-05-20 15:41:24 +02:00
Armin Novak
c6bcfb0736 Fixed #6200: Arraysize check 
(cherry picked from commit 06c48df0dfd228646fed00c554a20ae9bcaa5e5e)
 2020-05-20 15:41:24 +02:00
Armin Novak
87bca1088a Fixed #6199: Reading version information in tsg 
(cherry picked from commit e501c56e5ca0c76c4019e7048cba3ee63331d830)
 2020-05-20 15:41:24 +02:00
akallabeth
442ac71ec7 Renamed variable to avoid MSVC define collission 
(cherry picked from commit f9e1f21b0ce47d8eeea40314ce6b8b666964dc7d)
 2020-05-20 15:41:24 +02:00
akallabeth
fba85da673 Ensure buffers are NULL before reuse in NLA 
(cherry picked from commit 5f53b2b7c7109016b7127d595e13bd333ac77613)
 2020-05-20 15:41:24 +02:00
akallabeth
9d5bb41445 Removed unused variable warnings 
(cherry picked from commit 8052708f3354a686de98b62d641e9d0eb61a74db)
 2020-05-20 15:41:24 +02:00
akallabeth
d6cd14059b Fixed GHSL-2020-101 missing NULL check 
(cherry picked from commit b207dbba35c505bbc3ad5aadc10b34980c6b7e8e)
 2020-05-20 15:41:24 +02:00
akallabeth
8305349a94 Fixed GHSL-2020-102 heap overflow 
(cherry picked from commit 197b16cc15a12813c2e4fa2d6ae9cd9c4a57e581)
 2020-05-20 15:41:24 +02:00
akallabeth
cf4f6dbf3f Fixed multiple sanitizer errors in codecs 
(cherry picked from commit 2278d92a5d902692a7d1088629b2345c9b4e229c)
 2020-05-20 15:41:24 +02:00
akallabeth
2e28385fbb Fixed history buffer reset. 
(cherry picked from commit ccc9cbef2d5d0d9f5cf5ec7621f71bed33f41aba)
 2020-05-18 17:10:01 +02:00
akallabeth
a58129346d Fixed extended info packet alignment. 
(cherry picked from commit 03ebaf2dc1547c75f8693dd5087ce2e8dc17765a)
 2020-05-18 17:10:01 +02:00
akallabeth
4e24cca056 Fixed rdp_read_info_packet unaligned access and size checks 
(cherry picked from commit c75d08d70e878d35cd12ffac2aefcda405576092)
 2020-05-18 17:10:01 +02:00
akallabeth
f2d836cd94 Fixed memory leak in test 
(cherry picked from commit 2d630cccf7b1e566f99b74a224805fc25f85d6c1)
 2020-05-18 17:10:01 +02:00
akallabeth
1a11f129ab Fixed unaligned access 
(cherry picked from commit cb2ed7f09ad68242bfdfad8967024b063f785d97)
 2020-05-18 17:10:01 +02:00
akallabeth
47c456c39f Rewritten rdp_recv_logon_info_v2 to remove unaligned access 
(cherry picked from commit 66d182a84bed7bf19b6a99d71a4e4c7c6856f583)
 2020-05-18 17:10:01 +02:00
akallabeth
5cf27e3969 Rewritten check to satisfy BehaviouralSanitizer 
(cherry picked from commit 14829de866b43e7f2740b46f0c736b9adf5067eb)
 2020-05-18 17:10:01 +02:00
akallabeth
6dfd915004 Fixed undefined behaviour 
(cherry picked from commit c15929d821ce99aa8c1069f790f4addbe9439593)
 2020-05-18 17:10:01 +02:00
akallabeth
73fd3c0a7c Fixed undefined behaviour in primitives shift 
(cherry picked from commit 436bd3dbb103c7c49e51ffb1cafad6f25ab05d66)
 2020-05-18 17:10:01 +02:00
akallabeth
11c6ed0fb7 Fixed undefined behaviour in ncrush 
(cherry picked from commit 83137d2a1bb732fbea2f20778924a50a79f63fef)
 2020-05-18 17:10:01 +02:00
akallabeth
f25c2f265e Fixed undefined behaviour in rfx decoder 
(cherry picked from commit ef611d34d61c6590429c17db5c97f0a9a33147e8)
 2020-05-18 17:10:01 +02:00
akallabeth
37158cd17f Fixed UndefinedBehaviour in planar left shift 
(cherry picked from commit 328691c46597c194f01a77a9d33d58b2faa88c9d)
 2020-05-18 17:10:01 +02:00
akallabeth
c060089a2b Refactored settings clone/free, extended tests 
(cherry picked from commit 773ad6e9791844ca3ccdc40d378a37fc0238ef0a)
 2020-05-18 17:10:01 +02:00
akallabeth
96621d4f45 Always require aligned memory for interleaved codec. 
(cherry picked from commit 20c11fb7178462a8ba36b4fdbfb3e2a03197356f)
 2020-05-18 17:10:00 +02:00
akallabeth
064a90c8b3 Fixed BehaviorSanitizer warnings 
(cherry picked from commit afdd81dab5c484ab95b977a0d71f3809c8fa89a3)
 2020-05-18 17:10:00 +02:00
Vladyslav Hordiienko
11eb374ef4 improve RFX DWT algorithm 
merge multiple loops into the one loop for vertical DWT inverse

(cherry picked from commit fff9eba34af8a54bd93b1a7ccdda0a6a6898f755)
 2020-05-18 16:56:03 +02:00
akallabeth
64bec7586d Replaced strtok with strtok_s 
(cherry picked from commit 7890833af8a891765a475bd7ae2a756aeddd4977)
 2020-05-18 16:56:03 +02:00
Kobi Mizrachi
efecbf41a9 change use of strtok to strtok_s 
(cherry picked from commit 6013a96bff20affbb4c0a1780d35a751eafa4903)
 2020-05-18 16:56:03 +02:00
akallabeth
0f89e23542 Fixed #6148: multiple ceritificate purposes 
OpenSSL certificate verification can only check a single purpose.
Run the checks with all allowed purposes and accept any.

(cherry picked from commit f3063a589d908a087a295b9217bc5fa34a80fb36)
 2020-05-18 16:41:11 +02:00
akallabeth
2f75c4ac8d Ensure all NLA structs are freed up 
(cherry picked from commit 477ad675f31a1965833304f79406599e0ad97b82)
 2020-05-18 16:40:33 +02:00
akallabeth
5fc0ddeff5 Fixed #6156: Enforce synchronized encrypt count 
Old style RDP encryption uses a counter, synchronize this for
packets send from different threads.

(cherry picked from commit 873a9bef42017ff694659538f70909f679eb1eac)
 2020-05-18 16:38:42 +02:00
akallabeth
1178381809 Silence valgrind in rdp_read_header 
If a disconnect message is received, we returned success but did
not initialize the return arguments.

(cherry picked from commit b45336f51febb4c34b5bf33fdf8d63ce44fe9e99)
 2020-05-08 11:11:12 +02:00
Linus Heckemann
3c24e10bf3 shadow_server: allow specifying IP addresses to listen on (#6050) 
* shadow_server: allow specifying IP addresses to listen on

This allows using IPv6 as well as listening only on specific
interfaces. Additionally, it enables listening on local and TCP
sockets simultaneously.

* listener: log address with square brackets

This disambiguates IPv6 addresses.

* shadow_server: check error on each socket binding

* Refactored shadow /bind-address for 2.0 compiatibility.

* Made /ipc-socket and /bind-address incompatible arguments.

* Fixed shadow /bind-address handling and description

* Allow multiple bind addresses for shadow server.

Co-authored-by: akallabeth <akallabeth@posteo.net>
 2020-05-08 11:06:02 +02:00
akallabeth
c903aa0409 Fixed index out of bound access in update_glyph_offset 2020-05-08 11:06:02 +02:00
akallabeth
0f266b5362 Fixed #6112: Segfault in update_decompress_brush 
The iterators need to be signed for the loop check to work.
 2020-05-05 07:46:10 +02:00
akallabeth
e35d06f6e1 Fixed oob read in rfx_process_message_tileset 
Check input data length
Thanks to hac425 CVE-2020-11043
 2020-05-05 07:46:10 +02:00
akallabeth
32f705e597 Fixed oob read in clear_decompress_subcode_rlex 
Fixed length checks before stream read.
Thanks to hac425 CVE-2020-11040
 2020-05-05 07:46:10 +02:00
akallabeth
738d4bff00 Fixed oob read in update_recv 
properly use update_type_to_string to print update type.
Thanks to hac425 CVE-2020-11019
 2020-05-05 07:46:10 +02:00
akallabeth
f5b838de37 update_decompress_brush: explicit output length checks 
The output length was just assumed to be >= 256 bytes, with this
commit it is explicitly checked.
 2020-05-05 07:46:10 +02:00
akallabeth
13dac0ee2a Fixed possible int overflow. 2020-05-05 07:46:10 +02:00
akallabeth
09d0124418 Remove unnecessary cast. 2020-05-05 07:46:10 +02:00
akallabeth
a1a6790f99 Fixed oob read in irp_write and similar 2020-05-05 07:46:10 +02:00
Armin Novak
bc4615e5ed Added expert settings /tune and /tune-list 2020-05-05 07:46:10 +02:00