Armin Novak
17bbe7a23f
Do not compile extended authentication debugging by default.
2018-11-21 15:36:31 +01:00
Armin Novak
d8d30a0554
Fix #5037 : Fix calls to ntlm_print_av_pair_list
2018-11-21 09:18:38 +01:00
Armin Novak
eb57ed3a30
Refactored ntlm_av_pairs API
...
Tightened checks, cleaned up code and improved redability.
2018-11-20 11:08:31 +01:00
Armin Novak
2ee663f39d
Fixed CVE-2018-8789
...
Thanks to Eyal Itkin from Check Point Software Technologies.
2018-11-20 11:08:31 +01:00
Armin Novak
28f51efe9c
Fixed update of log filters in case of level change.
2018-11-19 13:04:40 +01:00
Armin Novak
37a01a19d8
Fix #5024 : Update inherited log level for all child loggers when setting a new one.
2018-11-19 12:19:12 +01:00
Armin Novak
a2cd934184
Fixed windows build warnings.
2018-11-15 09:01:53 +01:00
Ilya Shipitsin
77323d6f1d
remove not needed check
...
PVS analyzer: A part of conditional expression is always true: DomainMatch.
2018-11-15 01:54:39 +05:00
Ilya Shipitsin
be8f70998a
remove not needed check
...
PVS analyzer: A part of conditional expression is always true: bWaitAll.
2018-11-15 01:51:44 +05:00
Bernhard Miklautz
a9bcc07d23
fix [winpr/sspi]: export symbols on all systems
2018-11-14 12:19:36 +01:00
Martin Fleisz
097ac0ee13
Merge pull request #4997 from akallabeth/use_bio_free_all
...
Replaced BIO_free with BIO_free_all
2018-11-12 13:55:36 +01:00
Martin Fleisz
6d6a2959c2
Merge pull request #4968 from akallabeth/timezone_updates
...
Simplified timezone update handling:
2018-11-09 12:07:43 +01:00
Martin Fleisz
a7f0da2440
Merge pull request #4961 from akallabeth/align_malloc_fix
...
Fixed #2039 : Check for overflow in calculations.
2018-11-09 11:58:04 +01:00
Armin Novak
71036fe0b2
Fixed #2039 : Check for overflow in calculations.
2018-11-09 10:50:53 +01:00
Armin Novak
5f4843191b
Replaced BIO_free with BIO_free_all
...
There is no point in using BIO_free with a custom recursion
to free up stacked BIOs if there is already BIO_free_all.
Using it consistently avoids memory leaks due to stacked BIOs
not being recursively freed.
2018-11-08 12:09:49 +01:00
Armin Novak
6a2d49e0ed
Simplified timezone update handling:
...
* Fix #4965 : Adjusted the timezone update script to initialize
structs properly.
* Updated the scripts to generate the files directly
* Added a small HOWTO
* Split zone information to separate files to allow automatic
update without further manual editing.
Create a timezone.c file that does conform to C rules.
2018-11-07 14:46:24 +01:00
Bernhard Miklautz
472f7ea936
fix [winpr/util]: memory leak in TestCmdLine
2018-11-05 12:29:06 +01:00
Bernhard Miklautz
29d3fea3d7
Merge pull request #4974 from Devolutions/android_timezone_fix
...
Remove unsupported call to fseek when file is opened with popen
2018-10-31 11:26:19 +00:00
Jonathan Lafontaine
610a882f1d
remove unsupported call to fseek when file is opened with popen
2018-10-30 16:47:06 -04:00
Martin Fleisz
7b0f4f5dc4
Merge pull request #4907 from akallabeth/transport_write_leak_fix
...
Transport write leak fix
2018-10-29 14:54:55 +01:00
Armin Novak
fffd352f83
Fixed warnings in Stream test.
2018-10-25 15:52:12 +02:00
Armin Novak
b7f272cd16
Fixed casts in Data_Read macros.
2018-10-25 15:52:12 +02:00
Armin Novak
97e68deea5
Fixed initialisation in DEFINE_EVENT_ENTRY define
2018-10-24 16:50:05 +02:00
Armin Novak
987ca5ec6a
Fixed another bunch of warnings.
2018-10-24 14:36:12 +02:00
Armin Novak
86f08981ef
Fixed warnings of uninitialized struct values.
2018-10-24 13:25:18 +02:00
Armin Novak
46d6aa4e2b
Fixed cast warnings for thread wrapper
2018-10-24 13:24:45 +02:00
akallabeth
16d37b1a17
Merge pull request #4932 from hardening/stream_static
...
winpr: add some functions to use wStream in a static way
2018-10-22 21:16:36 +02:00
Norbert Federa
0572572eb9
fix issue with fnObjectFree and related casts
...
- remove unnecessary/dangerous OBJECT_xxx function-style casts
- fix -Wstrict-prototypes issue with OBJECT_NEW_FN definition
2018-10-19 11:30:01 +02:00
Armin Novak
554e18780b
USe const compare function pointer arguments
2018-10-18 09:06:55 +02:00
David Fort
13e2a8834d
winpr: add some functions to use wStream in a static way
...
It's sometime useful to create a stream aliasing a buffer on the stack, and
it's nice if we don't need some extra malloc for this.
Example use:
BYTE buffer[20];
wStream s;
Stream_StaticInit(&s, buffer, sizeof(buffer));
Stream_Write_UINT16(&s, 0xff01);
Stream_Free(&s, FALSE);
2018-10-17 19:07:48 +02:00
Armin Novak
3416d1bdee
Reset stream length to capacity in StreamPool_Take
2018-10-17 14:54:53 +02:00
Armin Novak
f91590ecbf
Fixed bugs detected during scanbuild run
2018-10-17 13:19:33 +02:00
Marc-André Moreau
ce234411c9
Merge pull request #4914 from Devolutions/winpr-dll-export
...
Add WINPR_DLL definition to control WinPR symbol exporting
2018-10-16 09:09:05 -04:00
Martin Fleisz
168bab905d
Merge pull request #4916 from Devolutions/ios-path-fix
...
Fix iOS path detection functions
2018-10-05 09:50:27 +02:00
Sébastien Duquette
2497fcf941
Use fnObjectEquals in ArrayList_Remove.
2018-10-04 16:57:29 -04:00
Richard Markiewicz
ee7b5460b5
freerdp - fix iOS directory paths
2018-10-04 16:54:40 -04:00
Marc-André Moreau
1b42e512ee
winpr: add WINPR_DLL definition
2018-10-04 15:09:49 -04:00
Armin Novak
a0f42280c3
Check if a boolean or flag argument has additional data.
...
Treat it as an error.
2018-09-28 12:59:20 +02:00
Armin Novak
bfeac80ed3
Fixed macro _stream_read_n16_le and _stream_read_n16_be
...
Cast to appropriate type to avoid integer truncation warnings.
2018-09-14 10:08:38 +02:00
Armin Novak
fad20be6e6
Fixed missing includes.
2018-08-27 14:34:42 +02:00
Armin Novak
00a5d06fc1
Fixed coverity memory leak.
2018-08-27 14:34:42 +02:00
Armin Novak
62c1696d4c
Removed use of unchecked sprintf
2018-08-27 14:34:42 +02:00
Armin Novak
114abad767
Removed use of strcpy.
2018-08-27 14:34:09 +02:00
Armin Novak
d7d5567891
Fixed missing const.
2018-08-24 13:40:36 +02:00
Armin Novak
c159b2e9c8
Fixed missing check before calling memcpy
2018-08-24 13:40:36 +02:00
Martin Fleisz
8248dcb3bb
Merge pull request #4816 from akallabeth/drive_cmd_fix
...
Fix #4680 : Return proper directory name.
2018-08-24 09:45:26 +02:00
Martin Fleisz
0afba58405
Merge pull request #4814 from akallabeth/linked_list_add_object
...
Linked list add object for user defined functions
2018-08-24 08:37:41 +02:00
Armin Novak
ab18f8f222
Fix #4680 : Return proper directory name.
2018-08-23 10:04:26 +02:00
Ondrej Holy
95a043e0eb
winpr/winsock: Fix leak found by covscan
...
0 is valid return value from socket().
leaked_handle: Handle variable "fd" going out of scope leaks the handle.
2018-08-23 09:11:24 +02:00
Ondrej Holy
0a11a06dc9
winpr/winsock: Format code by astyle
...
Run ./scripts/format_code.sh before the following changes.
2018-08-23 09:11:24 +02:00
Ondrej Holy
10b9c516f6
winpr/utils/wlog: Fix leak found by covscan
...
leaked_storage: Variable "result" going out of scope leaks the storage it points to.
leaked_storage: Variable "bt" going out of scope leaks the storage it points to.
2018-08-23 09:11:24 +02:00
Ondrej Holy
d3c2ceb0f6
winpr/utils/wlog: Format code by astyle
...
Run ./scripts/format_code.sh before the following changes.
2018-08-23 09:11:24 +02:00
Ondrej Holy
4813a70897
winpr/utils/ntlm: Prevent releasing function argument
...
The patch changes API of functions instead of fixing unused and broken code.
freed_arg: "free" frees parameter "NtHash".
2018-08-23 09:11:24 +02:00
Ondrej Holy
1c1d00aac0
winpr/utils/ntlm: Format code by astyle
...
Run ./scripts/format_code.sh before the following changes.
2018-08-22 14:34:02 +02:00
Ondrej Holy
35bccd5262
winpr/sspi/ntlm: Fix leak found by covscan
...
leaked_storage: Variable "sam" going out of scope leaks the storage it points to.
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
leaked_storage: Variable "snt" going out of scope leaks the storage it points to.
2018-08-22 14:34:02 +02:00
Ondrej Holy
724bc7acd2
winpr/io/device: Fix leak found by covscan
...
leaked_storage: Variable "lpPipePath" going out of scope leaks the storage it points to.
2018-08-22 14:34:02 +02:00
Ondrej Holy
df9d0fab80
winpr/io/device: Format code by astyle
...
Run ./scripts/format_code.sh before the following changes.
2018-08-22 14:34:02 +02:00
Ondrej Holy
acbd6e6322
winpr/file: Fix leak found by covscan
...
overwrite_var: Overwriting handle "h" in "h = (HANDLE)0xffffffffffffffff" leaks the handle.
2018-08-22 14:34:02 +02:00
Armin Novak
b77dc13b5f
Implemented linked list compare and value copy functions.
2018-08-22 12:39:11 +02:00
Armin Novak
8b8e85271c
Fixed #4793 : Return correct file handle for existing directory
2018-08-13 13:17:56 +02:00
Armin Novak
0352dc3d6c
Fixed invalid format string.
2018-08-01 12:56:18 +02:00
Armin Novak
ed89328349
Fixed missing argument checks.
2018-07-30 10:46:20 +02:00
Armin Novak
3d8dec7fbf
Removed debug log messages.
2018-07-11 16:37:29 +02:00
Armin Novak
dbfa896d5a
Fixed errno reset.
2018-07-11 16:27:14 +02:00
Armin Novak
2b91095eb3
Fixed pattern detection if path is already a directory.
2018-07-11 10:58:37 +02:00
Armin Novak
30843ef4d8
Code cleanups and more logging.
2018-07-11 10:53:26 +02:00
Pascal J. Bourguignon
17a3782d1a
FIX: moved declarations above the statements for strict C 90 compliance.
2018-06-07 13:29:44 +02:00
Pascal J. Bourguignon
15f2bafeab
Cleaned up const char** -> char** for argv, since we definitely do modify the argv!
...
(we overwrite the password and pin arguments).
This implies changes in the argument parsing tests that now must pass a mutable argv
(copied from the statically declared test argvs).
Some other const inconsistency have been dealt with too.
2018-06-06 16:43:09 +02:00
Robert Corrigan
992554a01f
Update time zone data to April 2018
2018-05-15 15:53:36 -04:00
Armin Novak
5a5b5eb6dd
Fixed loadepng memory leak.
2018-05-15 14:30:35 +02:00
Martin Fleisz
f653686958
Merge pull request #4637 from akallabeth/win_ninja_support
...
VS2017 support: set pdb output directory for Ninja generator.
2018-05-15 13:47:28 +02:00
Armin Novak
e8b9116507
Fixed invalid function argument for ntlm_compute_message_integrity_check
2018-05-11 11:00:46 +02:00
Armin Novak
e71a39f214
Fixed compiler warnings (unused)
2018-05-11 11:00:01 +02:00
Armin Novak
6e958e7edb
Fix #4628 : CommandLineFindNextArgumentA must check the current argument
...
When determining if there is a next argument first check the current one
for abort criteria.
2018-05-06 10:49:05 +02:00
Armin Novak
5b961e9c75
Fixed /pth: Consistently treat the hash offset to password length.
2018-05-03 17:51:11 +02:00
akallabeth
dd577377dd
Merge pull request #4617 from kevans91/spurious
...
Upstream the rest of our local FreeBSD patching
2018-05-03 11:55:03 +02:00
akallabeth
d130d9cb21
Merge pull request #4613 from kevans91/file64
...
Enable 64-bit file support on FreeBSD as well
2018-05-03 11:31:54 +02:00
akallabeth
ba37f04e1b
Merge pull request #4616 from kevans91/timerfd-nonblock
...
Pass TFD_NONBLOCK to timerfd_create to avoid later fcntl
2018-05-03 10:56:04 +02:00
akallabeth
613e0be208
Merge pull request #4614 from kevans91/cmakemod
...
Abstract away CMake module installation setting, install differently on FreeBSD
2018-05-03 09:49:31 +02:00
Kyle Evans
8073a7850e
Pull in the libepoll-shim includes for libwinpr's synch/test
...
This allows FreeBSD to successfully build with BUILD_TESTING enabled. Currently,
only 3/184 tests fail:
13 - TestLibraryLoadLibrary (Failed)
14 - TestLibraryGetProcAddress (Failed)
15 - TestLibraryGetModuleFileName (Failed)
These failures are probably due to a lack of GetModuleFileNameA implementation
on FreeBSD.
2018-05-02 23:19:44 -05:00
Kyle Evans
2fb992a962
Upstream the rest of our local FreeBSD patching
...
FreeBSD/DragonflyBSD are also UNIX platforms, as far as trio is concerned, and
we don't need to be setting the CMAKE_INSTALL_RPATH on FreeBSD.
2018-05-02 22:09:42 -05:00
Kyle Evans
f1a7c3cc6a
Pass TFD_NONBLOCK to timerfd_create to avoid later fcntl
2018-05-02 21:03:49 -05:00
Kyle Evans
5463b23591
Enable 64-bit file support on FreeBSD as well
2018-05-02 10:38:44 -05:00
Kyle Evans
a7c0632bf2
Use SetFreeRDPCMakeInstallDir where CMake modules are installed
2018-05-02 10:36:52 -05:00
Armin Novak
60bf33f79d
Determine posix timer availability by function availability
...
To avoid having to whitelist every os starting to implement posix
timer API just detect if the functions are available.
2018-05-02 11:17:32 +02:00
David Fort
a03c0d88d5
Merge pull request #4606 from kevans91/libressl-fixes
...
Pull in the LibreSSL compatibility patches from FreeBSD
2018-05-02 10:39:22 +02:00
Martin Fleisz
c0804699f1
Merge pull request #4609 from akallabeth/clipboard_return_check
...
Added proper return value checks for clipboard data.
2018-05-02 10:10:55 +02:00
Armin Novak
a1c3c1ad64
Added proper return value checks for clipboard data.
2018-05-02 09:21:42 +02:00
Kyle Evans
45d8e2dfb2
Pull in libepoll-shim for the bits that require timerfd/epoll
...
libepoll-shim is our implementation of this API on top of kevent. It supplies
the same headers and a library, but we don't install it in any of the default
include search paths when it comes in through ports on an as-needed basis.
This set of changes is restricted to FREEBSD-compatible OS, which includes
DragonflyBSD and FreeBSD.
2018-05-01 23:42:25 -05:00
Kyle Evans
f8c391876f
Pull in the LibreSSL compatibility patches from FreeBSD
2018-05-01 08:43:36 -05:00
Martin Fleisz
b228deb998
Merge pull request #4543 from oshogbo/master
...
Fix variable passsed to HashCallback with MIC.
2018-04-18 14:50:31 +02:00
Mariusz Zaborski
509afe252d
Remove MessageIntegrityCheck from context.
2018-04-17 15:03:27 +02:00
Mariusz Zaborski
fe37fede50
Fix variable passsed to HashCallback with MIC.
...
The value in the context is not set yet and we need one from
authentication message.
2018-04-06 21:18:20 +02:00
Mariusz Zaborski
00374382d9
There is no reason to restrict nSize to 2 the hostname can be empty on
...
UNIX-like machines.
2018-04-06 21:07:51 +02:00
MartinHaimberger
a9ecd6a6cc
Merge pull request #4535 from akallabeth/warning_fixes
...
Warning fixes
2018-04-05 10:20:43 +02:00
MartinHaimberger
55973288f2
Merge pull request #4514 from akallabeth/com_lpt_fix
...
Com lpt fix
2018-04-04 12:52:39 +02:00
Armin Novak
842707b106
Fixed printf format string.
2018-04-04 10:44:51 +02:00
Armin Novak
b260937ca6
Use __attribute__((destructor)) on non windows systems.
...
atexit in shared libraries is not universally supported.
2018-04-03 14:04:22 +02:00
Armin Novak
e0d112d548
Removed all calls to WLog_Init and WLog_Uninit
...
Since the calls are no longer required remove their usage.
2018-04-03 13:06:41 +02:00
Armin Novak
d249335708
Removed winpr_exit
...
As the cleanup functions are called by atexit a dedicated
cleanup call is no longer required.
2018-04-03 12:56:33 +02:00