Commit Graph

60 Commits

Author SHA1 Message Date
Ilya Shipitsin
102913e808 make cppcheck a bit happier:
[channels/printer/client/printer_cups.c:103]: (error) Resource leak: fp
[server/Mac/mf_event.c:195]: (error) Memory leak: event_queue
[server/shadow/shadow_capture.c:233]: (error) Memory leak: capture
[winpr/libwinpr/sspi/test/TestSchannel.c:440]: (error) Memory leak: lpTokenIn
[winpr/libwinpr/thread/argv.c:198]: (error) Memory leak: lpEscapedChars
[winpr/libwinpr/utils/sam.c:312]: (error) Memory leak: entry
2017-01-25 17:09:25 +05:00
Norbert Federa
f71b6b46e8 fix string format specifiers
- fixed invalid, missing or additional arguments
- removed all type casts from arguments
- added missing (void*) typecasts for %p arguments
- use inttypes defines where appropriate
2016-12-16 13:48:43 +01:00
Norbert Federa
e718fb324b fix race conditions, tests and some invalid return values
Since the current winpr implementation for overlapped operations is
incomplete and buggy, all affected functions will now fail if they are
called with a set FILE_FLAG_OVERLAPPED flag or a non-null pointer to
a OVERLAPPED structure.

winpr/nt:
- use proper one-time initialization on win32
- fix TestNtCreateFile
- fix broken/incomplete _RtlAnsiStringToUnicodeString
- unimplemented functions return appropriate error codes

winpr/pipe:
- improved TestPipeCreateNamedPipe
- rewrite the completely broken TestPipeCreateNamedPipeOverlapped test

rdtk:
- improve test and don't blindly return success

winpr/synch:
- fix race condition in TestSynchTimerQueue

winpr/ssspi:
- fix TestEnumerateSecurityPackages printf output
- fix TestQuerySecurityPackageInfo printf output

winpr/environment:
- fix GetEnvironmentStrings printf output

winpr/comm:
- unimplemented functions return appropriate error codes

winpr/io:
- unimplemented functions return appropriate error codes

winpr/thread:
- implement SwitchToThread() via sched_yield()
2016-06-01 16:26:26 +02:00
Bernhard Miklautz
9e8c6c99b6 First shot on fixing over linking
If a target is linked against libraries with cmake
(target_link_libraries) and the libraries are not marked as PRIVATE
they are "exported" and in case a other target is linked against this
target it is also linked against *all* (not private) libraries.

Without declaring private libraries PRIVATE a lot of over linking
(linking against unneeded libraries) was done.
2016-03-29 18:14:34 +02:00
Marc-André Moreau
4f769866d7 winpr: make clean non-OpenSSL build possible (without schannel, makecert) 2015-10-09 15:57:41 -04:00
Bernhard Miklautz
1cee185e3c hardening: check fread and fwrite return values 2015-06-26 20:38:30 +02:00
Bernhard Miklautz
06502e6a91 misc: integrate pull request feedback 2015-06-22 19:24:30 +02:00
David FORT
16d36e3083 A malloc() pass on WinPR
This patch treats remaining non-checked mallocs. And changes to calloc in places
where it makes sense
2015-06-22 19:10:00 +02:00
Bernhard Miklautz
bf73f4e4f1 Fix unchecked strdups
* add missing checks
* adapt function return values where necessary
* add initial test for settings
2015-06-22 19:09:59 +02:00
Norbert Federa
25fc866a58 Fix unchecked CreateThread calls and misc fixes 2015-05-05 13:55:48 +02:00
Bernhard Miklautz
850de59b55 winpr: add checks for *alloc
Add missing checks if memory allocation was successful. Also adapt
caller(s) when possible.
2015-04-08 11:34:37 +02:00
Armin Novak
b22b897389 Reformatted changed files. 2014-09-09 16:32:22 +02:00
Armin Novak
28ece6bb46 Replaced stdio logging with WLog 2014-09-09 16:31:46 +02:00
Bernhard Miklautz
6a49bcfe40 winpr: always build "monolitic"
winpr is now always build as single library.
The build option MONOLITHIC_BUILD doesn't influence this behavior anymore.

The only exception is winpr-makecert-tool which is still build as extra
library.

This obsoletes complex_libraries for winpr.
2014-07-10 11:10:58 +02:00
Marc-André Moreau
948d137426 libwinpr-sspi: add support for passing NTLMv2 hash 2014-06-18 16:02:13 -04:00
Marc-André Moreau
e272bc923e libwinpr-sspi: fix server-side NTLM authentication against NTLMv2 without key exchange 2014-06-18 14:42:35 -04:00
Marc-André Moreau
adbfcf53ea libwinpr-sspi: fix failing test 2014-06-10 18:09:51 -04:00
Marc-André Moreau
1b93dca6c0 libwinpr-sspi: add support for querying user+domain and setting NTLM hash 2014-06-10 16:38:16 -04:00
Marc-André Moreau
723e9a171b libwinpr-sspi: fix server-side NLA 2014-06-10 14:38:17 -04:00
Marc-André Moreau
8a343c3e6d libwinpr-sspi: fix memory leaks 2014-06-10 14:16:02 -04:00
Marc-André Moreau
a27c7d85ed libwinpr-sspi: patch some memory leaks 2014-06-10 08:40:04 -04:00
Marc-André Moreau
0ebc7e2ab4 libwinpr-sspi: add custom API for passing NTLM hashes and credentials dynamically 2014-06-09 15:25:00 -04:00
Marc-André Moreau
1c0ba4ca9a libwinpr-sspi: add tests for NTLM 2014-06-07 18:28:02 -04:00
Marc-André Moreau
a07f616895 libwinpr-sspi: improve link interface 2014-06-07 10:50:51 -04:00
Marc-André Moreau
a202fe4057 freerdp: fix several type related warnings 2014-05-08 18:02:02 -04:00
Marc-André Moreau
9bdfbcd556 wfreerdp: fix test build issues 2014-02-01 12:50:28 -05:00
Bernhard Miklautz
a56e3f259b winpr: disabled schannel test
not practicable for now since it requires local key setup
2013-11-15 16:19:49 +01:00
Marc-André Moreau
b70ecbbf62 libfreerdp-core: decouple initialization of rdpSettings from freerdp* instance 2013-10-12 18:20:25 -04:00
Marc-André Moreau
7dd95b9587 libwinpr-crypto: improve Schannel unit test 2013-10-11 04:01:07 -04:00
Bernhard Miklautz
6b1a414b36 winpr/sspi: disable test TestSchannel 2013-03-15 23:11:17 +01:00
Bernhard Miklautz
e8eb0d0b44 Fixed formating build warnings (-Wformat) 2013-03-15 20:03:48 +01:00
Marc-André Moreau
4e565e26b5 Merge branch 'master' of github.com:awakecoding/FreeRDP 2013-02-18 20:07:41 -05:00
Marc-André Moreau
01e8eb8204 libwinpr-sspi: complete Schannel handshake 2013-02-18 20:07:29 -05:00
Marc-André Moreau
801708297a libwinpr-rpc: fix windows build 2013-02-18 19:29:50 -05:00
Marc-André Moreau
49ee48e8d0 libfreerdp-primitives: code style cleanup 2013-01-19 15:16:28 -05:00
Marc-André Moreau
b868af322e libwinpr-sspi: fix Schannel TLS handshake 2013-01-10 17:12:27 -05:00
Marc-André Moreau
03ef822d0c libwinpr-sspi: add Schannel EncryptMessage/DecryptMessage tests 2013-01-10 16:28:56 -05:00
Marc-André Moreau
59084a09ba libwinpr-sspi: fix Schannel TLS handshake 2013-01-10 12:19:07 -05:00
Marc-André Moreau
d8949f5d8f libfreerdp-core: fix computing of test channel binding token 2013-01-08 21:56:28 -05:00
Marc-André Moreau
218773a04c Merge branch 'master' of github.com:awakecoding/FreeRDP 2013-01-06 16:42:59 -05:00
Marc-André Moreau
4cf0dc1004 libwinpr-sspi: improve attempted channel binding token computation 2013-01-06 16:05:20 -05:00
Marc-André Moreau
3b71138442 wfreerdp-server: fix build on Windows 7 2013-01-05 14:58:47 -05:00
Marc-André Moreau
609459f8a6 libwinpr-sspi: fix build on Linux 2013-01-05 12:35:24 -05:00
Marc-André Moreau
05ef57bb01 libwinpr-sspi: complete Schannel TLS handshake test 2013-01-04 13:43:44 -05:00
Marc-André Moreau
f8b364d696 libwinpr-sspi: add more Schannel tests 2013-01-04 12:16:55 -05:00
Marc-André Moreau
80daf6fb5c libwinpr-sspi: fix build on Linux 2013-01-03 11:35:08 -05:00
Marc-André Moreau
27084c4642 libwinpr-sspi: improve SSPI Schannel test 2013-01-03 11:13:13 -05:00
Marc-André Moreau
5240823124 libwinpr-sspi: fix build on Linux 2012-12-23 18:59:59 -05:00
Marc-André Moreau
a5aa8fc2cc libwinpr-sspi: improved Schannel test with fake client-server communication 2012-12-23 18:41:02 -05:00
Marc-André Moreau
85690a3ec7 libwinpr-sspi: improve Schannel QueryCredentialsAttributes stubs 2012-12-23 14:38:58 -05:00