Commit Graph

224 Commits

Author SHA1 Message Date
David FORT
a8fefae3a1 Harden the sound channel
This patch adds checks for the sound channel and plugins:

* checks for protocol bytes;
* checks for malloc/calloc;
* be more strict when interacting with sound plugin
2015-06-24 17:06:45 +02:00
Bernhard Miklautz
7624519453 oss: fix formating 2015-06-22 19:45:56 +02:00
Bernhard Miklautz
77927c213e android: fix misc compiler warnings
with gcc version arm-linux-androideabi-gcc (GCC) 4.8
2015-06-22 19:09:59 +02:00
ivan-83
e22a4461c7 rdpsnd oss remove unneded mem operations 2015-05-30 03:02:25 +03:00
ivan-83
d925f2f9fe rdpsnd: latency process 2015-05-30 02:22:18 +03:00
ivan-83
94a7abd2af + tsmf: OSS initial suppot (not work yet)
* tsmf: fix video playback on FreeBSD (proper shared object name)
* tsmf: renamed args: audio->sys, audio-dev->dev
* audin: OSS fix, now it work
* cmdline: add syntax help for /audin, /rdpsnd, /tsmf
* add debug messages
2015-05-27 22:54:13 +03:00
David FORT
29d372480a Take in account nfedera's review 2015-05-20 19:19:50 +02:00
David FORT
f8d6eb226c Fixed last VirtualChannelEntry 2015-05-19 13:56:48 +02:00
Hardening
f8120919af Add checks for some XXX_New and XXX_Add functions
Based on PR #2616
2015-05-18 11:28:00 +02:00
Norbert Federa
1eff1a345e free can handle NULL perfectly fine 2015-05-11 09:07:39 +02:00
Bryan Everly
8c75127a67 Necessary changes to get latest branch working on OpenBSD 5.6 2015-04-21 14:42:06 -04:00
Bernhard Miklautz
79de8168f9 Integrate feedback from pull request
* orders.c: remove ; at eol
* rdpdr_main.c: simplify error case
* rdpsnd_pulse.c: fix incorrect check
* rdpsnd_main.c: adapt return value according to documentation
* update.c: fix incorrect return values
2015-03-30 18:29:32 +02:00
Bernhard Miklautz
74c8400789 coding style fixes
Add missing space after if
2015-03-30 17:15:45 +02:00
Bernhard Miklautz
f469e069dc stream: Stream_Ensure*Capacity: change return type
Change the return type of Stream_Ensure*Capacity from void to BOOL to be
able to detect realloc problems easily. Otherwise the only way to detect
this was to check if the capacity after the call was >= the required
size.
In case Stream_Ensure*Capacity fails the old memory is still available
and need to freed outside.

This commit also adds checks to most calls of Stream_Ensure*Capacity to
check if the call was successful.
2015-03-30 16:33:48 +02:00
ivan-83
7b3a552988 + audin OSS support (un tested now)
+ add: COMMAND_LINE_IGN_UNKNOWN_KEYWORD flag for CommandLineParseArgumentsA to ignory unknown keys without fail
+ add: lot of WLog_DBG() in drdynvc, add function names in existing
* change: error text in rdpsnd OSS
* fix: dev in rdpsnd does not work
* fix/change: audio-dev renamed to dev and now work in audin
* fix dynamic channels now work again
2015-03-13 01:28:44 +03:00
ivan-83
0f3b639058 * OSS build fix on linux 2015-03-11 02:17:45 +03:00
ivan-83
e85dccc22a * remove OSS debug messages 2015-03-10 01:34:15 +03:00
ivan-83
4f8f84f33b + some files for OSS, missed from prev commit 2015-03-09 09:31:27 +03:00
ivan-83
fe9fab920e + add OSS support for rdpsnd 2015-03-09 09:23:29 +03:00
ivan-83
8d5825ee00 Fix poor sound quality with ALSA
and decrease "ALSA lib pcm.c:7339:(snd_pcm_recover) underrun occurred"
+ little code cleanup
2015-03-09 09:11:46 +03:00
Armin Novak
69afce34c7 Debug messages now use WLog_DBG instead of WLog_ERR. 2015-02-19 08:45:45 +01:00
Armin Novak
557e8bb938 Fixed variable initialisation and cleanup. 2015-01-20 12:31:21 +01:00
Armin Novak
cbf8b1cf01 Fixed resource cleanup locations.
Additional error checks and logging.
2015-01-20 11:53:12 +01:00
Armin Novak
54fa77a06a Prettiefied WLog messages. 2015-01-20 11:20:38 +01:00
Marc-André Moreau
27a8e50e60 channels: fix drdynvc, patch memory leaks 2014-12-27 15:20:29 -05:00
Marc-André Moreau
6c2ebb2b58 channels: redirection valgrind fixes 2014-12-27 13:50:50 -05:00
Marc-André Moreau
fdd2dc7601 freerdp: patch valgrind leaks, cleanup 2014-12-03 14:17:27 -05:00
Armin Novak
059374457d Removed library prefix override. 2014-09-17 11:27:11 +02:00
Armin Novak
b1e9ffb655 Using wlog for channel logging now.
Fixed compiler warnings and broken callback in urbdrc.
2014-09-15 08:48:46 +02:00
Bernhard Miklautz
0313ca3622 libfreerdp: always build "MONOLITHIC"
"libfreerdp" consisted of multiple (small) single libraries. If the cmake
option MONOLITHIC was used only one library was build combining all of
the libfreerdp-* libraries.
The only exceptions to this are libfreerdp-server and libfreerdp-client these
are build as separate libraries.

This commit obsoltes non-monolithic builds and makes monolithic builds
the default. The cmake option MONOLITHIC is also removed.
2014-09-12 00:19:53 +02:00
Armin Novak
784696c1cd Fixed missing includes and invalid replacement. 2014-08-11 09:38:08 +02:00
Armin Novak
66b8905ac6 Using special log defines for channels now. 2014-08-11 09:12:01 +02:00
Armin Novak
b252009d36 Replaced custom logging mechanism with WLog wrapper. 2014-08-07 16:51:49 +02:00
Bernhard Miklautz
6a49bcfe40 winpr: always build "monolitic"
winpr is now always build as single library.
The build option MONOLITHIC_BUILD doesn't influence this behavior anymore.

The only exception is winpr-makecert-tool which is still build as extra
library.

This obsoletes complex_libraries for winpr.
2014-07-10 11:10:58 +02:00
Marc-André Moreau
53639dea0b channels: reduce dependency on svc_plugin.h 2014-06-11 15:09:28 -04:00
Marc-André Moreau
784e9abd79 cmake: improve __FILE__ relative path hack 2014-04-21 14:42:24 -04:00
Benoit LeBlanc
27c753f80c Merge branch 'master' of git://github.com/awakecoding/FreeRDP 2014-03-19 11:53:10 -04:00
Marc-André Moreau
db1159f7b6 Merge pull request #1737 from zhangzl2013/sound-fix
Sound fix
2014-03-13 10:35:33 -04:00
Benoît LeBlanc
c6f235e1ee Merge branch 'master' of git://github.com/awakecoding/FreeRDP 2014-03-12 18:23:26 -04:00
Benoît LeBlanc
dde8d81f46 Removed WLOG traces for audio playback 2014-03-12 18:23:17 -04:00
Zhang Zhaolong
ffb53ba5e2 sound: cleanup invalid code. 2014-03-12 17:16:06 +08:00
Zhang Zhaolong
9cf6d1d9ae sound: fix long latency. 2014-03-12 17:02:45 +08:00
Zhang Zhaolong
69c926eb37 sound: fix random volume on connection. 2014-03-12 15:04:33 +08:00
Zhang Zhaolong
69296ce3bd wfreerdp: build fix. 2014-03-04 13:54:25 +08:00
Marc-André Moreau
6695873394 libwinpr-wtsapi: fix multiple inconsistencies with original wtsapi headers 2014-02-28 14:49:57 -05:00
Marc-André Moreau
82b922a70d channels: rename custom CHANNEL_ENTRY_POINTS_EX to CHANNEL_ENTRY_POINTS_FREERDP to fix conflict 2014-02-16 17:38:59 -05:00
Marc-André Moreau
b833073f57 libfreerdp-core: make client virtual channel API prototypes converge towards original API 2014-02-16 17:27:36 -05:00
Marc-André Moreau
cdcd290c44 wfreerdp: fix most build warnings 2014-02-10 22:12:13 -05:00
Marc-André Moreau
5ff847a6e6 wfreerdp: fix multiple warnings 2014-02-10 01:06:11 -05:00
Marc-André Moreau
6acd0ed84a channels/rdpsnd: improve winmm rdpsnd implementation 2013-12-15 15:59:51 -05:00
Marc-André Moreau
4356eb5572 Merge branch 'audio' of github.com:FreeRDP/FreeRDP
Conflicts:
	libfreerdp/codec/audio.c
2013-12-11 17:24:00 -05:00
Marc-André Moreau
f890771871 channels/rdpsnd: fix audio duration computation for GSM610 format 2013-12-11 17:21:29 -05:00
Marc-André Moreau
95a452e77f channels/rdpsnd: start using AudioConverter 2013-12-09 17:34:23 -05:00
Marc-André Moreau
c230e872af channels/rdpsnd: start refactoring mac audio code 2013-12-09 16:02:42 -05:00
Marc-André Moreau
76c842285d channels/rdpsnd: initial attempt at adding GSM610 support 2013-11-22 12:11:39 -05:00
Marc-André Moreau
c1fa455c30 channels/rdpsnd: add wlog debug output 2013-11-19 15:31:38 -05:00
Marc-André Moreau
c03a2e5497 channels/rdpsnd: add option for configuring audio quality mode 2013-11-19 14:29:31 -05:00
Armin Novak
23b5845660 Fixed crash due to duplicate resource cleanup (MessagePipe freed in channel) 2013-11-12 10:22:04 +01:00
Marc-André Moreau
3c44ff9c83 channels/rdpsnd: fix bug in rdpsnd and rdpdr deinitialization 2013-11-06 14:31:33 -05:00
Marc-André Moreau
5406ebd5d8 channels/drive: refactoring 2013-11-03 19:10:33 -05:00
Marc-André Moreau
37450da55d cmake: fix exporting of targets on pre-2.8.11 2013-10-29 14:47:40 -04:00
Marc-André Moreau
55565e056c freerdp: export targets 2013-10-28 23:06:39 -04:00
Marc-André Moreau
f35d45488c channels/rdpsnd: make use of MessagePipe 2013-10-19 16:42:42 -04:00
Marc-André Moreau
bd64e616de channels/rdpsnd: decouple rdpsnd from svc_plugin 2013-10-19 16:20:31 -04:00
Marc-André Moreau
dbbb364caf channels: export audin and rdpsnd subsystem interface 2013-10-19 12:38:31 -04:00
Armin Novak
27566ce566 Fixed invalid return. 2013-10-01 11:19:16 +02:00
Armin Novak
8ccf7f8ca2 Fixed queue initialization and overflow checks. 2013-09-30 10:11:54 +02:00
Armin Novak
95468dcf17 Modified rdpsnd opensles backend, now just filling queue and not waiting
for completion of playback, results in better sound quality.
2013-09-27 15:55:14 +02:00
Armin Novak
2269cbe155 Merge branch 'master' of https://github.com/FreeRDP/FreeRDP into android_sound 2013-09-27 11:46:48 +02:00
Armin Novak
8139c4894b Cleaned up rdpsnd for android, prepared volume control. 2013-09-27 11:45:53 +02:00
Armin Novak
2839f5d755 Renamed plugins from 'opensl_es' to 'opensles' 2013-09-23 12:38:05 +02:00
Armin Novak
d60e74e622 Removed obsolete audiotrack implementation. 2013-09-20 12:48:35 +02:00
Armin Novak
1c506a3724 Fixed CommandLinePArseArgumentsA return value check, only abort if negative. 2013-09-20 10:11:05 +02:00
Armin Novak
01b6d5d229 Fixed compiler warnings. 2013-09-20 10:08:56 +02:00
Armin Novak
489e375f7b Fixed potential memory leak, now always calling WaveConfirm after playing
a sample.
2013-09-20 09:19:11 +02:00
Armin Novak
3f62a9176c Added audiotrack support to rdpsnd. 2013-09-19 12:01:14 +02:00
Armin Novak
4748d0e4dd Merged back audiotrack support from felix lang. 2013-09-19 12:00:49 +02:00
Armin Novak
403a9fff62 Fixed compiler warnings. 2013-09-19 10:34:18 +02:00
Armin Novak
64454faf71 Fixed double free of wave buffer. 2013-09-19 10:23:28 +02:00
Marc-André Moreau
518995a05e freerdp: merge with master 2013-09-16 17:10:27 -04:00
Armin Novak
6ac0b10158 Removed buffer copy, still fixes memory leak. 2013-09-05 12:14:34 +02:00
Armin Novak
854aa3fcfa Fixed memory leak. 2013-09-05 12:14:34 +02:00
Armin Novak
e5c138a5b9 Fixed various memory leaks, allocation size issues and API misuse
warnings shown by clang as well as some compiler warnings.
2013-09-05 12:14:34 +02:00
Armin Novak
a3b531c036 Fixed issues found with clang-analyzer 2013-09-05 12:14:33 +02:00
Marc-André Moreau
7edfe66274 freerdp: various missing link dependencies and symbol exports 2013-09-03 21:48:26 -04:00
Mike McDonald
3e1f72a011 Fixed minor formatting issues 2013-08-28 21:37:45 -04:00
Mike McDonald
cfe90ae829 Added RDPSND device plugin for iOS 2013-08-28 21:03:34 -04:00
Mike McDonald
772f738c47 Added RDPSND device plugin for iOS 2013-08-28 21:02:48 -04:00
Marc-André Moreau
e45f149db4 channels/rdpsnd: fix potential uninitialized value 2013-05-25 15:49:44 -04:00
Marc-André Moreau
e9d362b58e channels/printer: fix printer redirection and test with cups-pdf 2013-05-20 15:50:22 -04:00
Marc-André Moreau
fdf3ddcf9e freerdp: purge deprecated stream utils 2013-05-08 17:48:30 -04:00
Marc-André Moreau
fd230443c5 freerdp: purge old stream utils 2013-05-08 16:27:21 -04:00
Marc-André Moreau
5b92413843 freerdp: purge deprecated stream utils 2013-05-08 16:09:16 -04:00
Marc-André Moreau
51715636a5 freerdp: remove some deprecated stream utils 2013-04-29 22:35:15 -04:00
Marc-André Moreau
d187becc28 freerdp: merge with master 2013-03-28 21:20:36 -04:00
Marc-André Moreau
3417a3aab5 freerdp: merge RDP_EVENT type with wMessage 2013-03-28 21:13:56 -04:00
Hardening
7701c9d934 Replace printf(...) by fprintf(stderr, ...) 2013-03-28 23:06:34 +01:00
Marc-André Moreau
8c8a82c31f libfreerdp-utils: purge old STREAM utils 2013-03-21 16:45:25 -04:00
Marc-André Moreau
a8201b0d1b libwinpr-utils: combine old and new stream utils 2013-03-21 15:19:33 -04:00
Marc-André Moreau
aec86e1da8 wfreerdp: start splitting CLI from client core 2013-03-18 20:12:51 -04:00