Kobi Mizrachi
3f9e6ca978
rdpgfx: surface_to_scaled_window: fix pdu type
2019-12-12 11:10:44 +01:00
Kobi Mizrachi
7af2483626
rail: keep extendedSpiSupported flag synced
2019-12-12 11:10:44 +01:00
Kobi Mizrachi
5565b366b0
rail: stream size checks and rail_read_sysparam_order fixes
2019-12-12 11:10:44 +01:00
Armin Novak
2d3d882de9
Stream size checks for rail_write_sysparam_order
...
Ensure the stream is large enough to hold the data
in rail_write_sysparam_order, rail_write_high_contrast and
rail_write_filterkeys.
2019-12-12 11:10:44 +01:00
Mati Shabtay
4dacb57f6f
rail server: implement channel code for rail server
...
* Split common functionality from client code
* Clean up client code and use proper defines for constants
* Implements the channel code to read/write server side
messages.
2019-12-12 11:10:44 +01:00
ajlex140
2f2f4f91d8
reply with empty irp package with error code, if irp device is unavailable
2019-12-09 11:43:02 +01:00
Armin Novak
da6ff1ca65
Removed some unnecessary casts.
2019-12-05 11:40:56 +01:00
Armin Novak
6e6dfc3e2a
Removed rdpsnd client thread
...
The thread used to process audio data is not really required
and just produces overhead.
2019-12-05 11:40:56 +01:00
Martin Fleisz
71feb974ac
Merge pull request #5739 from akallabeth/improve_function_hiding
...
Improve function hiding
2019-12-02 11:31:35 +01:00
Armin Novak
7c243da6e1
Remove symbols exported by accident.
2019-12-02 10:57:31 +01:00
Martin Fleisz
4d8a4d39ba
Merge pull request #5748 from akallabeth/mac_sound_no_mic
...
Fix #5747 : Only open output device in rdpsnd for mac.
2019-11-29 08:19:24 +01:00
David Fort
5e6775ce95
winpr: fix anonymous enum members and menbers without a size
2019-11-25 13:39:31 +01:00
Armin Novak
fd968cdf84
Fixed dead store warning.
2019-11-25 10:32:55 +01:00
Armin Novak
2691532061
Fixed const correctness of encomsp functions.
2019-11-25 09:39:21 +01:00
Armin Novak
65ebda20dd
Fix #5747 : Only open output device in rdpsnd for mac.
2019-11-25 08:27:57 +01:00
Armin Novak
c4a141cd8a
Fixed some scanbuild warnings.
2019-11-22 11:47:16 +01:00
Armin Novak
0927d7aa50
Rewrite of urbdrc channel.
...
* Fix command line parsing
* Properly handle channel creation/destruction
* Use wStream API for parsing
2019-11-22 10:56:21 +01:00
David Fort
d7e510016a
Merge pull request #5736 from akallabeth/makecert_cleanups
...
Cleaned up code for makecert.
2019-11-20 23:26:31 +01:00
Armin Novak
a5bebd3c65
Fixed scanbuild warnings.
2019-11-20 09:17:08 +01:00
Armin Novak
f9b3f270fe
Fixed path NULL checks.
2019-11-19 10:48:25 +01:00
Armin Novak
4c5bfcc235
Fixed #5727 : drive_process_irp_create set path to NULL if not provided.
2019-11-18 15:25:18 +01:00
Armin Novak
9f3adf10f8
Fixed #5727 : use getmntent to read /proc/mounts
2019-11-18 15:25:18 +01:00
Armin Novak
57a57a917a
Fixed #5727 : Remove forbidden symbols from drive name
2019-11-18 14:31:46 +01:00
Bernhard Miklautz
6bf94972b1
Merge pull request #5715 from akallabeth/table_gen
...
Fixed #5713 : Use proper types to generate tables.c where possible.
2019-11-14 15:01:07 +01:00
Armin Novak
b3630d12e5
Fixed #5713 : Use proper types to generate tables.c where possible.
...
Use the correct type for function arguments of DVCPluginEntry type
and void* for type DeviceServiceEntry when generating tables.c
2019-11-14 11:42:50 +01:00
Bernhard Miklautz
f95e347e9c
fix [build]: don't export rdp2tcp as cmake target
...
rdp2tcp was wrongly exposed as cmake target. This could lead to errors
like the following when the FreeRDP2 cmake file was required:
CMake Error at ../lib/cmake/FreeRDP2/FreeRDPTargets.cmake:73 (message):
The imported target "rdp2tcp-client" references the file
".../lib/freerdp2/librdp2tcp-client.a"
but this file does not exist. Possible reasons include:
* The file was deleted, renamed, or moved to another location.
* An install or uninstall procedure did not complete successfully.
* The installation package was faulty and contained
".../lib/cmake/FreeRDP2/FreeRDPTargets.cmake"
but not all the files it references.
2019-11-13 16:11:46 +01:00
Armin Novak
17c7144cb2
Fixed cleanup of remdesk in CHANNEL_EVENT_WRITE_COMPLETE
2019-11-13 11:42:27 +01:00
kubistika
511f89cd99
cliprdr: common: fix validation of file contents request pdu
2019-11-12 12:45:01 +01:00
Armin Novak
153639624b
Fixed NULL checks for strnlen calls, limit static channel name length.
...
As reported by @metametaclass in #5687 check the strings for NULL before
using strnlen. Also extend the same checks to static channel loading.
2019-11-07 10:53:55 +01:00
Armin Novak
72ca88f49c
Reformatted to new style
2019-11-07 10:53:54 +01:00
Armin Novak
2790866c12
Added CHANNEL_EVENT_WRITE_CANCELLED for remdesk channel
2019-11-06 13:01:43 +01:00
Armin Novak
75ed12f1f0
Fixed userdata pointer and CHANNEL_EVENT_WRITE_CANCELLED message.
2019-11-06 13:01:43 +01:00
Armin Novak
1bcb799560
Listen to CHANNEL_EVENT_WRITE_CANCELLED and emit if queue is cleared.
2019-11-06 13:01:43 +01:00
Armin Novak
1b78b59926
Fixed #4809 : Properly process CHANNEL_EVENT_WRITE_COMPLETE
2019-11-06 13:01:43 +01:00
Armin Novak
09d14a2462
Fixed VirtualChannelWriteEx error case leaks.
2019-11-06 13:01:43 +01:00
Martin Fleisz
bc39b32d20
Merge pull request #5685 from akallabeth/multi_instance_arg_parse
...
COMMAND_LINE_ARGUMENT structs contain parser results, use one per instance
2019-11-06 09:09:22 +01:00
Armin Novak
993b79f1bd
Removed strcpy use.
2019-10-29 11:58:43 +01:00
Armin Novak
f01e042211
Code cleanups (strlen, casts, size_t, ...)
2019-10-29 11:58:43 +01:00
Martin Fleisz
9b1626ee6e
Merge pull request #5673 from akallabeth/audin_format_leak_fix
...
Fixed memory leak when freeing up audin formats.
2019-10-28 15:19:30 +01:00
Armin Novak
0c87eaee4d
COMMAND_LINE_ARGUMENT structs contain parser results, use one per instance
...
Remove the old global structs as the parser modifies them. When using
multiple instances in the same process space this could break parsing.
2019-10-28 13:30:05 +01:00
Martin Fleisz
9e32899347
Merge pull request #5676 from akallabeth/hotplug_leak_fix
...
Hotplug leak fix
2019-10-28 13:06:36 +01:00
Armin Novak
da48b4eb8d
Made disp channel internal functions static.
2019-10-28 09:31:50 +01:00
Armin Novak
64f64cd035
devman_load_device_service device argument can be const.
2019-10-24 15:04:48 +02:00
kubistika
bf2e1a33d0
channels: rdpgfx: export API to create rdpgfx client
2019-10-24 12:19:31 +02:00
Armin Novak
30c21279cb
Fixed memory leak when freeing up audin formats.
2019-10-24 12:18:24 +02:00
AzureusNation
4955a0e5b8
Fixes hub was not found! error
...
Again as with auto usb detection strtol needs to use base 10 and force to use base 10 else the conversion does not work correctly.
2019-10-23 09:56:23 +02:00
AzureusNation
7d6a10aaff
Fixes Auto USB Redirection
...
Base 0 does not work when converting the string to long int. This ends up not showing the correct device id and sometimes the wrong bus id. By changing it to base 10 conversion instead of base 0 this fixes the issue of auto redirect usb devices.
2019-10-23 09:56:23 +02:00
asapelkin
82eadad4a4
Fix some static analizer warnings
2019-10-22 15:39:54 +02:00
kubistika
5cc5aa98ec
channels: cliprdr: client: fix leak in cliprdr_packet_send
2019-10-18 14:20:26 +02:00
kubistika
d75c5eec04
channels: cliprdr: improved common cliprdr api
2019-10-18 14:20:26 +02:00
kubistika
d2f73136d3
channels: cliprdr: reformat cliprdr_common.c
2019-10-18 14:20:26 +02:00
kubistika
345cc2a2f5
channels: cliprdr: get rid of duplicated server and client code
2019-10-18 14:20:26 +02:00
Armin Novak
59b4988f56
Fixed compilation warnings.
2019-10-16 14:54:05 +02:00
Martin Fleisz
9a33a82fb7
Merge pull request #5634 from akallabeth/error_code_update
...
Added missing error codes.
2019-10-03 08:45:44 +02:00
Armin Novak
0ffcba9350
Fix #5635 : Silence double WITH_CUPS definition.
2019-10-02 16:24:12 +02:00
Armin Novak
134da33eb0
Fixed format string.
2019-10-02 16:01:36 +02:00
Martin Fleisz
583045e2e5
rail: Update to latest spec version 28.0
2019-10-02 14:51:45 +02:00
Martin Fleisz
20c585bd18
rdpdr: Fix error code reporting for create PDUs
2019-10-01 14:34:36 +02:00
akallabeth
d5d3ebee60
Fix #5606 : Fall back to loading default printer backend.
2019-09-22 16:22:41 +02:00
Armin Novak
5e9f454256
Use stat instead of lstat to iterate /Volumes
...
Some entries are symbolic links, so follow them and check the link
target for being a directory.
2019-09-12 14:35:01 +02:00
Armin Novak
6f82ab6204
Hotplugging only for drive redirection.
2019-09-12 11:14:39 +02:00
Armin Novak
88c654ee1d
Modified printer backend to allow dynamic backends.
2019-09-06 09:28:29 +02:00
Armin Novak
2670d83cdd
freerdp_channels_load_static_addin_entry pszSubsystem empty string returns the default backend.
2019-09-04 17:15:51 +02:00
Armin Novak
15bc118d78
Names of services are now const.
2019-09-04 15:48:34 +02:00
Armin Novak
3ce1dc1972
Fix some warnings on mac os
2019-09-03 13:47:13 +02:00
Armin Novak
1b9e01509d
Refactored winmm backend
...
Using CALLBACK_FUNCTION again, but protect with semaphore to avoid closing
the device while there are still buffers to be played.
2019-09-03 15:11:18 +02:00
Armin Novak
208fbabfde
Only close local audio device if rdpsnd thread closes or output format changes.
...
Windows 7 and other older systems send one close PDU after another.
This distorts audio during setup and teardown of local sound devices.
2019-09-03 15:11:18 +02:00
Armin Novak
48f35972c8
Fixed limit check for wave confirm pdu timestamp.
2019-09-03 15:11:18 +02:00
Armin Novak
83b80f64af
Fixed uninitialized variable warning.
2019-09-03 08:55:29 +02:00
Armin Novak
f93d625cde
Use GetTickCount64 instead of GetTickCountPrecise.
2019-09-02 15:46:36 +02:00
Armin Novak
12b0b9ea28
Do not use named events, they are global!
2019-09-02 15:28:31 +02:00
Armin Novak
40964301df
Use CALLBACK_EVENT for waveOutOpen to play synchronously.
2019-09-02 15:11:54 +02:00
Martin Fleisz
29f914f178
Merge pull request #5541 from akallabeth/rdp_file_full_drivestoredirect_parsing
...
Rdp file full drivestoredirect parsing
2019-08-30 11:29:06 +02:00
kubistika
265e0848ed
rdpsnd: subsystems: Add proxy subsystem
2019-08-29 14:39:17 +02:00
kubistika
faa833f97a
rdpsnd: client: add rdpContext getter
2019-08-29 14:39:17 +02:00
Armin Novak
fdf1715213
Unified DriveStoreRedirect parsing.
2019-08-23 12:06:21 +02:00
Armin Novak
935ed36e68
Add dynamicDrives hotplug option.
2019-08-23 10:27:01 +02:00
Armin Novak
52af56d956
Added rdpsnd latency calculation.
2019-08-22 10:11:26 +02:00
Kyle Evans
d796920f8f
(FreeBSD) Build fixes for urbdrc
2019-08-19 16:57:56 +02:00
Armin Novak
c1d98d7e0a
Proper parsing of clipboard capability sets.
2019-08-19 09:30:40 +02:00
Armin Novak
74cffef053
Clipboard server callback arguments const
2019-08-19 09:30:40 +02:00
kubistika
f429275f86
channels: cliprdr: server: add autoInitializationSequence
2019-08-19 09:30:40 +02:00
kubistika
cf474bdb74
channels: cliprdr: server: call ClientCapabilities callback
2019-08-19 09:30:40 +02:00
kubistika
6cebbc2a16
channels: cliprdr: add lastRequestedFormatId
...
This one is for proxy use. The proxy must know what format is requested by the other side
of the connection, for determining if the message should be passed
or ignore (for example, if we want to allow only text, the proxy must
verify that the requested format received in Format Data Request PDU is
a text format.
2019-08-19 09:30:40 +02:00
Martin Fleisz
30c0127a29
Merge pull request #5510 from akallabeth/mac_realtime_sound
...
Mac realtime sound
2019-08-14 12:54:54 +02:00
Armin Novak
18e4245791
Added proper latency estimation for winmm sound backend.
2019-08-13 10:55:12 +02:00
Armin Novak
23069d1fe2
Convert input PCM to float format.
2019-08-12 08:13:43 +02:00
Armin Novak
5ffe2eed4e
Mostly working AVAudio backend.
2019-08-02 14:00:32 +02:00
Bernhard Miklautz
a311075202
fix [channels/smartcard]: fix StatusW_Call
...
According to 2.2.2.18 Status_Call cbAtrLen is unused an must be ignored
upon receipt.
2019-07-30 09:48:47 +02:00
Martin Fleisz
445764100b
Merge pull request #5396 from widgetii/master
...
Artur Zaprzala's rdp2tcp channel driver
2019-07-09 16:17:29 +02:00
Martin Fleisz
b80a26f82c
rail: Fixes incorrect setting of TS_RAIL_EXEC_FLAG_FILE
...
The TS_RAIL_EXEC_FLAG should only be set if ExeOrFile refers to a file
path. If we don't supply a published app name (using ||) but the name of
an application (i.e. notepad.exe) this flag was incorrectly set causing
an remote app execution error (error 5 - file not found).
2019-07-09 08:21:45 +02:00
Dmitry Ilyin
cb235debf5
PR fixes
2019-06-25 11:52:22 +03:00
Armin Novak
14c99ac061
Patch from #5436 : fix input handling with gstreamer and vaapisink
2019-06-18 13:43:44 +02:00
David Fort
2da425aa03
Merge pull request #5424 from kubistika/rdpgfx
...
rdpgfx: CacheImportOffer implementation
2019-06-13 11:35:15 +02:00
Kobi
d9366df448
RDPEDISP server side implementation ( #5414 )
...
* libfreerdp: Add RDPEDISP server implementation
* server/proxy: Add RDPEDISP support
2019-06-11 16:13:42 +02:00
kubistika
bf618fb929
rdpgfx/client: Update gfx->UnacknowlegedFrame correctly
2019-06-06 10:24:27 +03:00
kubistika
49e7c5ddc0
rdpgfx/server: Fix formatting: rdpgfx_recv_cache_import_offer_pdu
2019-06-06 07:53:34 +03:00
kubistika
bf97d3e041
rdpgfx/client: Expose QoeFrameAck
2019-06-06 07:53:34 +03:00
kubistika
98e09af2ff
rdpgfx/client: Implement CacheImportOffer PDU
2019-06-06 07:53:34 +03:00
kubistika
e2eeb9f870
rdpgfx: Add WITH_DEBUG_RDPGFX option
2019-06-04 10:29:05 +03:00