mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[proxy,modules] fix integer narrow

Browse Source
This commit is contained in:
akallabeth 2024-09-25 03:09:12 +02:00
parent 10bb42e4d8
commit f55a1e2bc3
No known key found for this signature in database
GPG Key ID: A49454A3FC909FD5
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
server/proxy/modules/dyn-channel-dump/dyn-channel-dump.cpp
View File

@ -24,6 +24,7 @@
#include <fstream> #include <fstream>
#include <iostream> #include <iostream>
#include <regex> #include <regex>
#include <limits>
#include <utility> #include <utility>
#include <vector> #include <vector>
#include <sstream> #include <sstream>
@ -332,7 +333,13 @@ static BOOL dump_dyn_channel_intercept(proxyPlugin* plugin, proxyData* pdata, vo
WLog_ERR(TAG, "Could not write to stream"); WLog_ERR(TAG, "Could not write to stream");
return FALSE; return FALSE;
} }
stream.write(buffer, Stream_Length(data->data)); const auto s = Stream_Length(data->data);
if (s > std::numeric_limits<std::streamsize>::max())
{
WLog_ERR(TAG, "Stream length %" PRIuz " exceeds std::streamsize::max", s);
return FALSE;
}
stream.write(buffer, static_cast<std::streamsize>(s));
if (stream.fail()) if (stream.fail())
{ {
WLog_ERR(TAG, "Could not write to stream"); WLog_ERR(TAG, "Could not write to stream");