mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libfreerdp/core: transport_write unchecked parameters

Browse Source 
transport_write did not check if transport or bio are
set. The transport read checks it. In using fastpath
and for example a mouse input is sent, the transport
is never checked and can cause a segfault.
This commit is contained in:
Martin Haimberger 2016-08-22 02:17:11 -07:00
parent 5b2455f314
commit e9e0764ace
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libfreerdp/core/transport.c
View File

@ -657,6 +657,15 @@ int transport_write(rdpTransport* transport, wStream* s)
int status = -1; int status = -1;
int writtenlength = 0; int writtenlength = 0;
if (!transport)
return -1;
if (!transport->frontBio)
{
transport->layer = TRANSPORT_LAYER_CLOSED;
return -1;
}
EnterCriticalSection(&(transport->WriteLock)); EnterCriticalSection(&(transport->WriteLock));
length = Stream_GetPosition(s); length = Stream_GetPosition(s);