mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[core,redirection] fix length field of Server Redirection Packet

Browse Source 
The length had more bytes than the RDP_SERVER_REDIRECTION_PACKET
structure because it was counting bytes before the struct.

Using a start variable from the beginnig of sending the structure fixes
it.
This commit is contained in:
Joan Torres 2023-01-17 16:53:51 +01:00 committed by akallabeth
parent 9b675bd400
commit e365ab443c
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libfreerdp/core/redirection.c
View File

@ -645,8 +645,9 @@ BOOL rdp_write_enhanced_security_redirection_packet(wStream* s, const rdpRedirec
goto fail; goto fail;
Stream_Write_UINT16(s, 0); Stream_Write_UINT16(s, 0);
Stream_Write_UINT16(s, SEC_REDIRECTION_PKT);
const size_t start = Stream_GetPosition(s);
Stream_Write_UINT16(s, SEC_REDIRECTION_PKT);
const size_t lengthOffset = Stream_GetPosition(s); const size_t lengthOffset = Stream_GetPosition(s);
Stream_Seek_UINT16(s); /* placeholder for length */ Stream_Seek_UINT16(s); /* placeholder for length */
@ -758,10 +759,10 @@ BOOL rdp_write_enhanced_security_redirection_packet(wStream* s, const rdpRedirec
goto fail; goto fail;
Stream_Zero(s, 8); Stream_Zero(s, 8);
const size_t length = Stream_GetPosition(s); const size_t end = Stream_GetPosition(s);
Stream_SetPosition(s, lengthOffset); Stream_SetPosition(s, lengthOffset);
Stream_Write_UINT16(s, (UINT16)length); Stream_Write_UINT16(s, (UINT16)(end - start));
Stream_SetPosition(s, length); Stream_SetPosition(s, end);
rc = TRUE; rc = TRUE;
fail: fail: