mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed use after free

Browse Source
This commit is contained in:
Armin Novak 2022-04-27 16:07:12 +02:00 committed by akallabeth
parent fb90ac280a
commit dfe89737a0
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libfreerdp/core/tscredentials.c
View File

@ -1,6 +1,6 @@
/* ============================================================================================================ /* ============================================================================================================
* this file has been generated using * this file has been generated using
* tools/asn_parser_generator.py --input=libfreerdp/core/credssp.asn1 --output-kind=impls * ./tools/asn_parser_generator.py --input=libfreerdp/core/credssp.asn1 --output-kind=impls
* --output=libfreerdp/core/tscredentials.c * --output=libfreerdp/core/tscredentials.c
* *
* /!\ If you want to modify this file you'd probably better change asn_parser_generator.py or the * /!\ If you want to modify this file you'd probably better change asn_parser_generator.py or the
@ -844,7 +844,9 @@ BOOL ber_read_nla_TSRemoteGuardPackageCred_array(wStream* s, TSRemoteGuardPackag
free(retItems); free(retItems);
return FALSE; return FALSE;
} }
retItems = tmpRet;
retItems = tmpRet;
memcpy(&retItems[ret], item, sizeof(*item)); memcpy(&retItems[ret], item, sizeof(*item));
free(item); free(item);
ret++; ret++;

7
libfreerdp/core/tscredentials.h
View File

@ -1,9 +1,10 @@
/* ============================================================================================================ /* ============================================================================================================
* this file has been generated using * this file has been generated using
* tools/asn_parser_generator.py --input=libfreerdp/core/credssp.asn1 --output-kind=headers --output=libfreerdp/core/tscredentials.h * ./tools/asn_parser_generator.py --input=libfreerdp/core/credssp.asn1 --output-kind=headers
* --output=libfreerdp/core/tscredentials.h
* *
* /!\ If you want to modify this file you'd probably better change asn_parser_generator.py or the corresponding ASN1 * /!\ If you want to modify this file you'd probably better change asn_parser_generator.py or the
* definition file * corresponding ASN1 definition file
* *
* ============================================================================================================ * ============================================================================================================
*/ */

1
tools/asn_parser_generator.py
View File

@ -520,6 +520,7 @@ BOOL ber_read_{prefix}{defName}_array(wStream* s, {defName}_t** pitems, size_t*
free(retItems); free(retItems);
return FALSE; return FALSE;
}} }}
retItems = tmpRet;
memcpy(&retItems[ret], item, sizeof(*item)); memcpy(&retItems[ret], item, sizeof(*item));
free(item); free(item);