mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core/capabilities: remove misplaced/useless code

Browse Source 
Commit 0357a38e31 has added some code
without any effect.
That commit added code to rdp_read_capability_sets() to check if
CAPSET_TYPE_MULTI_FRAGMENT_UPDATE was not received which caused
settings->MultifragMaxRequestSize to be set to 0.

- this was done in the wrong place because we do these kind
  of checks in rdp_recv_confirm_active() by consulting the
  variable settings->ReceivedCapabilities[]
- the code had no effect at all because MultifragMaxRequestSize gets
  set to FASTPATH_FRAGMENT_SAFE_SIZE in rdp_recv_confirm_active()
  if the CAPSET_TYPE_MULTI_FRAGMENT_UPDATE was not received.
This commit is contained in:
Norbert Federa 2015-02-02 18:25:10 +01:00
parent ee17750633
commit dd9f15450a
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libfreerdp/core/capabilities.c
View File

@ -3309,8 +3309,6 @@ BOOL rdp_read_capability_sets(wStream* s, rdpSettings* settings, UINT16 numberCa
UINT16 length;
BYTE *bm, *em;
BOOL foundMultifragmentUpdate = FALSE;
Stream_GetPointer(s, mark);
count = numberCapabilities;
@ -3457,7 +3455,6 @@ BOOL rdp_read_capability_sets(wStream* s, rdpSettings* settings, UINT16 numberCa
case CAPSET_TYPE_MULTI_FRAGMENT_UPDATE:
if (!rdp_read_multifragment_update_capability_set(s, length, settings))
return FALSE;
foundMultifragmentUpdate = TRUE;
break;
case CAPSET_TYPE_LARGE_POINTER:
@ -3506,15 +3503,6 @@ BOOL rdp_read_capability_sets(wStream* s, rdpSettings* settings, UINT16 numberCa
count-numberCapabilities, count);
}
/**
* If we never received a multifragment update capability set,
* then the peer doesn't support fragmentation.
*/
if (!foundMultifragmentUpdate)
{
settings->MultifragMaxRequestSize = 0;
}
#ifdef WITH_DEBUG_CAPABILITIES
Stream_GetPointer(s, em);
Stream_SetPointer(s, mark);