mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xfreerdp: fix xf_GetWindowProperty

Browse Source 
xf_GetWindowProperty should return False if the specified property does not exist.
It is not sufficient to simply check for the return value of XGetWindowProperty.
XGetWindowProperty also returns Success if the specified property does not exist.
However, it will return "None" to the actual_type_return parameter in that case.
This change fixes several crashes with some (exotic) window managers.
This commit is contained in:
Norbert Federa 2011-10-17 15:39:06 +02:00
parent 0d6c6b3bd0
commit c83038b4b3
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
client/X11/xf_window.c
View File

@ -95,6 +95,12 @@ boolean xf_GetWindowProperty(xfInfo* xfi, Window window, Atom property, int leng
if (status != Success)
return False;
if (actual_type == None)
{
DEBUG_WARN("Property %lu does not exist", property);
return False;
}
return True;
}