From c2819a00c93d455b3711f56d0f1036f8c562dfd3 Mon Sep 17 00:00:00 2001 From: Martin Fleisz Date: Wed, 8 Sep 2021 13:46:42 +0200 Subject: [PATCH] nla: Remove incorrect check when using NLA with a NULL identity When using NLA with a NULL identity (in AcquireCredentialsHandle) on Windows the client sends the first NLA package with cbBuffer set to 0. In that case the client currently incorrectly kills the connection. With this PR the check is removed and the client correctly connects to the server. --- libfreerdp/core/nla.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libfreerdp/core/nla.c b/libfreerdp/core/nla.c index 75cd25e4b..2d6485613 100644 --- a/libfreerdp/core/nla.c +++ b/libfreerdp/core/nla.c @@ -733,11 +733,6 @@ static BOOL nla_client_send_token(rdpNla* nla, SecBufferDesc* token) } buffer = token->pBuffers; - if (buffer->cbBuffer < 1) - { - WLog_ERR(TAG, "[%s] token->pBuffers[0].cbBuffer=%" PRIu32, __FUNCTION__, buffer->cbBuffer); - goto fail; - } if (!nla_sec_buffer_alloc_from_buffer(&nla->negoToken, &token->pBuffers[0], 0)) goto fail;