mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[sysconf] _SC_GETPW_R_SIZE_MAX return checks

Browse Source 
fix possible overflow with value returned from sysconf(_SC_GETPW_R_SIZE_MAX)
This commit is contained in:
Armin Novak 2024-10-23 10:33:17 +02:00
parent ae5f655f12
commit a84b303c23
No known key found for this signature in database
GPG Key ID: 2CF4A2D2D3D72105
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
winpr/libwinpr/shell/shell.c
View File

@ -59,11 +59,11 @@ BOOL GetUserProfileDirectoryA(HANDLE hToken, LPSTR lpProfileDir, LPDWORD lpcchSi
}
long buflen = sysconf(_SC_GETPW_R_SIZE_MAX);
if (buflen == -1)
if (buflen < 0)
buflen = 8196;
char* buf = (char*)malloc(buflen);
const size_t s = 1ULL + (size_t)buflen;
char* buf = calloc(s, sizeof(char));
if (!buf)
return FALSE;

5
winpr/libwinpr/sspicli/sspicli.c
View File

@ -153,10 +153,11 @@ BOOL LogonUserA(LPCSTR lpszUsername, LPCSTR lpszDomain, LPCSTR lpszPassword, DWO
}
long buflen = sysconf(_SC_GETPW_R_SIZE_MAX);
if (buflen == -1)
if (buflen < 0)
buflen = 8196;
char* buf = (char*)calloc(buflen + 1, sizeof(char));
const size_t s = 1ULL + (size_t)buflen;
char* buf = (char*)calloc(s, sizeof(char));
if (!buf)
goto fail;