From a22bd407b0a1cb63d27f8a531b96c85f8efd506f Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Wed, 23 Jun 2021 10:09:10 +0530 Subject: [PATCH] winpr: Fix typo in NTLM_AV_ID member. According to Microsoft specifications[1] the 10th member is named as MsvAvChannelBindings. [1]: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-nlmp/ --- winpr/libwinpr/sspi/NTLM/ntlm.h | 2 +- winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/winpr/libwinpr/sspi/NTLM/ntlm.h b/winpr/libwinpr/sspi/NTLM/ntlm.h index 820e25bce..21ae893a3 100644 --- a/winpr/libwinpr/sspi/NTLM/ntlm.h +++ b/winpr/libwinpr/sspi/NTLM/ntlm.h @@ -89,7 +89,7 @@ enum _NTLM_AV_ID MsvAvTimestamp, MsvAvSingleHost, MsvAvTargetName, - MsvChannelBindings + MsvAvChannelBindings }; typedef enum _NTLM_AV_ID NTLM_AV_ID; diff --git a/winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.c b/winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.c index c5c12b6b4..fa9fbe5ec 100644 --- a/winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.c +++ b/winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.c @@ -75,8 +75,8 @@ static const char* get_av_pair_string(UINT16 pair) return "MsvAvSingleHost"; case MsvAvTargetName: return "MsvAvTargetName"; - case MsvChannelBindings: - return "MsvChannelBindings"; + case MsvAvChannelBindings: + return "MsvAvChannelBindings"; default: return "UNKNOWN"; } @@ -639,7 +639,7 @@ int ntlm_construct_authenticate_target_info(NTLM_CONTEXT* context) * SEC_CHANNEL_BINDINGS structure * http://msdn.microsoft.com/en-us/library/windows/desktop/dd919963/ */ - AvPairsCount++; /* MsvChannelBindings */ + AvPairsCount++; /* MsvAvChannelBindings */ AvPairsValueLength += 16; ntlm_compute_channel_bindings(context); @@ -727,8 +727,8 @@ int ntlm_construct_authenticate_target_info(NTLM_CONTEXT* context) if (!context->SuppressExtendedProtection) { - if (!ntlm_av_pair_add(AuthenticateTargetInfo, cbAuthenticateTargetInfo, MsvChannelBindings, - context->ChannelBindingsHash, 16)) + if (!ntlm_av_pair_add(AuthenticateTargetInfo, cbAuthenticateTargetInfo, + MsvAvChannelBindings, context->ChannelBindingsHash, 16)) goto fail; if (context->ServicePrincipalName.Length > 0)