mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed memory leak in update_recv_surfcmd_surface_bits

Browse Source
This commit is contained in:
Armin Novak 2018-10-22 14:41:59 +02:00
parent 3ed50aaca2
commit 900abb61f7
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
libfreerdp/core/surface.c
View File

@ -87,20 +87,17 @@ static BOOL update_recv_surfcmd_bitmap_ex(wStream* s, TS_BITMAP_DATA_EX* bmp)
static BOOL update_recv_surfcmd_surface_bits(rdpUpdate* update, wStream* s) static BOOL update_recv_surfcmd_surface_bits(rdpUpdate* update, wStream* s)
{ {
SURFACE_BITS_COMMAND* cmd = calloc(1, sizeof(SURFACE_BITS_COMMAND)); SURFACE_BITS_COMMAND cmd = {0};
if (!cmd)
return FALSE;
if (Stream_GetRemainingLength(s) < 8) if (Stream_GetRemainingLength(s) < 8)
goto fail; goto fail;
Stream_Read_UINT16(s, cmd->destLeft); Stream_Read_UINT16(s, cmd.destLeft);
Stream_Read_UINT16(s, cmd->destTop); Stream_Read_UINT16(s, cmd.destTop);
Stream_Read_UINT16(s, cmd->destRight); Stream_Read_UINT16(s, cmd.destRight);
Stream_Read_UINT16(s, cmd->destBottom); Stream_Read_UINT16(s, cmd.destBottom);
if (!update_recv_surfcmd_bitmap_ex(s, &cmd->bmp)) if (!update_recv_surfcmd_bitmap_ex(s, &cmd.bmp))
goto fail; goto fail;
if (!update->SurfaceBits) if (!update->SurfaceBits)
@ -109,9 +106,8 @@ static BOOL update_recv_surfcmd_surface_bits(rdpUpdate* update, wStream* s)
goto fail; goto fail;
} }
return update->SurfaceBits(update->context, cmd); return update->SurfaceBits(update->context, &cmd);
fail: fail:
free_surface_bits_command(update->context, cmd);
return FALSE; return FALSE;
} }