Ignore unknown keywords for windows and posix type detection.

Eliminates wrong detection in case of an unknown keyword used.
This commit is contained in:
Armin Novak 2018-12-11 11:42:25 +01:00
parent fc9e88d64f
commit 864ad5e681

View File

@ -1268,7 +1268,7 @@ int freerdp_detect_posix_style_command_line_syntax(int argc, char** argv,
}
static BOOL freerdp_client_detect_command_line(int argc, char** argv,
DWORD* flags, BOOL ignoreUnknown)
DWORD* flags)
{
int old_cli_status;
int old_cli_count;
@ -1277,6 +1277,7 @@ static BOOL freerdp_client_detect_command_line(int argc, char** argv,
int windows_cli_status;
size_t windows_cli_count;
BOOL compatibility = FALSE;
const BOOL ignoreUnknown = TRUE;
windows_cli_status = freerdp_detect_windows_style_command_line_syntax(argc,
argv, &windows_cli_count, ignoreUnknown);
posix_cli_status = freerdp_detect_posix_style_command_line_syntax(argc, argv,
@ -1479,11 +1480,9 @@ int freerdp_client_settings_parse_command_line_arguments(rdpSettings* settings,
}
if (!ext && !assist)
compatibility = freerdp_client_detect_command_line(argc, argv, &flags,
allowUnknown);
compatibility = freerdp_client_detect_command_line(argc, argv, &flags);
else
compatibility = freerdp_client_detect_command_line(argc - 1, &argv[1], &flags,
allowUnknown);
compatibility = freerdp_client_detect_command_line(argc - 1, &argv[1], &flags);
settings->ProxyHostname = NULL;
settings->ProxyUsername = NULL;