mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[coverity] 1543094 Use of auto that causes a copy

Browse Source
This commit is contained in:
Armin Novak 2024-04-15 10:18:00 +02:00 committed by akallabeth
parent 237dfcbd9f
commit 8633a437e0
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
client/SDL/dialogs/sdl_connection_dialog.cpp
View File

@ -218,7 +218,7 @@ bool SDLConnectionDialog::handle(const SDL_Event& event)
case SDL_KEYUP: case SDL_KEYUP:
if (visible()) if (visible())
{ {
auto ev = reinterpret_cast<const SDL_KeyboardEvent&>(event); auto& ev = reinterpret_cast<const SDL_KeyboardEvent&>(event);
update(_renderer); update(_renderer);
switch (event.key.keysym.sym) switch (event.key.keysym.sym)
{ {
@ -245,7 +245,7 @@ bool SDLConnectionDialog::handle(const SDL_Event& event)
case SDL_MOUSEMOTION: case SDL_MOUSEMOTION:
if (visible()) if (visible())
{ {
auto ev = reinterpret_cast<const SDL_MouseMotionEvent&>(event); auto& ev = reinterpret_cast<const SDL_MouseMotionEvent&>(event);
_buttons.set_mouseover(event.button.x, event.button.y); _buttons.set_mouseover(event.button.x, event.button.y);
update(_renderer); update(_renderer);
@ -256,7 +256,7 @@ bool SDLConnectionDialog::handle(const SDL_Event& event)
case SDL_MOUSEBUTTONUP: case SDL_MOUSEBUTTONUP:
if (visible()) if (visible())
{ {
auto ev = reinterpret_cast<const SDL_MouseButtonEvent&>(event); auto& ev = reinterpret_cast<const SDL_MouseButtonEvent&>(event);
update(_renderer); update(_renderer);
auto button = _buttons.get_selected(event.button); auto button = _buttons.get_selected(event.button);
@ -275,7 +275,7 @@ bool SDLConnectionDialog::handle(const SDL_Event& event)
case SDL_MOUSEWHEEL: case SDL_MOUSEWHEEL:
if (visible()) if (visible())
{ {
auto ev = reinterpret_cast<const SDL_MouseWheelEvent&>(event); auto& ev = reinterpret_cast<const SDL_MouseWheelEvent&>(event);
update(_renderer); update(_renderer);
return windowID == ev.windowID; return windowID == ev.windowID;
} }
@ -284,7 +284,7 @@ bool SDLConnectionDialog::handle(const SDL_Event& event)
case SDL_FINGERDOWN: case SDL_FINGERDOWN:
if (visible()) if (visible())
{ {
auto ev = reinterpret_cast<const SDL_TouchFingerEvent&>(event); auto& ev = reinterpret_cast<const SDL_TouchFingerEvent&>(event);
update(_renderer); update(_renderer);
#if SDL_VERSION_ATLEAST(2, 0, 18) #if SDL_VERSION_ATLEAST(2, 0, 18)
return windowID == ev.windowID; return windowID == ev.windowID;
@ -295,7 +295,7 @@ bool SDLConnectionDialog::handle(const SDL_Event& event)
return false; return false;
case SDL_WINDOWEVENT: case SDL_WINDOWEVENT:
{ {
auto ev = reinterpret_cast<const SDL_WindowEvent&>(event); auto& ev = reinterpret_cast<const SDL_WindowEvent&>(event);
switch (ev.event) switch (ev.event)
{ {
case SDL_WINDOWEVENT_CLOSE: case SDL_WINDOWEVENT_CLOSE: