From 78fd3b8d6c758fc561a22e8f6f7a74b75dcf6b8b Mon Sep 17 00:00:00 2001 From: Steve Pronovost Date: Wed, 20 Oct 2021 09:06:16 -0700 Subject: [PATCH] Code review feedback from FreeRDP folks Before rolling into path for easy review. --- include/freerdp/channels/gfxredir.h | 1 - include/freerdp/update.h | 2 +- libfreerdp/core/listener.c | 4 ++++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/freerdp/channels/gfxredir.h b/include/freerdp/channels/gfxredir.h index cf6e20ed0..5290f3945 100644 --- a/include/freerdp/channels/gfxredir.h +++ b/include/freerdp/channels/gfxredir.h @@ -82,7 +82,6 @@ struct _GFXREDIR_CAPS_HEADER UINT32 signature; // GFXREDIR_CAPS_SIGNATURE UINT32 version; // GFXREDIR_CAPS_VERSION UINT32 length; // GFXREDIR_CAPS_HEADER_SIZE + size of capsData - const BYTE capsData[0]; // GFXREDIR_CAPS_HEADER.length - GFXREDIR_CAPS_HEADER_SIZE }; typedef struct _GFXREDIR_CAPS_HEADER GFXREDIR_CAPS_HEADER; diff --git a/include/freerdp/update.h b/include/freerdp/update.h index 1b2bb14cf..ec5336a26 100644 --- a/include/freerdp/update.h +++ b/include/freerdp/update.h @@ -254,7 +254,7 @@ struct rdp_update wStream* us; UINT16 numberOrders; - UINT16 offsetOrders; /* the offset to patch numberOrders in the stream */ + size_t offsetOrders; /* the offset to patch numberOrders in the stream */ BOOL combineUpdates; rdpBounds currentBounds; rdpBounds previousBounds; diff --git a/libfreerdp/core/listener.c b/libfreerdp/core/listener.c index 39ccb1074..22fc98126 100644 --- a/libfreerdp/core/listener.c +++ b/libfreerdp/core/listener.c @@ -321,7 +321,11 @@ BOOL freerdp_peer_set_local_and_hostname(freerdp_peer* client, } #ifndef _WIN32 +#ifdef AF_VSOCK else if (peer_addr->ss_family == AF_UNIX || peer_addr->ss_family == AF_VSOCK) +#else + else if (peer_addr->ss_family == AF_UNIX) +#endif client->local = TRUE; #endif