mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core: fix problem with data for unknown channel

Browse Source 
Some buggy server(s) send data for channels that weren't announced or
negotiated. When processing this data FreeRDP had a problem and always
used the last channel in the channels list even if it wasn't responsible
for the data. Depending on how the channel handled the data this could
lead to different kind of problems and also segmentation faults.

Now data for unknown channels is ignored and not processed further.
This commit is contained in:
Bernhard Miklautz 2014-12-16 16:27:55 +01:00
parent 65214b49b9
commit 78d68598ed
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libfreerdp/core/client.c
View File

@ -242,8 +242,6 @@ int freerdp_channels_data(freerdp* instance, UINT16 channelId, BYTE* data, int d
for (index = 0; index < mcs->channelCount; index++) for (index = 0; index < mcs->channelCount; index++)
{ {
channel = &mcs->channels[index];
if (mcs->channels[index].ChannelId == channelId) if (mcs->channels[index].ChannelId == channelId)
{ {
channel = &mcs->channels[index]; channel = &mcs->channels[index];