mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Added return checks for HashTable_Add

Browse Source 
(cherry picked from commit ea8f93441d523e103746dfeceab98420c05e0bac)
This commit is contained in:
Armin Novak 2020-07-08 10:26:34 +02:00 committed by akallabeth
parent cbd7964468
commit 7469f53c0d
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
channels/urbdrc/client/libusb/libusb_udevice.c
View File

@ -1172,7 +1172,16 @@ static int libusb_udev_isoch_transfer(IUDEVICE* idev, URBDRC_CHANNEL_CALLBACK* c
#endif
libusb_set_iso_packet_lengths(iso_transfer, iso_packet_size);
HashTable_Add(pdev->request_queue, (void*)(size_t)streamID, iso_transfer);
if ((HashTable_Contains(pdev->request_queue, (void*)(size_t)streamID)) ||
(HashTable_Add(pdev->request_queue, (void*)(size_t)streamID, iso_transfer) < 0))
{
WLog_Print(urbdrc->log, WLOG_WARN,
"Failed to queue iso transfer, streamID %08" PRIx32 " already in use!",
streamID);
async_transfer_user_data_free(user_data);
libusb_free_transfer(iso_transfer);
return -1;
}
return libusb_submit_transfer(iso_transfer);
}
@ -1282,7 +1291,15 @@ static int libusb_udev_bulk_or_interrupt_transfer(IUDEVICE* idev, URBDRC_CHANNEL
#else
user_data->streamID = streamID;
#endif
HashTable_Add(pdev->request_queue, (void*)(size_t)streamID, transfer);
if ((HashTable_Contains(pdev->request_queue, (void*)(size_t)streamID)) ||
(HashTable_Add(pdev->request_queue, (void*)(size_t)streamID, transfer) < 0))
{
WLog_Print(urbdrc->log, WLOG_WARN,
"Failed to queue transfer, streamID %08" PRIx32 " already in use!", streamID);
async_transfer_user_data_free(user_data);
libusb_free_transfer(transfer);
return -1;
}
return libusb_submit_transfer(transfer);
}