mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed possible race on file creation.

Browse Source
This commit is contained in:
Armin Novak 2015-12-14 09:23:42 +01:00
parent 65062633c2
commit 6010932984
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
winpr/libwinpr/file/file.c
View File

@ -456,6 +456,7 @@ static HANDLE FileCreateFileA(LPCSTR lpFileName, DWORD dwDesiredAccess, DWORD dw
BOOL create;
const char* mode = FileGetMode(dwDesiredAccess, dwCreationDisposition, &create);
int lock;
FILE* fp = NULL;
pFile = (WINPR_FILE*) calloc(1, sizeof(WINPR_FILE));
if (!pFile)
@ -484,22 +485,24 @@ static HANDLE FileCreateFileA(LPCSTR lpFileName, DWORD dwDesiredAccess, DWORD dw
if (create)
{
FILE* fp = fopen(pFile->lpFileName, "ab");
fp = fopen(pFile->lpFileName, "ab");
if (!fp)
{
free(pFile->lpFileName);
free(pFile);
return INVALID_HANDLE_VALUE;
}
fclose(fp);
fp = freopen(pFile->lpFileName, mode, fp);
}
{
FILE* fp = fopen(pFile->lpFileName, mode);
pFile->fd = -1;
if (fp)
pFile->fd = fileno(fp);
}
if (NULL == fp)
fp = fopen(pFile->lpFileName, mode);
pFile->fd = -1;
if (fp)
pFile->fd = fileno(fp);
if (pFile->fd < 0)
{
WLog_ERR(TAG, "Failed to open file %s with mode %s",