mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cache: Check return value from offscreen_cache_get

Browse Source 
Currently, SetSurface is called regardless of return value from
offscreen_cache_get. It may happen that bitmap is not found in a
cache from some reason, which may lead to segfaults. Let's check
the returned value before use.

https://github.com/FreeRDP/FreeRDP/issues/4117
This commit is contained in:
Ondrej Holy 2017-09-04 18:48:25 +02:00
parent 4239660e34
commit 5d6e2078c7
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libfreerdp/cache/offscreen.c vendored
View File

@ -101,6 +101,9 @@ static BOOL update_gdi_switch_surface(rdpContext* context,
{ {
rdpBitmap* bmp; rdpBitmap* bmp;
bmp = offscreen_cache_get(cache->offscreen, switchSurface->bitmapId); bmp = offscreen_cache_get(cache->offscreen, switchSurface->bitmapId);
if (bmp == NULL)
return FALSE;
bitmap->SetSurface(context, bmp, FALSE); bitmap->SetSurface(context, bmp, FALSE);
} }