mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[client,common] do not create useless copy

Browse Source 
The command line argument does not need to be copied twice
This commit is contained in:
Armin Novak 2023-12-13 13:40:25 +01:00 committed by Martin Fleisz
parent d3716ef0ba
commit 4b3a479557
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
client/common/cmdline.c
View File

@ -4287,7 +4287,8 @@ static int freerdp_client_settings_parse_command_line_arguments_int(
#endif
CommandLineSwitchCase(arg, "u")
{
user = _strdup(arg->Value);
WINPR_ASSERT(arg->Value);
user = arg->Value;
}
CommandLineSwitchCase(arg, "d")
{
@ -5143,19 +5144,13 @@ static int freerdp_client_settings_parse_command_line_arguments_int(
{
if (!freerdp_settings_get_string(settings, FreeRDP_Domain) && user)
{
BOOL ret = FALSE;
if (!freerdp_settings_set_string(settings, FreeRDP_Username, NULL))
goto fail;
return COMMAND_LINE_ERROR;
if (!freerdp_settings_set_string(settings, FreeRDP_Domain, NULL))
goto fail;
return COMMAND_LINE_ERROR;
ret = freerdp_parse_username_settings(user, settings, FreeRDP_Username, FreeRDP_Domain);
fail:
free(user);
if (!ret)
if (!freerdp_parse_username_settings(user, settings, FreeRDP_Username, FreeRDP_Domain))
return COMMAND_LINE_ERROR;
}
else