mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed resource cleanup.

Browse Source
This commit is contained in:
Armin Novak 2017-11-14 11:22:07 +01:00
parent 77134d9def
commit 4ab26a334a
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
channels/sshagent/client/sshagent_main.c
View File

@ -255,6 +255,7 @@ static UINT sshagent_on_close(IWTSVirtualChannelCallback* pChannelCallback)
} }
CloseHandle(callback->thread); CloseHandle(callback->thread);
LeaveCriticalSection(&callback->lock);
DeleteCriticalSection(&callback->lock); DeleteCriticalSection(&callback->lock);
free(callback); free(callback);
return CHANNEL_RC_OK; return CHANNEL_RC_OK;
@ -287,6 +288,7 @@ static UINT sshagent_on_new_channel_connection(IWTSListenerCallback* pListenerCa
if (callback->agent_fd == -1) if (callback->agent_fd == -1)
{ {
free(callback);
return CHANNEL_RC_INITIALIZATION_ERROR; return CHANNEL_RC_INITIALIZATION_ERROR;
} }
@ -308,6 +310,8 @@ static UINT sshagent_on_new_channel_connection(IWTSListenerCallback* pListenerCa
if (!callback->thread) if (!callback->thread)
{ {
WLog_ERR(TAG, "CreateThread failed!"); WLog_ERR(TAG, "CreateThread failed!");
DeleteCriticalSection(&callback->lock);
free(callback);
return CHANNEL_RC_INITIALIZATION_ERROR; return CHANNEL_RC_INITIALIZATION_ERROR;
} }
@ -341,6 +345,8 @@ static UINT sshagent_plugin_initialize(IWTSPlugin* pPlugin, IWTSVirtualChannelMa
if (sshagent->listener_callback->agent_uds_path == NULL) if (sshagent->listener_callback->agent_uds_path == NULL)
{ {
WLog_ERR(TAG, "Environment variable $SSH_AUTH_SOCK undefined!"); WLog_ERR(TAG, "Environment variable $SSH_AUTH_SOCK undefined!");
free(sshagent->listener_callback);
sshagent->listener_callback = NULL;
return CHANNEL_RC_INITIALIZATION_ERROR; return CHANNEL_RC_INITIALIZATION_ERROR;
} }