mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not assert transport->frontBio

Browse Source 
transport_attach might be called more than once so it might already
be initialized with an old value
This commit is contained in:
akallabeth 2022-04-29 10:03:09 +02:00 committed by akallabeth
parent 1819c24808
commit 4a782055a2
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libfreerdp/core/transport.c
View File

@ -175,7 +175,7 @@ static BOOL transport_default_attach(rdpTransport* transport, int sockfd)
goto fail;
bufferedBio = BIO_push(bufferedBio, socketBio);
WINPR_ASSERT(!transport->frontBio);
WINPR_ASSERT(bufferedBio);
transport->frontBio = bufferedBio;
return TRUE;
fail:
@ -371,8 +371,8 @@ BOOL transport_connect(rdpTransport* transport, const char* hostname, UINT16 por
if (status)
{
WINPR_ASSERT(!transport->frontBio);
transport->frontBio = rdg_get_front_bio_and_take_ownership(transport->rdg);
WINPR_ASSERT(transport->frontBio);
BIO_set_nonblock(transport->frontBio, 0);
transport->layer = TRANSPORT_LAYER_TSG;
status = TRUE;
@ -397,7 +397,6 @@ BOOL transport_connect(rdpTransport* transport, const char* hostname, UINT16 por
if (status)
{
WINPR_ASSERT(!transport->frontBio);
transport->frontBio = tsg_get_bio(transport->tsg);
transport->layer = TRANSPORT_LAYER_TSG;
status = TRUE;