mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core: Fix possible memory leak in smartcard certificate enumeration

Browse Source 
When enumerating smartcard certificates we check if we have duplicates
in our certificate list. In case we detect a duplicate we just return
`TRUE` (indicating that we consumed the certificate info) but do not
free the smartcard info instance.
This commit is contained in:
Martin Fleisz 2023-04-28 10:18:01 +02:00 committed by akallabeth
parent ca13987e84
commit 4859a5dfd4
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libfreerdp/core/smartcardlogon.c
View File

@ -132,7 +132,10 @@ static BOOL add_cert_to_list(SmartcardCertInfo*** certInfoList, size_t* count,
for (size_t i = 0; i < curCount; ++i)
{
if (_wcscmp(curInfoList[i]->containerName, certInfo->containerName) == 0)
{
smartcardCertInfo_Free(certInfo);
return TRUE;
}
}
curInfoList = realloc(curInfoList, sizeof(SmartcardCertInfo*) * (curCount + 1));