mirrors
/
FreeRDP
mirror of https://github.com/FreeRDP/FreeRDP
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

server: proxy: fix leak in pf_context_copy_settings

This commit is contained in:
Kobi Mizrachi 2020-01-02 15:19:08 +02:00 committed by akallabeth
parent f3ffa19039
commit 47ca28b5c3
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
server/proxy/pf_context.c
View File

@ -131,7 +131,15 @@ BOOL pf_context_copy_settings(rdpSettings* dst, const rdpSettings* src)
{ {
/* adjust instance pointer for client's context */ /* adjust instance pointer for client's context */
dst->instance = before_copy->instance; dst->instance = before_copy->instance;
/* RdpServerRsaKey must be set to NULL if `dst` is client's context */
/*
* RdpServerRsaKey must be set to NULL if `dst` is client's context
* it must be freed before setting it to NULL to avoid a memory leak!
*/
free(dst->RdpServerRsaKey->Modulus);
free(dst->RdpServerRsaKey->PrivateExponent);
free(dst->RdpServerRsaKey);
dst->RdpServerRsaKey = NULL; dst->RdpServerRsaKey = NULL;
} }