mirrors
/
FreeRDP
mirror of https://github.com/FreeRDP/FreeRDP
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[core,transport] follow up to #10576 

document the behaviour and reference the place it is used to avoid
confusion on future code review
This commit is contained in:
akallabeth 2024-09-09 13:43:03 +02:00
parent cec6fef1de
commit 4253426e48
No known key found for this signature in database
GPG Key ID: A49454A3FC909FD5
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libfreerdp/core/transport.c
View File

@ -326,7 +326,19 @@ static BOOL transport_default_connect_tls(rdpTransport* transport)
}
transport->frontBio = tls->bio;
BIO_callback_ctrl(tls->bio, BIO_CTRL_SET_CALLBACK, (BIO_info_cb*)transport_ssl_cb);
/* See libfreerdp/crypto/tls.c transport_default_connect_tls
*
* we are wrapping a SSL object in the BIO and actually want to set
*
* SSL_set_info_callback there. So ensure our callback is of appropriate
* type for that instead of what the function prototype suggests.
*/
typedef void (*ssl_cb_t)(const SSL* ssl, int type, int val);
ssl_cb_t fkt = transport_ssl_cb;
BIO_info_cb* bfkt = WINPR_FUNC_PTR_CAST(fkt, BIO_info_cb*);
BIO_callback_ctrl(tls->bio, BIO_CTRL_SET_CALLBACK, bfkt);
SSL_set_app_data(tls->ssl, transport);
if (!transport->frontBio)